From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by sourceware.org (Postfix) with ESMTPS id 2085D3856DFC; Mon, 12 Sep 2022 15:55:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2085D3856DFC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=foss.st.com Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28CDrsCW026853; Mon, 12 Sep 2022 17:55:32 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=date : from : to : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=selector1; bh=b/G6FIIDF9f788SqeNHLmvxy6ovUGbjR9rxX2bEuBAw=; b=uVGONTeGuA5pZJ1DXcLrbSMx8pyKEHbZYfGFSje6EGp0dR1pnkMHIYbX7Q+PP8efvJql toYL8MRgF4uk1O4WyreQyKLB5VrW6XZIS3mAxUmO/h6csmdD5OuPwZKmcTnDARLUIRkS eJf2R+oqviHYdjEFTz+gOiFYh76zzQbrfAvlBYd+sz7gUkVUQs0Im67DyNP28PZ6Fh/i SeFAwwLAxndgk3DEwURlIBlMt7TQpPqQkEwQQ89mkbSUNgp2zwtubhiZ01/0lItm85QA kCwPyqshGJHtG5I4gBKn2Lv/xpmcm3+2e+x41MfGlVBjQBSHKKlwaRYQCy8ufb0o0kip 3Q== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3jgjwv3726-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Sep 2022 17:55:32 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id BED0210002A; Mon, 12 Sep 2022 17:55:28 +0200 (CEST) Received: from Webmail-eu.st.com (eqndag1node5.st.com [10.75.129.134]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id B454523C697; Mon, 12 Sep 2022 17:55:28 +0200 (CEST) Received: from gnbcxd0114.gnb.st.com (10.75.127.46) by EQNDAG1NODE5.st.com (10.75.129.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2375.31; Mon, 12 Sep 2022 17:55:28 +0200 Date: Mon, 12 Sep 2022 17:55:27 +0200 From: Yvan Roux To: , =?utf-8?B?VG9yYmrDtnJu?= SVENSSON , , Subject: Re: [PATCH] testsuite: gluefile file need to be prefixed Message-ID: <20220912155527.GA11462@gnbcxd0114.gnb.st.com> References: <20220909130313.2562293-1-torbjorn.svensson@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To EQNDAG1NODE5.st.com (10.75.129.134) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-12_11,2022-09-12_02,2022-06-22_01 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Richard, On Mon, Sep 12, 2022 at 12:56:52PM +0100, Richard Sandiford via Gcc-patches wrote: > Torbjörn SVENSSON via Gcc-patches writes: > > PR/95720 > > When the status wrapper is used, the gluefile need to be prefixed with > > -Wl, in order for the test cases to have the dump files with the > > expected names. > > > > gcc/testsuite/ChangeLog: > > > > * gcc/testsuite/lib/g++.exp: Moved gluefile block to after > > flags have been prefixed for the target_compile call. > > * gcc/testsuite/lib/gcc.exp: Likewise. > > * gcc/testsuite/lib/wrapper.exp: Reset adjusted state flag. > > I agree this looks right, but I'm curious how you ended up with the > behaviour seen in comment 16. I thought having: > > if { [target_info needs_status_wrapper] != "" && [info exists gluefile] } { > lappend options "libs=${gluefile}" > lappend options "ldflags=${wrap_flags}" > } > > before the dg-additional-files-options/gcc_adjusted_linker_flags would > lead to the gluefile missing a "-Wl," first time round. How is it that > the gluefile still gets the "-Wl," and the -T misses it instead? The issue is that dg-additional-files-options/gcc_adjusted_linker_flags add the "-Wl," prefix to the content of the global variable and not to the one of