From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D45DE3858D38 for ; Thu, 22 Sep 2022 16:49:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D45DE3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663865359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mMdZjXsTIwMiUzjkJSOehlDbYKlEFdNGz0rNRn+SKBk=; b=fPvILZF1mRbqg5fmKTCPQsZKhF12W5U9hgzXnUIhjA29OCej+5jCS9+Mv5fSIDtp9yZ75C CFoi7Mp4CAIOVG8kAfOEcQHib8JXct9nzjyJ6uOl1nyd7IBZ1MWbHoSG/wVRKjW8mB9Bnf xHGEJ1iHLvgKPAch35HfH2Uo45SjshQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-510-HNpWK5ydNguqqAiSOmmdIA-1; Thu, 22 Sep 2022 12:49:18 -0400 X-MC-Unique: HNpWK5ydNguqqAiSOmmdIA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 23116800186; Thu, 22 Sep 2022 16:49:18 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.192.141]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D07D340C6EC2; Thu, 22 Sep 2022 16:49:17 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 28MGnGDr2566234 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 22 Sep 2022 18:49:16 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 28MGnGsv2566233; Thu, 22 Sep 2022 18:49:16 +0200 From: Aldy Hernandez To: GCC patches Cc: Richard Biener , Jakub Jelinek , Andrew MacLeod , Aldy Hernandez Subject: [PATCH] frange: drop endpoints to min/max representable numbers for -ffinite-math-only. Date: Thu, 22 Sep 2022 18:49:11 +0200 Message-Id: <20220922164911.2566143-2-aldyh@redhat.com> In-Reply-To: <20220922164911.2566143-1-aldyh@redhat.com> References: <20220922164911.2566143-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Similarly to how we drop NANs to UNDEFINED when -ffinite-math-only, I think we can drop the numbers outside of the min/max representable numbers to the representable number. This means the endpoings to VR_VARYING for -ffinite-math-only can now be the min/max representable, instead of -INF and +INF. Saturating in the setter means that the upcoming implementation for binary operators no longer have to worry about doing the right thing for -ffinite-math-only. If the range goes outside the limits, it'll get chopped down. How does this look? Tested on x86-64 Linux. gcc/ChangeLog: * range-op-float.cc (build_le): Use vrp_val_*. (build_lt): Same. (build_ge): Same. (build_gt): Same. * value-range.cc (frange::set): Chop ranges outside of the representable numbers for -ffinite-math-only. (frange::normalize_kind): Use vrp_val*. (frange::verify_range): Same. (frange::set_nonnegative): Same. (range_tests_floats): Remove tests that depend on -INF and +INF. * value-range.h (real_max_representable): Add prototype. (real_min_representable): Same. (vrp_val_max): Set max representable number for -ffinite-math-only. (vrp_val_min): Same but for min. (frange::set_varying): Use vrp_val*. --- gcc/range-op-float.cc | 12 +++++++---- gcc/value-range.cc | 46 ++++++++++++++++++++----------------------- gcc/value-range.h | 30 ++++++++++++++++++++++------ 3 files changed, 53 insertions(+), 35 deletions(-) diff --git a/gcc/range-op-float.cc b/gcc/range-op-float.cc index 2bd3dc9253f..15ba19c2deb 100644 --- a/gcc/range-op-float.cc +++ b/gcc/range-op-float.cc @@ -232,7 +232,8 @@ build_le (frange &r, tree type, const frange &val) { gcc_checking_assert (!val.known_isnan ()); - r.set (type, dconstninf, val.upper_bound ()); + REAL_VALUE_TYPE ninf = *TREE_REAL_CST_PTR (vrp_val_min (type)); + r.set (type, ninf, val.upper_bound ()); // Add both zeros if there's the possibility of zero equality. frange_add_zeros (r, type); @@ -257,7 +258,8 @@ build_lt (frange &r, tree type, const frange &val) return false; } // We only support closed intervals. - r.set (type, dconstninf, val.upper_bound ()); + REAL_VALUE_TYPE ninf = *TREE_REAL_CST_PTR (vrp_val_min (type)); + r.set (type, ninf, val.upper_bound ()); return true; } @@ -268,7 +270,8 @@ build_ge (frange &r, tree type, const frange &val) { gcc_checking_assert (!val.known_isnan ()); - r.set (type, val.lower_bound (), dconstinf); + REAL_VALUE_TYPE inf = *TREE_REAL_CST_PTR (vrp_val_max (type)); + r.set (type, val.lower_bound (), inf); // Add both zeros if there's the possibility of zero equality. frange_add_zeros (r, type); @@ -294,7 +297,8 @@ build_gt (frange &r, tree type, const frange &val) } // We only support closed intervals. - r.set (type, val.lower_bound (), dconstinf); + REAL_VALUE_TYPE inf = *TREE_REAL_CST_PTR (vrp_val_max (type)); + r.set (type, val.lower_bound (), inf); return true; } diff --git a/gcc/value-range.cc b/gcc/value-range.cc index 7e8028eced2..e57d60e1bac 100644 --- a/gcc/value-range.cc +++ b/gcc/value-range.cc @@ -338,6 +338,18 @@ frange::set (tree min, tree max, value_range_kind kind) m_neg_nan = false; } + // For -ffinite-math-only we can drop ranges outside the + // representable numbers to min/max for the type. + if (flag_finite_math_only) + { + REAL_VALUE_TYPE min_repr = *TREE_REAL_CST_PTR (vrp_val_min (m_type)); + REAL_VALUE_TYPE max_repr = *TREE_REAL_CST_PTR (vrp_val_max (m_type)); + if (real_less (&m_min, &min_repr)) + m_min = min_repr; + if (real_less (&max_repr, &m_max)) + m_max = max_repr; + } + // Check for swapped ranges. gcc_checking_assert (tree_compare (LE_EXPR, min, max)); @@ -371,8 +383,8 @@ bool frange::normalize_kind () { if (m_kind == VR_RANGE - && real_isinf (&m_min, 1) - && real_isinf (&m_max, 0)) + && vrp_val_is_min (build_real (m_type, m_min)) + && vrp_val_is_max (build_real (m_type, m_max))) { if (m_pos_nan && m_neg_nan) { @@ -385,8 +397,8 @@ frange::normalize_kind () if (!m_pos_nan || !m_neg_nan) { m_kind = VR_RANGE; - m_min = dconstninf; - m_max = dconstinf; + m_min = *TREE_REAL_CST_PTR (vrp_val_min (m_type)); + m_max = *TREE_REAL_CST_PTR (vrp_val_max (m_type)); return true; } } @@ -706,8 +718,8 @@ frange::verify_range () case VR_VARYING: gcc_checking_assert (m_type); gcc_checking_assert (m_pos_nan && m_neg_nan); - gcc_checking_assert (real_isinf (&m_min, 1)); - gcc_checking_assert (real_isinf (&m_max, 0)); + gcc_checking_assert (vrp_val_is_min (build_real (m_type, m_min))); + gcc_checking_assert (vrp_val_is_max (build_real (m_type, m_max))); return; case VR_RANGE: gcc_checking_assert (m_type); @@ -732,7 +744,8 @@ frange::verify_range () // If all the properties are clear, we better not span the entire // domain, because that would make us varying. if (m_pos_nan && m_neg_nan) - gcc_checking_assert (!real_isinf (&m_min, 1) || !real_isinf (&m_max, 0)); + gcc_checking_assert (!vrp_val_is_min (build_real (m_type, m_min)) + || !vrp_val_is_max (build_real (m_type, m_max))); } // We can't do much with nonzeros yet. @@ -779,7 +792,7 @@ frange::zero_p () const void frange::set_nonnegative (tree type) { - set (type, dconst0, dconstinf); + set (type, dconst0, *TREE_REAL_CST_PTR (vrp_val_max (type))); // Set +NAN as the only possibility. if (HONOR_NANS (type)) @@ -3886,23 +3899,6 @@ range_tests_floats () r0.clear_nan (); ASSERT_FALSE (r0.varying_p ()); - // The endpoints of a VARYING are +-INF. - r0.set_varying (float_type_node); - ASSERT_TRUE (real_identical (&r0.lower_bound (), &dconstninf)); - ASSERT_TRUE (real_identical (&r0.upper_bound (), &dconstinf)); - - // The maximum representable range for a type is still a subset of VARYING. - REAL_VALUE_TYPE q, r; - real_min_representable (&q, float_type_node); - real_max_representable (&r, float_type_node); - r0 = frange (float_type_node, q, r); - // r0 is not a varying, because it does not include -INF/+INF. - ASSERT_FALSE (r0.varying_p ()); - // The upper bound of r0 must be less than +INF. - ASSERT_TRUE (real_less (&r0.upper_bound (), &dconstinf)); - // The lower bound of r0 must be greater than -INF. - ASSERT_TRUE (real_less (&dconstninf, &r0.lower_bound ())); - // For most architectures, where float and double are different // sizes, having the same endpoints does not necessarily mean the // ranges are equal. diff --git a/gcc/value-range.h b/gcc/value-range.h index 3668b331187..74879b76b40 100644 --- a/gcc/value-range.h +++ b/gcc/value-range.h @@ -593,6 +593,8 @@ extern void dump_value_range (FILE *, const vrange *); extern bool vrp_val_is_min (const_tree); extern bool vrp_val_is_max (const_tree); extern bool vrp_operand_equal_p (const_tree, const_tree); +inline void real_max_representable (REAL_VALUE_TYPE *r, const_tree type); +inline void real_min_representable (REAL_VALUE_TYPE *r, const_tree type); inline value_range_kind vrange::kind () const @@ -1009,7 +1011,15 @@ vrp_val_max (const_tree type) return wide_int_to_tree (const_cast (type), max); } if (frange::supports_p (type)) - return build_real (const_cast (type), dconstinf); + { + if (flag_finite_math_only) + { + REAL_VALUE_TYPE r; + real_max_representable (&r, type); + return build_real (const_cast (type), r); + } + return build_real (const_cast (type), dconstinf); + } return NULL_TREE; } @@ -1023,7 +1033,15 @@ vrp_val_min (const_tree type) if (POINTER_TYPE_P (type)) return build_zero_cst (const_cast (type)); if (frange::supports_p (type)) - return build_real (const_cast (type), dconstninf); + { + if (flag_finite_math_only) + { + REAL_VALUE_TYPE r; + real_min_representable (&r, type); + return build_real (const_cast (type), r); + } + return build_real (const_cast (type), dconstninf); + } return NULL_TREE; } @@ -1073,8 +1091,8 @@ frange::set_varying (tree type) { m_kind = VR_VARYING; m_type = type; - m_min = dconstninf; - m_max = dconstinf; + m_min = *TREE_REAL_CST_PTR (vrp_val_min (type)); + m_max = *TREE_REAL_CST_PTR (vrp_val_max (type)); m_pos_nan = true; m_neg_nan = true; } @@ -1133,7 +1151,7 @@ frange::clear_nan () // Set R to maximum representable value for TYPE. inline void -real_max_representable (REAL_VALUE_TYPE *r, tree type) +real_max_representable (REAL_VALUE_TYPE *r, const_tree type) { char buf[128]; get_max_float (REAL_MODE_FORMAT (TYPE_MODE (type)), @@ -1145,7 +1163,7 @@ real_max_representable (REAL_VALUE_TYPE *r, tree type) // Set R to minimum representable value for TYPE. inline void -real_min_representable (REAL_VALUE_TYPE *r, tree type) +real_min_representable (REAL_VALUE_TYPE *r, const_tree type) { real_max_representable (r, type); *r = real_value_negate (r); -- 2.37.1