From: Liwei Xu <liwei.xu@intel.com>
To: gcc-patches@gcc.gnu.org
Cc: richard.guenther@gmail.com, wilson@tuliptree.org, admin@levyhsu.com
Subject: [PATCH] Optimize nested permutation to single VEC_PERM_EXPR [PR54346]
Date: Mon, 26 Sep 2022 14:56:04 +0800 [thread overview]
Message-ID: <20220926065604.783193-1-liwei.xu@intel.com> (raw)
This patch implemented the optimization in PR 54346, which Merges
c = VEC_PERM_EXPR <a, b, VCST0>;
d = VEC_PERM_EXPR <c, c, VCST1>;
to
d = VEC_PERM_EXPR <a, b, NEW_VCST>;
Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}
tree-ssa/forwprop-19.c fail to pass but I'm not sure whether it
is ok to removed it.
gcc/ChangeLog:
PR target/54346
* match.pd: Merge the index of VCST then generates the new vec_perm.
gcc/testsuite/ChangeLog:
PR target/54346
* gcc.dg/pr54346.c: New test.
Co-authored-by: liuhongt <hongtao.liu@intel.com>
---
gcc/match.pd | 41 ++++++++++++++++++++++++++++++++++
gcc/testsuite/gcc.dg/pr54346.c | 13 +++++++++++
2 files changed, 54 insertions(+)
create mode 100755 gcc/testsuite/gcc.dg/pr54346.c
diff --git a/gcc/match.pd b/gcc/match.pd
index 345bcb701a5..9219b0a10e1 100644
--- a/gcc/match.pd
+++ b/gcc/match.pd
@@ -8086,6 +8086,47 @@ and,
(minus (mult (vec_perm @1 @1 @3) @2) @4)))
+/* (PR54346) Merge
+ c = VEC_PERM_EXPR <a, b, VCST0>;
+ d = VEC_PERM_EXPR <c, c, VCST1>;
+ to
+ d = VEC_PERM_EXPR <a, b, NEW_VCST>; */
+
+(simplify
+ (vec_perm (vec_perm@0 @1 @2 VECTOR_CST@3) @0 VECTOR_CST@4)
+ (with
+ {
+ if(!TYPE_VECTOR_SUBPARTS (type).is_constant())
+ return NULL_TREE;
+
+ tree op0;
+ machine_mode result_mode = TYPE_MODE (type);
+ machine_mode op_mode = TYPE_MODE (TREE_TYPE (@1));
+ int nelts = TYPE_VECTOR_SUBPARTS (type).to_constant();
+ vec_perm_builder builder0;
+ vec_perm_builder builder1;
+ vec_perm_builder builder2 (nelts, nelts, 1);
+
+ if (!tree_to_vec_perm_builder (&builder0, @3)
+ || !tree_to_vec_perm_builder (&builder1, @4))
+ return NULL_TREE;
+
+ vec_perm_indices sel0 (builder0, 2, nelts);
+ vec_perm_indices sel1 (builder1, 1, nelts);
+
+ for (int i = 0; i < nelts; i++)
+ builder2.quick_push (sel0[sel1[i].to_constant()]);
+
+ vec_perm_indices sel2 (builder2, 2, nelts);
+
+ if (!can_vec_perm_const_p (result_mode, op_mode, sel2, false))
+ return NULL_TREE;
+
+ op0 = vec_perm_indices_to_tree (TREE_TYPE (@4), sel2);
+ }
+ (vec_perm @1 @2 { op0; })))
+
+
/* Match count trailing zeroes for simplify_count_trailing_zeroes in fwprop.
The canonical form is array[((x & -x) * C) >> SHIFT] where C is a magic
constant which when multiplied by a power of 2 contains a unique value
diff --git a/gcc/testsuite/gcc.dg/pr54346.c b/gcc/testsuite/gcc.dg/pr54346.c
new file mode 100755
index 00000000000..d87dc3a79a5
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr54346.c
@@ -0,0 +1,13 @@
+/* { dg-do compile } */
+/* { dg-options "-O -fdump-tree-dse1" } */
+
+typedef int veci __attribute__ ((vector_size (4 * sizeof (int))));
+
+void fun (veci a, veci b, veci *i)
+{
+ veci c = __builtin_shuffle (a, b, __extension__ (veci) {1, 4, 2, 7});
+ *i = __builtin_shuffle (c, __extension__ (veci) { 7, 2, 1, 5 });
+}
+
+/* { dg-final { scan-tree-dump "VEC_PERM_EXPR.*{ 3, 6, 0, 0 }" "dse1" } } */
+/* { dg-final { scan-tree-dump-times "VEC_PERM_EXPR" 1 "dse1" } } */
\ No newline at end of file
--
2.18.2
next reply other threads:[~2022-09-26 6:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 6:56 Liwei Xu [this message]
2022-09-26 8:21 ` Richard Biener
2022-09-30 9:17 ` Richard Sandiford
2022-09-30 9:36 ` Xu, Liwei
2022-10-12 13:51 ` Xi Ruoyao
2022-10-13 6:15 ` Levy
2022-10-13 6:44 ` Xi Ruoyao
2022-10-13 8:15 ` Lulu Cheng
2022-10-13 11:10 ` Richard Biener
2022-10-14 1:09 ` Xu, Liwei
2022-10-14 1:49 ` Lulu Cheng
2022-10-14 6:18 ` Richard Biener
2022-10-14 6:34 ` Xu, Liwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220926065604.783193-1-liwei.xu@intel.com \
--to=liwei.xu@intel.com \
--cc=admin@levyhsu.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
--cc=wilson@tuliptree.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).