* [PATCH] arm: Define __ARM_FEATURE_AES and __ARM_FEATURE_SHA2 when march +crypto is selected
@ 2022-09-28 12:19 Andrea Corallo
2022-09-28 12:23 ` Kyrylo Tkachov
0 siblings, 1 reply; 3+ messages in thread
From: Andrea Corallo @ 2022-09-28 12:19 UTC (permalink / raw)
To: gcc-patches; +Cc: kyrylo.tkachov, Richard.Earnshaw, Andrea Corallo
Hi all,
this patch fixes the missing definition of __ARM_FEATURE_AES and
__ARM_FEATURE_SHA2 when AES SHA1 & SHA2 crypto instructions are
available [1] (read when march +crypto is selected).
Okay for master?
Thanks
Andrea
[1] <https://raw.githubusercontent.com/ARM-software/acle/main/main/acle.md>
/gcc/ChangeLog
2022-09-14 Andrea Corallo <andrea.corallo@arm.com>
* config/arm/arm-c.cc (arm_cpu_builtins): Define
__ARM_FEATURE_AES and __ARM_FEATURE_SHA2.
gcc/testsuite/ChangeLog
2022-09-14 Andrea Corallo <andrea.corallo@arm.com>
* gcc.target/arm/attr-crypto.c: Update test.
---
gcc/config/arm/arm-c.cc | 2 ++
gcc/testsuite/gcc.target/arm/attr-crypto.c | 8 ++++++++
2 files changed, 10 insertions(+)
diff --git a/gcc/config/arm/arm-c.cc b/gcc/config/arm/arm-c.cc
index a8697b8c62f..86c56bf2680 100644
--- a/gcc/config/arm/arm-c.cc
+++ b/gcc/config/arm/arm-c.cc
@@ -202,6 +202,8 @@ arm_cpu_builtins (struct cpp_reader* pfile)
def_or_undef_macro (pfile, "__ARM_FEATURE_QBIT", TARGET_ARM_QBIT);
def_or_undef_macro (pfile, "__ARM_FEATURE_SAT", TARGET_ARM_SAT);
def_or_undef_macro (pfile, "__ARM_FEATURE_CRYPTO", TARGET_CRYPTO);
+ def_or_undef_macro (pfile, "__ARM_FEATURE_AES", TARGET_CRYPTO);
+ def_or_undef_macro (pfile, "__ARM_FEATURE_SHA2", TARGET_CRYPTO);
def_or_undef_macro (pfile, "__ARM_FEATURE_UNALIGNED", unaligned_access);
diff --git a/gcc/testsuite/gcc.target/arm/attr-crypto.c b/gcc/testsuite/gcc.target/arm/attr-crypto.c
index cbd13a757d8..05e458f36b6 100644
--- a/gcc/testsuite/gcc.target/arm/attr-crypto.c
+++ b/gcc/testsuite/gcc.target/arm/attr-crypto.c
@@ -16,6 +16,14 @@
#error __ARM_FEATURE_CRYPTO not defined.
#endif
+#ifndef __ARM_FEATURE_AES
+#error __ARM_FEATURE_AES not defined.
+#endif
+
+#ifndef __ARM_FEATURE_SHA2
+#error __ARM_FEATURE_SHA2 not defined.
+#endif
+
#ifndef __ARM_NEON
#error __ARM_NEON not defined.
#endif
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] arm: Define __ARM_FEATURE_AES and __ARM_FEATURE_SHA2 when march +crypto is selected
2022-09-28 12:19 [PATCH] arm: Define __ARM_FEATURE_AES and __ARM_FEATURE_SHA2 when march +crypto is selected Andrea Corallo
@ 2022-09-28 12:23 ` Kyrylo Tkachov
2022-09-28 13:26 ` Andrea Corallo
0 siblings, 1 reply; 3+ messages in thread
From: Kyrylo Tkachov @ 2022-09-28 12:23 UTC (permalink / raw)
To: Andrea Corallo, gcc-patches; +Cc: Richard Earnshaw, Andrea Corallo
Hi Andrea,
> -----Original Message-----
> From: Andrea Corallo <andrea.corallo@arm.com>
> Sent: Wednesday, September 28, 2022 1:19 PM
> To: gcc-patches@gcc.gnu.org
> Cc: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>; Richard Earnshaw
> <Richard.Earnshaw@arm.com>; Andrea Corallo <Andrea.Corallo@arm.com>
> Subject: [PATCH] arm: Define __ARM_FEATURE_AES and
> __ARM_FEATURE_SHA2 when march +crypto is selected
>
> Hi all,
>
> this patch fixes the missing definition of __ARM_FEATURE_AES and
> __ARM_FEATURE_SHA2 when AES SHA1 & SHA2 crypto instructions are
> available [1] (read when march +crypto is selected).
>
> Okay for master?
Ok.
Thanks,
Kyrill
>
> Thanks
>
> Andrea
>
> [1] <https://raw.githubusercontent.com/ARM-
> software/acle/main/main/acle.md>
>
> /gcc/ChangeLog
>
> 2022-09-14 Andrea Corallo <andrea.corallo@arm.com>
>
> * config/arm/arm-c.cc (arm_cpu_builtins): Define
> __ARM_FEATURE_AES and __ARM_FEATURE_SHA2.
>
> gcc/testsuite/ChangeLog
>
> 2022-09-14 Andrea Corallo <andrea.corallo@arm.com>
>
> * gcc.target/arm/attr-crypto.c: Update test.
> ---
> gcc/config/arm/arm-c.cc | 2 ++
> gcc/testsuite/gcc.target/arm/attr-crypto.c | 8 ++++++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/gcc/config/arm/arm-c.cc b/gcc/config/arm/arm-c.cc
> index a8697b8c62f..86c56bf2680 100644
> --- a/gcc/config/arm/arm-c.cc
> +++ b/gcc/config/arm/arm-c.cc
> @@ -202,6 +202,8 @@ arm_cpu_builtins (struct cpp_reader* pfile)
> def_or_undef_macro (pfile, "__ARM_FEATURE_QBIT",
> TARGET_ARM_QBIT);
> def_or_undef_macro (pfile, "__ARM_FEATURE_SAT", TARGET_ARM_SAT);
> def_or_undef_macro (pfile, "__ARM_FEATURE_CRYPTO",
> TARGET_CRYPTO);
> + def_or_undef_macro (pfile, "__ARM_FEATURE_AES", TARGET_CRYPTO);
> + def_or_undef_macro (pfile, "__ARM_FEATURE_SHA2", TARGET_CRYPTO);
>
> def_or_undef_macro (pfile, "__ARM_FEATURE_UNALIGNED",
> unaligned_access);
>
> diff --git a/gcc/testsuite/gcc.target/arm/attr-crypto.c
> b/gcc/testsuite/gcc.target/arm/attr-crypto.c
> index cbd13a757d8..05e458f36b6 100644
> --- a/gcc/testsuite/gcc.target/arm/attr-crypto.c
> +++ b/gcc/testsuite/gcc.target/arm/attr-crypto.c
> @@ -16,6 +16,14 @@
> #error __ARM_FEATURE_CRYPTO not defined.
> #endif
>
> +#ifndef __ARM_FEATURE_AES
> +#error __ARM_FEATURE_AES not defined.
> +#endif
> +
> +#ifndef __ARM_FEATURE_SHA2
> +#error __ARM_FEATURE_SHA2 not defined.
> +#endif
> +
> #ifndef __ARM_NEON
> #error __ARM_NEON not defined.
> #endif
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: Define __ARM_FEATURE_AES and __ARM_FEATURE_SHA2 when march +crypto is selected
2022-09-28 12:23 ` Kyrylo Tkachov
@ 2022-09-28 13:26 ` Andrea Corallo
0 siblings, 0 replies; 3+ messages in thread
From: Andrea Corallo @ 2022-09-28 13:26 UTC (permalink / raw)
To: Kyrylo Tkachov; +Cc: gcc-patches, Richard Earnshaw
Kyrylo Tkachov <Kyrylo.Tkachov@arm.com> writes:
> Hi Andrea,
>
>> -----Original Message-----
>> From: Andrea Corallo <andrea.corallo@arm.com>
>> Sent: Wednesday, September 28, 2022 1:19 PM
>> To: gcc-patches@gcc.gnu.org
>> Cc: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>; Richard Earnshaw
>> <Richard.Earnshaw@arm.com>; Andrea Corallo <Andrea.Corallo@arm.com>
>> Subject: [PATCH] arm: Define __ARM_FEATURE_AES and
>> __ARM_FEATURE_SHA2 when march +crypto is selected
>>
>> Hi all,
>>
>> this patch fixes the missing definition of __ARM_FEATURE_AES and
>> __ARM_FEATURE_SHA2 when AES SHA1 & SHA2 crypto instructions are
>> available [1] (read when march +crypto is selected).
>>
>> Okay for master?
>
> Ok.
> Thanks,
> Kyrill
Into trunk as 5e9c4ed903c.
Thanks!
Andrea
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-28 13:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-28 12:19 [PATCH] arm: Define __ARM_FEATURE_AES and __ARM_FEATURE_SHA2 when march +crypto is selected Andrea Corallo
2022-09-28 12:23 ` Kyrylo Tkachov
2022-09-28 13:26 ` Andrea Corallo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).