public inbox for
 help / color / mirror / Atom feed
From: Stafford Horne <>
Cc:, Yann Morin <>,
	Stafford Horne <>
Subject: [PATCH] or1k: Only define TARGET_HAVE_TLS when HAVE_AS_TLS
Date: Thu, 29 Sep 2022 15:57:40 +0100	[thread overview]
Message-ID: <> (raw)

This was found when testing buildroot with linuxthreads enabled.  In
this case, the build passes --disable-tls to the toolchain during
configuration.  After building the OpenRISC toolchain it was still
generating TLS code sequences and causing linker failures such as:

 ..../or1k-buildroot-linux-uclibc-gcc -o gpsd-3.24/gpsctl .... -lusb-1.0 -lm -lrt -lnsl
 ..../ld: ..../sysroot/usr/lib/ undefined reference to `__tls_get_addr'

This patch fixes this by disabling tls for the OpenRISC target when requested
via --disable-tls.

Tested-by: Yann E. MORIN <>


	* config/or1k/ (TARGET_HAVE_TLS): Only define if
	HAVE_AS_TLS is defined.
 gcc/config/or1k/ | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gcc/config/or1k/ b/gcc/config/or1k/
index da2f59062ba..0ce7b234417 100644
--- a/gcc/config/or1k/
+++ b/gcc/config/or1k/
@@ -2206,8 +2206,10 @@ or1k_output_mi_thunk (FILE *file, tree thunk_fndecl,
 #define TARGET_LEGITIMATE_ADDRESS_P or1k_legitimate_address_p
+#ifdef HAVE_AS_TLS
 #define TARGET_HAVE_TLS true
 #define TARGET_HAVE_SPECULATION_SAFE_VALUE speculation_safe_value_not_needed

             reply	other threads:[~2022-09-29 14:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29 14:57 Stafford Horne [this message]
2022-10-01 11:35 ` Stafford Horne
2022-10-01 17:53   ` [Buildroot] " Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).