* [PATCH] testsuite: /dev/null is not accessible on Windows
@ 2022-09-29 17:38 Torbjörn SVENSSON
2022-10-05 9:22 ` PING^1 " Torbjorn SVENSSON
2022-10-05 9:34 ` Jonathan Yong
0 siblings, 2 replies; 5+ messages in thread
From: Torbjörn SVENSSON @ 2022-09-29 17:38 UTC (permalink / raw)
To: gcc-patches
Cc: richard.sandiford, ro, mikestump, Torbjörn SVENSSON, Yvan ROUX
When running the DejaGNU testsuite on a toolchain built for native
Windows, the path /dev/null can't be used to open a stream to void.
On native Windows, the resource is instead named "nul".
The error would look like this:
c:/arm-11.3.rel1/bin/../lib/gcc/arm-none-eabi/11.3.1/../../../../arm-none-eabi/bin/ld.exe: cannot find @/dev/null: No such file or directory
Patch has been verified on Windows and Linux.
gcc/testsuite:
* gcc.misc-tests/outputs.exp: Use "@nul" for Windows,
"@/dev/null" for other environments.
Co-Authored-By: Yvan ROUX <yvan.roux@foss.st.com>
Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
---
gcc/testsuite/gcc.misc-tests/outputs.exp | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/gcc/testsuite/gcc.misc-tests/outputs.exp b/gcc/testsuite/gcc.misc-tests/outputs.exp
index ab919db1ccb..3fe7270fa63 100644
--- a/gcc/testsuite/gcc.misc-tests/outputs.exp
+++ b/gcc/testsuite/gcc.misc-tests/outputs.exp
@@ -78,6 +78,13 @@ if {[board_info $dest exists output_format]} {
append link_options " additional_flags=-Wl,-oformat,[board_info $dest output_format]"
}
+
+set devnull "/dev/null"
+if { [info exists ::env(OS)] && [string match "Windows*" $::env(OS)] } {
+ # Windows uses special file named "nul" as a substitute for /dev/null
+ set devnull "nul"
+}
+
# Avoid possible influence from the make jobserver,
# otherwise ltrans0.ltrans_args files may be missing.
if [info exists env(MAKEFLAGS)] {
@@ -353,10 +360,10 @@ outest "$b-21 exe savetmp named2" $mult "-o $b.exe -save-temps" {} {{--1.i --1.s
# Additional files are created when an @file is used
if !$skip_atsave {
-outest "$b-22 exe savetmp namedb-2" $sing "@/dev/null -o $b.exe -save-temps" {} {{--0.i --0.s --0.o .args.0 !!$gld .ld1_args !0 .exe}}
-outest "$b-23 exe savetmp named2-2" $mult "@/dev/null -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o .args.0 !!$gld .ld1_args !0 .exe}}
-outest "$b-24 exe savetmp named2-3" $mult "@/dev/null -I dummy -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o -args.0 -args.1 .args.2 !!$gld .ld1_args !0 .exe}}
-outest "$b-25 exe savetmp named2-4" $mult "@/dev/null -I dummy -L dummy -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o -args.0 -args.1 .args.2 .args.3 !!$gld .ld1_args !0 .exe}}
+outest "$b-22 exe savetmp namedb-2" $sing "@$devnull -o $b.exe -save-temps" {} {{--0.i --0.s --0.o .args.0 !!$gld .ld1_args !0 .exe}}
+outest "$b-23 exe savetmp named2-2" $mult "@$devnull -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o .args.0 !!$gld .ld1_args !0 .exe}}
+outest "$b-24 exe savetmp named2-3" $mult "@$devnull -I dummy -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o -args.0 -args.1 .args.2 !!$gld .ld1_args !0 .exe}}
+outest "$b-25 exe savetmp named2-4" $mult "@$devnull -I dummy -L dummy -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o -args.0 -args.1 .args.2 .args.3 !!$gld .ld1_args !0 .exe}}
}
# Setting the main output to a dir selects it as the default aux&dump
@@ -714,7 +721,7 @@ outest "$b-291 lto mult named-2" $mult "-o $b.exe -O2 -flto -fno-use-linker-plug
outest "$b-292 lto sing nameddir-2" $sing "-o dir/$b.exe -O2 -flto -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized -fdump-rtl-final -fstack-usage" {dir/} {{--0.c.???i.icf --0.c.???r.final .wpa.???i.icf .ltrans0.ltrans.???r.final .ltrans0.ltrans.su .exe} {}}
outest "$b-293 lto mult nameddir-2" $mult "-o dir/$b.exe -O2 -flto -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized -fdump-rtl-final -fstack-usage" {dir/} {{--1.c.???i.icf --1.c.???r.final --2.c.???i.icf --2.c.???r.final .wpa.???i.icf .ltrans0.ltrans.???r.final .ltrans0.ltrans.su .exe} {}}
if !$skip_atsave {
-outest "$b-294 lto sing unnamed-3" $sing "@/dev/null -O2 -flto -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized -fdump-rtl-final -fstack-usage -save-temps $oaout" {} {{a--0.c.???i.icf a--0.c.???r.final a.wpa.???i.icf a.ltrans0.ltrans.???r.final a.ltrans0.ltrans.su a--0.o a--0.s a--0.i a.ltrans0.o a.ltrans.out a.ltrans0.ltrans.o a.ltrans0.ltrans_args a.args.0 a.ltrans0.ltrans.s a.wpa.args.0 a.lto_args a.ld1_args a.ltrans_args a.ltrans0.ltrans.args.0 a.ld_args $aout}}
+outest "$b-294 lto sing unnamed-3" $sing "@$devnull -O2 -flto -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized -fdump-rtl-final -fstack-usage -save-temps $oaout" {} {{a--0.c.???i.icf a--0.c.???r.final a.wpa.???i.icf a.ltrans0.ltrans.???r.final a.ltrans0.ltrans.su a--0.o a--0.s a--0.i a.ltrans0.o a.ltrans.out a.ltrans0.ltrans.o a.ltrans0.ltrans_args a.args.0 a.ltrans0.ltrans.s a.wpa.args.0 a.lto_args a.ld1_args a.ltrans_args a.ltrans0.ltrans.args.0 a.ld_args $aout}}
}
}
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* PING^1 [PATCH] testsuite: /dev/null is not accessible on Windows
2022-09-29 17:38 [PATCH] testsuite: /dev/null is not accessible on Windows Torbjörn SVENSSON
@ 2022-10-05 9:22 ` Torbjorn SVENSSON
2022-10-05 9:34 ` Jonathan Yong
1 sibling, 0 replies; 5+ messages in thread
From: Torbjorn SVENSSON @ 2022-10-05 9:22 UTC (permalink / raw)
To: gcc-patches; +Cc: ro, mikestump, Yvan ROUX, richard.earnshaw
Hi,
Ping, https://gcc.gnu.org/pipermail/gcc-patches/2022-September/602534.html
Kind regards,
Torbjörn
On 2022-09-29 19:38, Torbjörn SVENSSON wrote:
> When running the DejaGNU testsuite on a toolchain built for native
> Windows, the path /dev/null can't be used to open a stream to void.
> On native Windows, the resource is instead named "nul".
>
> The error would look like this:
> c:/arm-11.3.rel1/bin/../lib/gcc/arm-none-eabi/11.3.1/../../../../arm-none-eabi/bin/ld.exe: cannot find @/dev/null: No such file or directory
>
> Patch has been verified on Windows and Linux.
>
> gcc/testsuite:
>
> * gcc.misc-tests/outputs.exp: Use "@nul" for Windows,
> "@/dev/null" for other environments.
>
> Co-Authored-By: Yvan ROUX <yvan.roux@foss.st.com>
> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
> ---
> gcc/testsuite/gcc.misc-tests/outputs.exp | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.misc-tests/outputs.exp b/gcc/testsuite/gcc.misc-tests/outputs.exp
> index ab919db1ccb..3fe7270fa63 100644
> --- a/gcc/testsuite/gcc.misc-tests/outputs.exp
> +++ b/gcc/testsuite/gcc.misc-tests/outputs.exp
> @@ -78,6 +78,13 @@ if {[board_info $dest exists output_format]} {
> append link_options " additional_flags=-Wl,-oformat,[board_info $dest output_format]"
> }
>
> +
> +set devnull "/dev/null"
> +if { [info exists ::env(OS)] && [string match "Windows*" $::env(OS)] } {
> + # Windows uses special file named "nul" as a substitute for /dev/null
> + set devnull "nul"
> +}
> +
> # Avoid possible influence from the make jobserver,
> # otherwise ltrans0.ltrans_args files may be missing.
> if [info exists env(MAKEFLAGS)] {
> @@ -353,10 +360,10 @@ outest "$b-21 exe savetmp named2" $mult "-o $b.exe -save-temps" {} {{--1.i --1.s
>
> # Additional files are created when an @file is used
> if !$skip_atsave {
> -outest "$b-22 exe savetmp namedb-2" $sing "@/dev/null -o $b.exe -save-temps" {} {{--0.i --0.s --0.o .args.0 !!$gld .ld1_args !0 .exe}}
> -outest "$b-23 exe savetmp named2-2" $mult "@/dev/null -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o .args.0 !!$gld .ld1_args !0 .exe}}
> -outest "$b-24 exe savetmp named2-3" $mult "@/dev/null -I dummy -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o -args.0 -args.1 .args.2 !!$gld .ld1_args !0 .exe}}
> -outest "$b-25 exe savetmp named2-4" $mult "@/dev/null -I dummy -L dummy -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o -args.0 -args.1 .args.2 .args.3 !!$gld .ld1_args !0 .exe}}
> +outest "$b-22 exe savetmp namedb-2" $sing "@$devnull -o $b.exe -save-temps" {} {{--0.i --0.s --0.o .args.0 !!$gld .ld1_args !0 .exe}}
> +outest "$b-23 exe savetmp named2-2" $mult "@$devnull -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o .args.0 !!$gld .ld1_args !0 .exe}}
> +outest "$b-24 exe savetmp named2-3" $mult "@$devnull -I dummy -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o -args.0 -args.1 .args.2 !!$gld .ld1_args !0 .exe}}
> +outest "$b-25 exe savetmp named2-4" $mult "@$devnull -I dummy -L dummy -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o -args.0 -args.1 .args.2 .args.3 !!$gld .ld1_args !0 .exe}}
> }
>
> # Setting the main output to a dir selects it as the default aux&dump
> @@ -714,7 +721,7 @@ outest "$b-291 lto mult named-2" $mult "-o $b.exe -O2 -flto -fno-use-linker-plug
> outest "$b-292 lto sing nameddir-2" $sing "-o dir/$b.exe -O2 -flto -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized -fdump-rtl-final -fstack-usage" {dir/} {{--0.c.???i.icf --0.c.???r.final .wpa.???i.icf .ltrans0.ltrans.???r.final .ltrans0.ltrans.su .exe} {}}
> outest "$b-293 lto mult nameddir-2" $mult "-o dir/$b.exe -O2 -flto -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized -fdump-rtl-final -fstack-usage" {dir/} {{--1.c.???i.icf --1.c.???r.final --2.c.???i.icf --2.c.???r.final .wpa.???i.icf .ltrans0.ltrans.???r.final .ltrans0.ltrans.su .exe} {}}
> if !$skip_atsave {
> -outest "$b-294 lto sing unnamed-3" $sing "@/dev/null -O2 -flto -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized -fdump-rtl-final -fstack-usage -save-temps $oaout" {} {{a--0.c.???i.icf a--0.c.???r.final a.wpa.???i.icf a.ltrans0.ltrans.???r.final a.ltrans0.ltrans.su a--0.o a--0.s a--0.i a.ltrans0.o a.ltrans.out a.ltrans0.ltrans.o a.ltrans0.ltrans_args a.args.0 a.ltrans0.ltrans.s a.wpa.args.0 a.lto_args a.ld1_args a.ltrans_args a.ltrans0.ltrans.args.0 a.ld_args $aout}}
> +outest "$b-294 lto sing unnamed-3" $sing "@$devnull -O2 -flto -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized -fdump-rtl-final -fstack-usage -save-temps $oaout" {} {{a--0.c.???i.icf a--0.c.???r.final a.wpa.???i.icf a.ltrans0.ltrans.???r.final a.ltrans0.ltrans.su a--0.o a--0.s a--0.i a.ltrans0.o a.ltrans.out a.ltrans0.ltrans.o a.ltrans0.ltrans_args a.args.0 a.ltrans0.ltrans.s a.wpa.args.0 a.lto_args a.ld1_args a.ltrans_args a.ltrans0.ltrans.args.0 a.ld_args $aout}}
> }
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] testsuite: /dev/null is not accessible on Windows
2022-09-29 17:38 [PATCH] testsuite: /dev/null is not accessible on Windows Torbjörn SVENSSON
2022-10-05 9:22 ` PING^1 " Torbjorn SVENSSON
@ 2022-10-05 9:34 ` Jonathan Yong
2022-10-05 9:46 ` Torbjorn SVENSSON
2022-10-05 9:48 ` Jonathan Yong
1 sibling, 2 replies; 5+ messages in thread
From: Jonathan Yong @ 2022-10-05 9:34 UTC (permalink / raw)
To: gcc-patches
On 9/29/22 17:38, Torbjörn SVENSSON via Gcc-patches wrote:
> When running the DejaGNU testsuite on a toolchain built for native
> Windows, the path /dev/null can't be used to open a stream to void.
> On native Windows, the resource is instead named "nul".
>
> The error would look like this:
> c:/arm-11.3.rel1/bin/../lib/gcc/arm-none-eabi/11.3.1/../../../../arm-none-eabi/bin/ld.exe: cannot find @/dev/null: No such file or directory
>
> Patch has been verified on Windows and Linux.
>
> gcc/testsuite:
>
> * gcc.misc-tests/outputs.exp: Use "@nul" for Windows,
> "@/dev/null" for other environments.
>
> Co-Authored-By: Yvan ROUX <yvan.roux@foss.st.com>
> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
> ---
> gcc/testsuite/gcc.misc-tests/outputs.exp | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.misc-tests/outputs.exp b/gcc/testsuite/gcc.misc-tests/outputs.exp
> index ab919db1ccb..3fe7270fa63 100644
> --- a/gcc/testsuite/gcc.misc-tests/outputs.exp
> +++ b/gcc/testsuite/gcc.misc-tests/outputs.exp
> @@ -78,6 +78,13 @@ if {[board_info $dest exists output_format]} {
> append link_options " additional_flags=-Wl,-oformat,[board_info $dest output_format]"
> }
>
> +
> +set devnull "/dev/null"
> +if { [info exists ::env(OS)] && [string match "Windows*" $::env(OS)] } {
> + # Windows uses special file named "nul" as a substitute for /dev/null
> + set devnull "nul"
> +}
> +
> # Avoid possible influence from the make jobserver,
> # otherwise ltrans0.ltrans_args files may be missing.
> if [info exists env(MAKEFLAGS)] {
> @@ -353,10 +360,10 @@ outest "$b-21 exe savetmp named2" $mult "-o $b.exe -save-temps" {} {{--1.i --1.s
>
> # Additional files are created when an @file is used
> if !$skip_atsave {
> -outest "$b-22 exe savetmp namedb-2" $sing "@/dev/null -o $b.exe -save-temps" {} {{--0.i --0.s --0.o .args.0 !!$gld .ld1_args !0 .exe}}
> -outest "$b-23 exe savetmp named2-2" $mult "@/dev/null -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o .args.0 !!$gld .ld1_args !0 .exe}}
> -outest "$b-24 exe savetmp named2-3" $mult "@/dev/null -I dummy -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o -args.0 -args.1 .args.2 !!$gld .ld1_args !0 .exe}}
> -outest "$b-25 exe savetmp named2-4" $mult "@/dev/null -I dummy -L dummy -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o -args.0 -args.1 .args.2 .args.3 !!$gld .ld1_args !0 .exe}}
> +outest "$b-22 exe savetmp namedb-2" $sing "@$devnull -o $b.exe -save-temps" {} {{--0.i --0.s --0.o .args.0 !!$gld .ld1_args !0 .exe}}
> +outest "$b-23 exe savetmp named2-2" $mult "@$devnull -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o .args.0 !!$gld .ld1_args !0 .exe}}
> +outest "$b-24 exe savetmp named2-3" $mult "@$devnull -I dummy -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o -args.0 -args.1 .args.2 !!$gld .ld1_args !0 .exe}}
> +outest "$b-25 exe savetmp named2-4" $mult "@$devnull -I dummy -L dummy -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o -args.0 -args.1 .args.2 .args.3 !!$gld .ld1_args !0 .exe}}
> }
>
> # Setting the main output to a dir selects it as the default aux&dump
> @@ -714,7 +721,7 @@ outest "$b-291 lto mult named-2" $mult "-o $b.exe -O2 -flto -fno-use-linker-plug
> outest "$b-292 lto sing nameddir-2" $sing "-o dir/$b.exe -O2 -flto -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized -fdump-rtl-final -fstack-usage" {dir/} {{--0.c.???i.icf --0.c.???r.final .wpa.???i.icf .ltrans0.ltrans.???r.final .ltrans0.ltrans.su .exe} {}}
> outest "$b-293 lto mult nameddir-2" $mult "-o dir/$b.exe -O2 -flto -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized -fdump-rtl-final -fstack-usage" {dir/} {{--1.c.???i.icf --1.c.???r.final --2.c.???i.icf --2.c.???r.final .wpa.???i.icf .ltrans0.ltrans.???r.final .ltrans0.ltrans.su .exe} {}}
> if !$skip_atsave {
> -outest "$b-294 lto sing unnamed-3" $sing "@/dev/null -O2 -flto -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized -fdump-rtl-final -fstack-usage -save-temps $oaout" {} {{a--0.c.???i.icf a--0.c.???r.final a.wpa.???i.icf a.ltrans0.ltrans.???r.final a.ltrans0.ltrans.su a--0.o a--0.s a--0.i a.ltrans0.o a.ltrans.out a.ltrans0.ltrans.o a.ltrans0.ltrans_args a.args.0 a.ltrans0.ltrans.s a.wpa.args.0 a.lto_args a.ld1_args a.ltrans_args a.ltrans0.ltrans.args.0 a.ld_args $aout}}
> +outest "$b-294 lto sing unnamed-3" $sing "@$devnull -O2 -flto -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized -fdump-rtl-final -fstack-usage -save-temps $oaout" {} {{a--0.c.???i.icf a--0.c.???r.final a.wpa.???i.icf a.ltrans0.ltrans.???r.final a.ltrans0.ltrans.su a--0.o a--0.s a--0.i a.ltrans0.o a.ltrans.out a.ltrans0.ltrans.o a.ltrans0.ltrans_args a.args.0 a.ltrans0.ltrans.s a.wpa.args.0 a.lto_args a.ld1_args a.ltrans_args a.ltrans0.ltrans.args.0 a.ld_args $aout}}
> }
> }
>
Thanks, looks good to me, will push to master soon.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] testsuite: /dev/null is not accessible on Windows
2022-10-05 9:34 ` Jonathan Yong
@ 2022-10-05 9:46 ` Torbjorn SVENSSON
2022-10-05 9:48 ` Jonathan Yong
1 sibling, 0 replies; 5+ messages in thread
From: Torbjorn SVENSSON @ 2022-10-05 9:46 UTC (permalink / raw)
To: gcc-patches
Hi,
On 2022-10-05 11:34, Jonathan Yong via Gcc-patches wrote:
> On 9/29/22 17:38, Torbjörn SVENSSON via Gcc-patches wrote:
>> When running the DejaGNU testsuite on a toolchain built for native
>> Windows, the path /dev/null can't be used to open a stream to void.
>> On native Windows, the resource is instead named "nul".
>>
>> The error would look like this:
>> c:/arm-11.3.rel1/bin/../lib/gcc/arm-none-eabi/11.3.1/../../../../arm-none-eabi/bin/ld.exe: cannot find @/dev/null: No such file or directory
>>
>> Patch has been verified on Windows and Linux.
>>
>> gcc/testsuite:
>>
>> * gcc.misc-tests/outputs.exp: Use "@nul" for Windows,
>> "@/dev/null" for other environments.
>>
>> Co-Authored-By: Yvan ROUX <yvan.roux@foss.st.com>
>> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
>> ---
>> gcc/testsuite/gcc.misc-tests/outputs.exp | 17 ++++++++++++-----
>> 1 file changed, 12 insertions(+), 5 deletions(-)
>>
>> diff --git a/gcc/testsuite/gcc.misc-tests/outputs.exp
>> b/gcc/testsuite/gcc.misc-tests/outputs.exp
>> index ab919db1ccb..3fe7270fa63 100644
>> --- a/gcc/testsuite/gcc.misc-tests/outputs.exp
>> +++ b/gcc/testsuite/gcc.misc-tests/outputs.exp
>> @@ -78,6 +78,13 @@ if {[board_info $dest exists output_format]} {
>> append link_options " additional_flags=-Wl,-oformat,[board_info
>> $dest output_format]"
>> }
>> +
>> +set devnull "/dev/null"
>> +if { [info exists ::env(OS)] && [string match "Windows*" $::env(OS)] } {
>> + # Windows uses special file named "nul" as a substitute for
>> /dev/null
>> + set devnull "nul"
>> +}
>> +
>> # Avoid possible influence from the make jobserver,
>> # otherwise ltrans0.ltrans_args files may be missing.
>> if [info exists env(MAKEFLAGS)] {
>> @@ -353,10 +360,10 @@ outest "$b-21 exe savetmp named2" $mult "-o
>> $b.exe -save-temps" {} {{--1.i --1.s
>> # Additional files are created when an @file is used
>> if !$skip_atsave {
>> -outest "$b-22 exe savetmp namedb-2" $sing "@/dev/null -o $b.exe
>> -save-temps" {} {{--0.i --0.s --0.o .args.0 !!$gld .ld1_args !0 .exe}}
>> -outest "$b-23 exe savetmp named2-2" $mult "@/dev/null -o $b.exe
>> -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o .args.0 !!$gld
>> .ld1_args !0 .exe}}
>> -outest "$b-24 exe savetmp named2-3" $mult "@/dev/null -I dummy -o
>> $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o -args.0
>> -args.1 .args.2 !!$gld .ld1_args !0 .exe}}
>> -outest "$b-25 exe savetmp named2-4" $mult "@/dev/null -I dummy -L
>> dummy -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o
>> -args.0 -args.1 .args.2 .args.3 !!$gld .ld1_args !0 .exe}}
>> +outest "$b-22 exe savetmp namedb-2" $sing "@$devnull -o $b.exe
>> -save-temps" {} {{--0.i --0.s --0.o .args.0 !!$gld .ld1_args !0 .exe}}
>> +outest "$b-23 exe savetmp named2-2" $mult "@$devnull -o $b.exe
>> -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o .args.0 !!$gld
>> .ld1_args !0 .exe}}
>> +outest "$b-24 exe savetmp named2-3" $mult "@$devnull -I dummy -o
>> $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o -args.0
>> -args.1 .args.2 !!$gld .ld1_args !0 .exe}}
>> +outest "$b-25 exe savetmp named2-4" $mult "@$devnull -I dummy -L
>> dummy -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o
>> -args.0 -args.1 .args.2 .args.3 !!$gld .ld1_args !0 .exe}}
>> }
>> # Setting the main output to a dir selects it as the default aux&dump
>> @@ -714,7 +721,7 @@ outest "$b-291 lto mult named-2" $mult "-o $b.exe
>> -O2 -flto -fno-use-linker-plug
>> outest "$b-292 lto sing nameddir-2" $sing "-o dir/$b.exe -O2 -flto
>> -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized
>> -fdump-rtl-final -fstack-usage" {dir/} {{--0.c.???i.icf
>> --0.c.???r.final .wpa.???i.icf .ltrans0.ltrans.???r.final
>> .ltrans0.ltrans.su .exe} {}}
>> outest "$b-293 lto mult nameddir-2" $mult "-o dir/$b.exe -O2 -flto
>> -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized
>> -fdump-rtl-final -fstack-usage" {dir/} {{--1.c.???i.icf
>> --1.c.???r.final --2.c.???i.icf --2.c.???r.final .wpa.???i.icf
>> .ltrans0.ltrans.???r.final .ltrans0.ltrans.su .exe} {}}
>> if !$skip_atsave {
>> -outest "$b-294 lto sing unnamed-3" $sing "@/dev/null -O2 -flto
>> -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized
>> -fdump-rtl-final -fstack-usage -save-temps $oaout" {}
>> {{a--0.c.???i.icf a--0.c.???r.final a.wpa.???i.icf
>> a.ltrans0.ltrans.???r.final a.ltrans0.ltrans.su a--0.o a--0.s a--0.i
>> a.ltrans0.o a.ltrans.out a.ltrans0.ltrans.o a.ltrans0.ltrans_args
>> a.args.0 a.ltrans0.ltrans.s a.wpa.args.0 a.lto_args a.ld1_args
>> a.ltrans_args a.ltrans0.ltrans.args.0 a.ld_args $aout}}
>> +outest "$b-294 lto sing unnamed-3" $sing "@$devnull -O2 -flto
>> -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized
>> -fdump-rtl-final -fstack-usage -save-temps $oaout" {}
>> {{a--0.c.???i.icf a--0.c.???r.final a.wpa.???i.icf
>> a.ltrans0.ltrans.???r.final a.ltrans0.ltrans.su a--0.o a--0.s a--0.i
>> a.ltrans0.o a.ltrans.out a.ltrans0.ltrans.o a.ltrans0.ltrans_args
>> a.args.0 a.ltrans0.ltrans.s a.wpa.args.0 a.lto_args a.ld1_args
>> a.ltrans_args a.ltrans0.ltrans.args.0 a.ld_args $aout}}
>> }
>> }
>
> Thanks, looks good to me, will push to master soon.
>
Thanks for the review. I can push myself if that's easier for you.
Kind regards,
Torbjörn
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] testsuite: /dev/null is not accessible on Windows
2022-10-05 9:34 ` Jonathan Yong
2022-10-05 9:46 ` Torbjorn SVENSSON
@ 2022-10-05 9:48 ` Jonathan Yong
1 sibling, 0 replies; 5+ messages in thread
From: Jonathan Yong @ 2022-10-05 9:48 UTC (permalink / raw)
To: gcc-patches
On 10/5/22 09:34, Jonathan Yong wrote:
> On 9/29/22 17:38, Torbjörn SVENSSON via Gcc-patches wrote:
>> When running the DejaGNU testsuite on a toolchain built for native
>> Windows, the path /dev/null can't be used to open a stream to void.
>> On native Windows, the resource is instead named "nul".
>>
>> The error would look like this:
>> c:/arm-11.3.rel1/bin/../lib/gcc/arm-none-eabi/11.3.1/../../../../arm-none-eabi/bin/ld.exe: cannot find @/dev/null: No such file or directory
>>
>> Patch has been verified on Windows and Linux.
>
> Thanks, looks good to me, will push to master soon.
>
Pushed to master branch 5fe2e4f87e512407c5c560dfec2fe48ba099c807.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-10-05 9:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-29 17:38 [PATCH] testsuite: /dev/null is not accessible on Windows Torbjörn SVENSSON
2022-10-05 9:22 ` PING^1 " Torbjorn SVENSSON
2022-10-05 9:34 ` Jonathan Yong
2022-10-05 9:46 ` Torbjorn SVENSSON
2022-10-05 9:48 ` Jonathan Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).