From: Segher Boessenkool <segher@kernel.crashing.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jason Merrill <jason@redhat.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
richard.sandiford@arm.com,
Richard Earnshaw <richard.earnshaw@arm.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] i386, rs6000, ia64, s390: Fix C++ ICEs with _Float64x or _Float128 [PR107080]
Date: Fri, 30 Sep 2022 10:07:59 -0500 [thread overview]
Message-ID: <20220930150759.GH25951@gate.crashing.org> (raw)
In-Reply-To: <YzVtB20h3jGKmYg1@tucnak>
Hi!
On Thu, Sep 29, 2022 at 12:01:43PM +0200, Jakub Jelinek via Gcc-patches wrote:
> --- gcc/config/i386/i386.cc.jj 2022-09-29 09:13:25.713718513 +0200
> +++ gcc/config/i386/i386.cc 2022-09-29 11:29:20.828358152 +0200
> @@ -22725,6 +22725,9 @@ ix86_mangle_type (const_tree type)
> && TREE_CODE (type) != INTEGER_TYPE && TREE_CODE (type) != REAL_TYPE)
> return NULL;
>
> + if (type == float128_type_node || type == float64x_type_node)
> + return NULL;
Is float128_type_node always IEEE QP, never double-double? I couldn't
find this documented anywhere. If this is not true, this part of the
patch is incorrect.
Segher
next prev parent reply other threads:[~2022-09-30 15:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 10:01 Jakub Jelinek
2022-09-30 13:54 ` Jason Merrill
2022-09-30 17:13 ` [PATCH] arm, aarch64, csky: Fix C++ ICEs with _Float16 and __fp16 [PR107080] Jakub Jelinek
2022-09-30 17:38 ` Richard Sandiford
2022-09-30 17:49 ` Jakub Jelinek
2022-09-30 19:44 ` Jason Merrill
2022-09-30 15:07 ` Segher Boessenkool [this message]
2022-09-30 15:31 ` [PATCH] i386, rs6000, ia64, s390: Fix C++ ICEs with _Float64x or _Float128 [PR107080] Jakub Jelinek
2022-09-30 15:50 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220930150759.GH25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
--cc=richard.earnshaw@arm.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).