From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yann.morin.1998@free.fr>
Received: from smtp6-g21.free.fr (smtp6-g21.free.fr [IPv6:2a01:e0c:1:1599::15])
	by sourceware.org (Postfix) with ESMTPS id E94C13858C20
	for <gcc-patches@gcc.gnu.org>; Sat,  1 Oct 2022 17:53:39 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E94C13858C20
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=free.fr
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=free.fr
Received: from ymorin.is-a-geek.org (unknown [IPv6:2a01:cb19:8b51:cb00:9961:1217:61e8:73cc])
	(Authenticated sender: yann.morin.1998@free.fr)
	by smtp6-g21.free.fr (Postfix) with ESMTPSA id 8EE51780313;
	Sat,  1 Oct 2022 19:53:32 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr;
	s=smtp-20201208; t=1664646818;
	bh=XVqQEszfsaqpORn/XyfgPty0a3ejN+XQ6ormQgbYw08=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=XZwpmaYwSmsEUKI+YcW22Sg7KolY8rdVHBaxwjQE73/MNi3/zkVqGM17GVlnZmyeY
	 TCsIo9iNgkdaxdO2lgUXeZybtpPMVvDcah/y5Gqc4+3jHZz3jADw/SMqc5j9++2TVF
	 e/SZCPrO00hQ9gp1jgw1QPgceh0XcZWgs0URJKtSwiX0pdTaq//qiMqVdIaVsmdV4o
	 dO5TTi8QO2VqA736potj6JNiPjlda+rud5OEtOOVkjtFe04AhCU2FbL63anCfxb4j2
	 RiHdQMqBv4HjNpn9BuQ+TfhXkjN8+ltuCR7nnClq+/YIHkmSQ4EU8TNkTEgmkbtT5B
	 5MOJg3Xcnhjnw==
Received: by ymorin.is-a-geek.org (sSMTP sendmail emulation); Sat, 01 Oct 2022 19:53:32 +0200
Date: Sat, 1 Oct 2022 19:53:32 +0200
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Stafford Horne <shorne@gmail.com>
Cc: gcc-patches@gcc.gnu.org, openrisc@lists.librecores.org,
	Yann Morin <yann.morin@orange.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] or1k: Only define TARGET_HAVE_TLS when
 HAVE_AS_TLS
Message-ID: <20221001175332.GN30794@scaer>
References: <20220929145740.4846-1-shorne@gmail.com>
 <YzgmG9Ihqt6xC7CA@oscomms1>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <YzgmG9Ihqt6xC7CA@oscomms1>
User-Agent: Mutt/1.5.22 (2013-10-16)
X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,JMQ_SPF_NEUTRAL,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

Stafford, All,

On 2022-10-01 11:35 +0000, Stafford Horne spake thusly:
> On Thu, Sep 29, 2022 at 03:57:40PM +0100, Stafford Horne wrote:
> > This was found when testing buildroot with linuxthreads enabled.  In
> > this case, the build passes --disable-tls to the toolchain during
> > configuration.  After building the OpenRISC toolchain it was still
> > generating TLS code sequences and causing linker failures such as:
> > 
> >  ..../or1k-buildroot-linux-uclibc-gcc -o gpsd-3.24/gpsctl .... -lusb-1.0 -lm -lrt -lnsl
> >  ..../ld: ..../sysroot/usr/lib/libusb-1.0.so: undefined reference to `__tls_get_addr'
> > 
> > This patch fixes this by disabling tls for the OpenRISC target when requested
> > via --disable-tls.
> > 
> > Tested-by: Yann E. MORIN <yann.morin@orange.com>
> > 
> > gcc/ChangeLog:
> > 
> > 	* config/or1k/or1k.cc (TARGET_HAVE_TLS): Only define if
> > 	HAVE_AS_TLS is defined.
> 
> I have pushed this upstream now.  Adding buildroot patches should be easy to do
> now.

That's great, thanks for fixing this! :-)

I'll poke my work alter-ego on Monday to look at providing the backports
for Buildroot.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'