From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 5B5C63858D32 for ; Mon, 3 Oct 2022 07:04:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5B5C63858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x429.google.com with SMTP id bk15so15254298wrb.13 for ; Mon, 03 Oct 2022 00:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date; bh=vE4+ts4HHalwuQ8InqjZf/uT89+bLFmLIdtV8WJqi/E=; b=UU2nccpR2LpTw9wn3T+hOTIWt1SmKVOf+sVbTxmn+m7lTo5zB3YljiudEs6IpwEJNW FyoaEo3mwWsmkvRa3et99vQ3z9M2G8wZ9EX8oFIhlW1FT9LDIDro+42t52r8/Lwkt3XA oNr0Q4B1C5//kCKnKIk0IOk7B+MINR9NDCem/xM5j9X0p8lYHh83vJnKF/2NQRQYS5xQ jFtCfycRLYRdNm0RMcCIHqYw8c+AQsgfJGAqyexuTGc0UD9NQd8AKZcqR0g9I2LWIwGf K4ikIkK5Idy9uyaFNv6XkO0C359X2t2ahqVgap4xZKpn4gbbOc3oqv6F+9+Xg964tEwc IovQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=vE4+ts4HHalwuQ8InqjZf/uT89+bLFmLIdtV8WJqi/E=; b=MIwMHRkZioPC31rlX8VASBdMHjxQjWp4ppXHt3mJKFkRIwf1BRvaSZ+UsQOZfou4cB LxyaOYWpwfImk6bXTOKyjDRz5LP8z6rQN4fPeINBTnU4EqGFBmAeGL60Tftl9N2S913E jTVIMEAL97puvxsW44VAv+CPDwTTAVJP1rtrd1wfUs91eiM9WOCs8hDT98VBE0ezDVJr NPNKAbwWQbMIr+frj2J1IXicJi+da0LL9J0aK33F4x/yZQEZXndzosepHuSv2wBPkK4T JWzW3t926jteIuW4YfIkg2RpCJnOVmbn8stFevWDukPGILk0+exX8usB9yLCSYrMe5Ku JY1g== X-Gm-Message-State: ACrzQf1ehxxIxbLKJCyGzIFZkkjn+ufu8CBPjTeC4j0HeLEiZfle2WB9 Lc0Du1NjJBYOb3p+O6eiEHsiHReeh4w= X-Google-Smtp-Source: AMsMyM5vwZvVxOwcK0KwwM+WunxR809XQXPLjvgj/DRns/Cfl3va3S6O0W1AoFWDSAk4Ov4/lTNe/A== X-Received: by 2002:adf:d4cd:0:b0:22c:dc00:7f99 with SMTP id w13-20020adfd4cd000000b0022cdc007f99mr10700590wrk.260.1664780698005; Mon, 03 Oct 2022 00:04:58 -0700 (PDT) Received: from nz (host81-147-8-29.range81-147.btcentralplus.com. [81.147.8.29]) by smtp.gmail.com with ESMTPSA id w7-20020adfde87000000b0022afedf3c87sm8787788wrl.105.2022.10.03.00.04.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 00:04:57 -0700 (PDT) Date: Mon, 3 Oct 2022 08:04:56 +0100 From: Sergei Trofimovich To: GCC Patches Cc: Sergei Trofimovich Subject: PING [PATCH] gcc/config/t-i386: add build dependencies on i386-builtin-types.inc Message-ID: <20221003080456.258fa375@nz> In-Reply-To: References: <20220916184922.3274016-1-slyich@gmail.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 22 Sep 2022 22:07:52 +0100 Sergei Trofimovich wrote: > On Fri, 16 Sept 2022 at 19:49, Sergei Trofimovich wrote: > > > > From: Sergei Trofimovich > > > > i386-builtin-types.inc is included indirectly via i386-builtins.h > > into 4 files: i386.cc i386-builtins.cc i386-expand.cc i386-features.cc > > > > Only i386.cc dependency was present in gcc/config/t-i386 makefile. > > > > As a result parallel builds occasionally fail as: > > > > g++ ... -o i386-builtins.o ... ../../gcc-13-20220911/gcc/config/i386/i386-builtins.cc > > In file included from ../../gcc-13-20220911/gcc/config/i386/i386-builtins.cc:92: > > ../../gcc-13-20220911/gcc/config/i386/i386-builtins.h:25:10: > > fatal error: i386-builtin-types.inc: No such file or directory > > 25 | #include "i386-builtin-types.inc" > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > compilation terminated. > > make[3]: *** [../../gcc-13-20220911/gcc/config/i386/t-i386:54: i386-builtins.o] > > Error 1 shuffle=1663349189 > > > > gcc/ > > * config/i386/t-i386: Add build-time dependencies against > > i386-builtin-types.inc to i386-builtins.o, i386-expand.o, > > i386-features.o. > > --- > > gcc/config/i386/t-i386 | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/gcc/config/i386/t-i386 b/gcc/config/i386/t-i386 > > index 4e2a0efc615..ffdbbdfe8ce 100644 > > --- a/gcc/config/i386/t-i386 > > +++ b/gcc/config/i386/t-i386 > > @@ -62,7 +62,12 @@ i386-features.o: $(srcdir)/config/i386/i386-features.cc > > $(COMPILE) $< > > $(POSTCOMPILE) > > > > +# i386-builtin-types.inc is included into i386-builtins.h. > > +# Below are direct users of i386-builtins.h: > > i386.o: i386-builtin-types.inc > > +i386-builtins.o: i386-builtin-types.inc > > +i386-expand.o: i386-builtin-types.inc > > +i386-features.o: i386-builtin-types.inc > > > > i386-builtin-types.inc: s-i386-bt ; @true > > s-i386-bt: $(srcdir)/config/i386/i386-builtin-types.awk \ > > -- > > 2.37.2 > > > > Is it a reasonable approach? Maybe gcc has an equivalent of automake's > BUILT_SOURCES to avoid explicit tracking of such dependencies? > > -- > Sergei -- Sergei