From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8E7F03858D37 for ; Tue, 4 Oct 2022 17:52:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8E7F03858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664905956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fgHJZJQOCLZSQ1ctt6e/SIf+V78/+eUygIfLLtEW7xg=; b=IBN9V+mdGlqm/CEnuUtEcAcMP6WevlZOy5ffwydEXXciuGrgG/ZzKng/9lUscsrwrHlRlS IDskqX8/vNMkfs1FBArEe40hQyhBHuKQE/aoyzqMKHS9r6V4TLq2YRrpygU4v4vSMu70ge csYUSvONI2RPrgGekwjrVWaIjc/dUFU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-640-A9-0ZSDXPziF2UBU-kbkZQ-1; Tue, 04 Oct 2022 13:52:33 -0400 X-MC-Unique: A9-0ZSDXPziF2UBU-kbkZQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BB369185A7A9; Tue, 4 Oct 2022 17:52:32 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.192.109]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5A32A17583; Tue, 4 Oct 2022 17:52:32 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 294HqTrC1493520 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 4 Oct 2022 19:52:29 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 294HqSbC1493519; Tue, 4 Oct 2022 19:52:28 +0200 From: Aldy Hernandez To: GCC patches Cc: Jeff Law , Andrew MacLeod , Aldy Hernandez Subject: [COMMITTED] Remove assert from set_nonzero_bits. Date: Tue, 4 Oct 2022 19:52:21 +0200 Message-Id: <20221004175221.1493497-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The assert removed by this patch was there to keep users from passing masks of incompatible types. The self tests are passing host wide ints down (set_nonzero_bits (-1)), which seem to be 32 bits, whereas some embedded targets have integer_type_node's of 16-bits. This is causing problems in m32c-elf, among others. I suppose there's no harm in passing a 32-bit mask, because set_nonzero_bits calls wide_int::from() to convert the mask to the appropriate type. So we can remove the assert. Sorry for the pain Jeff. gcc/ChangeLog: * value-range.cc (irange::set_nonzero_bits): Remove assert. --- gcc/value-range.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/gcc/value-range.cc b/gcc/value-range.cc index afb26a40083..a307559b654 100644 --- a/gcc/value-range.cc +++ b/gcc/value-range.cc @@ -2913,7 +2913,6 @@ irange::set_nonzero_bits (const wide_int_ref &bits) { gcc_checking_assert (!undefined_p ()); unsigned prec = TYPE_PRECISION (type ()); - gcc_checking_assert (prec == bits.get_precision ()); // Drop VARYINGs with a nonzero mask to a plain range. if (m_kind == VR_VARYING && bits != -1) -- 2.37.1