From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 54F73385783E for ; Wed, 5 Oct 2022 14:10:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 54F73385783E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664979028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XeL27oqbTTvAzy3wJQ2tJiqXONF3f16wV1ACVZmL9yA=; b=aP4u8m59CFdVRy2NNZauJPbzB7DD3lErpkhAWJGPxfkMycEZ7S2oNrJ/U7TQQF7LwqGBNR ybieiD4igb+D1e3jj/+hGV/P/SaJGd67gOCP9N103Q2xWQWS/gBGjFO3Fow1ovR1gONxQc /7lT1cd0I+nnmfvS++SCYG2/b/wsLdo= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-494-8LSiqh7bN5Kp3ZWCwJAYOg-1; Wed, 05 Oct 2022 10:10:26 -0400 X-MC-Unique: 8LSiqh7bN5Kp3ZWCwJAYOg-1 Received: by mail-qv1-f72.google.com with SMTP id g12-20020a0cfdcc000000b004ad431ceee0so10374578qvs.7 for ; Wed, 05 Oct 2022 07:10:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date; bh=XeL27oqbTTvAzy3wJQ2tJiqXONF3f16wV1ACVZmL9yA=; b=LlScXbwPy3sxpVZwAwslJamvqZRjPrj6Nk4p/kjvR7yY6hCfLUtz8+I7NpC56j83nh qpLfgaP4xRm91xgoEaKqWH7YvU+qqoyOpEkiC2MKeaYR6/Pz8ktwhZSOnamVplfoCqOd U/Gc4OZDoXTilP5kH/PT6Da7DFeY3lKlqVGCVCfmyHUyFKzIfotQ/KscsopLn0ZwNjGz 79Xj/s2Y5yp+HEY4NDUzxf4ha4c9VEf7hYWCo5dd8PtU9h5CWNu6iQPtI5duYu5JuZS/ 9iHvrXNe4zXOs3gMHSefP2BEmlRZYbzyJSWoyDUc52C+jWwnusZS83GmsbvDFcmnANFj mOAg== X-Gm-Message-State: ACrzQf1ykPMYZw5Hm7nkbUSgBQqA+UfI49eE0CrCNWT21s/ml1nitNo3 wP3It5+w/A4ya2DcSMmlYyCUbz2exWGaXFMQHeeNKefLJmA6v3ixSnscFGThBCGOAjWIq5Y8oFO 1e8iUq8vguvFaa1DmLiyiXgm1M5OLS2EbeunqAnzroCl7y2aKvc4Qhl/U+XQQELJc5A== X-Received: by 2002:a05:6214:ace:b0:4b1:af67:e2cb with SMTP id g14-20020a0562140ace00b004b1af67e2cbmr6454775qvi.32.1664979026210; Wed, 05 Oct 2022 07:10:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7tRPK46FWaDZxZlwoQku7sWK74k47LPwbEhXk+bRmloHGC/zEeAgU9XnNAzDOvi7XlgB7dEA== X-Received: by 2002:a05:6214:ace:b0:4b1:af67:e2cb with SMTP id g14-20020a0562140ace00b004b1af67e2cbmr6454750qvi.32.1664979025868; Wed, 05 Oct 2022 07:10:25 -0700 (PDT) Received: from barrymore.redhat.com (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id o13-20020a05620a2a0d00b006ce51b541dfsm17625860qkp.36.2022.10.05.07.10.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Oct 2022 07:10:25 -0700 (PDT) From: Jason Merrill To: gcc-patches@gcc.gnu.org Subject: [pushed] c++: lvalue_kind tweak Date: Wed, 5 Oct 2022 10:10:23 -0400 Message-Id: <20221005141023.3206443-1-jason@redhat.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tested x86_64-pc-linux-gnu, applying to trunk. -- >8 -- I was wondering how lvalue_kind handles VIEW_CONVERT_EXPR; in cases where the type actually changes, it should have the same prvalue->xvalue effect as ARRAY_REF, since we need to materialize a temporary to get an object we can reinterpret as another type. Currently this only fires on builtin-shufflevector-3.c, where we use VIEW_CONVERT_EXPR to reinterpret a vector as an array. REALPART_EXPR and IMAGPART_EXPR should also be treated like COMPONENT_REF. PREINCREMENT_EXPR and PREDECREMENT_EXPR should only be applied to glvalues, but if for some reason they were applied to a prvalue this would be correct. TRY_CATCH_EXPR around a prvalue is also questionable, but this is the right handling. gcc/cp/ChangeLog: * tree.cc (lvalue_kind) [VIEW_CONVERT_EXPR]: Change prvalue to xvalue. --- gcc/cp/tree.cc | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/gcc/cp/tree.cc b/gcc/cp/tree.cc index aa9c1b7d8f9..6d968a2af11 100644 --- a/gcc/cp/tree.cc +++ b/gcc/cp/tree.cc @@ -104,7 +104,17 @@ lvalue_kind (const_tree ref) case REALPART_EXPR: case IMAGPART_EXPR: case VIEW_CONVERT_EXPR: - return lvalue_kind (TREE_OPERAND (ref, 0)); + op1_lvalue_kind = lvalue_kind (TREE_OPERAND (ref, 0)); + /* As for ARRAY_REF and COMPONENT_REF, these codes turn a class prvalue + into an xvalue: we need to materialize the temporary before we mess + with it. Except VIEW_CONVERT_EXPR that doesn't actually change the + type, as in location wrapper and REF_PARENTHESIZED_P. */ + if (op1_lvalue_kind == clk_class + && !(TREE_CODE (ref) == VIEW_CONVERT_EXPR + && (same_type_ignoring_top_level_qualifiers_p + (TREE_TYPE (ref), TREE_TYPE (TREE_OPERAND (ref, 0)))))) + return clk_rvalueref; + return op1_lvalue_kind; case ARRAY_REF: { base-commit: 7d935cdd1a6772699ec0ab4f93711928ca4d30a1 -- 2.31.1