From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0B0A5384D16B for ; Thu, 6 Oct 2022 06:23:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0B0A5384D16B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665037404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GJKC/KZksv4ZYut4S09O79X0iVRHjLsMyF+sVC/MSbs=; b=NHBaGS+HdyKBnyK8DStnbz+5NknQf5uxFpt1/Ao48M92h61F+xS3ONaqlcqrFe5J1XUk1V x6wy3lcEajyDQhQq9V1maq/UDbHy/cS3jP90wQPyNQSTuYxTV/hE9EEgYn2FCqlVs/lr2y lMzsYBWBW8/4UkpOy1w/isoozzjNI2o= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-221-wKo5_bibPCSmIRQMGK75Jw-1; Thu, 06 Oct 2022 02:23:23 -0400 X-MC-Unique: wKo5_bibPCSmIRQMGK75Jw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 07A96101CC6B for ; Thu, 6 Oct 2022 06:23:23 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.192.138]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A41E8492B05; Thu, 6 Oct 2022 06:23:22 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 2966NKoh1710022 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 6 Oct 2022 08:23:21 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 2966NKbR1710021; Thu, 6 Oct 2022 08:23:20 +0200 From: Aldy Hernandez To: GCC patches Cc: Andrew MacLeod , Aldy Hernandez Subject: [COMMITTED] Setting explicit NANs sets UNDEFINED for -ffinite-math-only. Date: Thu, 6 Oct 2022 08:23:18 +0200 Message-Id: <20221006062318.1709996-3-aldyh@redhat.com> In-Reply-To: <20221006062318.1709996-1-aldyh@redhat.com> References: <20221006062318.1709996-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: We recently agreed that setting a range of NAN should instead set UNDEFINED for -ffinite-math-only. This patch makes that change to frange::set_nan() directly. Also, calling frange::update_nan() will now be a nop for !HONOR_NANS. Doing this in the setters simplifies everywhere we set NANs, as it keeps us from introducing NANs by mistake. gcc/ChangeLog: * value-range.cc (frange::set): Call set_nan unconditionally. (range_tests_nan): Adjust tests. (range_tests_signed_zeros): Same. (range_tests_floats): Same. * value-range.h (frange::update_nan): Guard with HONOR_NANS. (frange::set_nan): Set undefined if !HONOR_NANS. --- gcc/value-range.cc | 59 ++++++++++++++++++++++----------------------- gcc/value-range.h | 60 +++++++++++++++++++++++++++++----------------- 2 files changed, 67 insertions(+), 52 deletions(-) diff --git a/gcc/value-range.cc b/gcc/value-range.cc index a307559b654..87239fafa77 100644 --- a/gcc/value-range.cc +++ b/gcc/value-range.cc @@ -304,13 +304,8 @@ frange::set (tree type, if (real_isnan (&min) || real_isnan (&max)) { gcc_checking_assert (real_identical (&min, &max)); - if (HONOR_NANS (type)) - { - bool sign = real_isneg (&min); - set_nan (type, sign); - } - else - set_undefined (); + bool sign = real_isneg (&min); + set_nan (type, sign); return; } @@ -3624,6 +3619,7 @@ range_tests_nan () { frange r0, r1; REAL_VALUE_TYPE q, r; + bool signbit; // Equal ranges but with differing NAN bits are not equal. if (HONOR_NANS (float_type_node)) @@ -3735,6 +3731,26 @@ range_tests_nan () r0.set_nan (float_type_node); r0.clear_nan (); ASSERT_TRUE (r0.undefined_p ()); + + // [10,20] NAN ^ [21,25] NAN = [NAN] + r0 = frange_float ("10", "20"); + r0.update_nan (); + r1 = frange_float ("21", "25"); + r1.update_nan (); + r0.intersect (r1); + ASSERT_TRUE (r0.known_isnan ()); + + // NAN U [5,6] should be [5,6] +-NAN. + r0.set_nan (float_type_node); + r1 = frange_float ("5", "6"); + r1.clear_nan (); + r0.union_ (r1); + real_from_string (&q, "5"); + real_from_string (&r, "6"); + ASSERT_TRUE (real_identical (&q, &r0.lower_bound ())); + ASSERT_TRUE (real_identical (&r, &r0.upper_bound ())); + ASSERT_TRUE (!r0.signbit_p (signbit)); + ASSERT_TRUE (r0.maybe_isnan ()); } static void @@ -3742,7 +3758,6 @@ range_tests_signed_zeros () { tree zero = build_zero_cst (float_type_node); tree neg_zero = fold_build1 (NEGATE_EXPR, float_type_node, zero); - REAL_VALUE_TYPE q, r; frange r0, r1; bool signbit; @@ -3788,18 +3803,6 @@ range_tests_signed_zeros () r0.intersect (r1); ASSERT_TRUE (r0.zero_p ()); - // NAN U [5,6] should be [5,6] NAN. - r0.set_nan (float_type_node); - r1 = frange_float ("5", "6"); - r1.clear_nan (); - r0.union_ (r1); - real_from_string (&q, "5"); - real_from_string (&r, "6"); - ASSERT_TRUE (real_identical (&q, &r0.lower_bound ())); - ASSERT_TRUE (real_identical (&r, &r0.upper_bound ())); - ASSERT_TRUE (!r0.signbit_p (signbit)); - ASSERT_TRUE (r0.maybe_isnan ()); - r0 = frange_float ("+0", "5"); r0.clear_nan (); ASSERT_TRUE (r0.signbit_p (signbit) && !signbit); @@ -3823,7 +3826,10 @@ range_tests_signed_zeros () r1 = frange_float ("0", "0"); r1.update_nan (); r0.intersect (r1); - ASSERT_TRUE (r0.known_isnan ()); + if (HONOR_NANS (float_type_node)) + ASSERT_TRUE (r0.known_isnan ()); + else + ASSERT_TRUE (r0.undefined_p ()); r0.set_nonnegative (float_type_node); ASSERT_TRUE (r0.signbit_p (signbit) && !signbit); @@ -3863,7 +3869,8 @@ range_tests_floats () { frange r0, r1; - range_tests_nan (); + if (HONOR_NANS (float_type_node)) + range_tests_nan (); range_tests_signbit (); if (HONOR_SIGNED_ZEROS (float_type_node)) @@ -3936,14 +3943,6 @@ range_tests_floats () r0.intersect (r1); ASSERT_EQ (r0, frange_float ("15", "20")); - // [10,20] NAN ^ [21,25] NAN = [NAN] - r0 = frange_float ("10", "20"); - r0.update_nan (); - r1 = frange_float ("21", "25"); - r1.update_nan (); - r0.intersect (r1); - ASSERT_TRUE (r0.known_isnan ()); - // [10,20] ^ [21,25] = [] r0 = frange_float ("10", "20"); r0.clear_nan (); diff --git a/gcc/value-range.h b/gcc/value-range.h index d1663620444..b06ca7477cd 100644 --- a/gcc/value-range.h +++ b/gcc/value-range.h @@ -1111,11 +1111,14 @@ inline void frange::update_nan () { gcc_checking_assert (!undefined_p ()); - m_pos_nan = true; - m_neg_nan = true; - normalize_kind (); - if (flag_checking) - verify_range (); + if (HONOR_NANS (m_type)) + { + m_pos_nan = true; + m_neg_nan = true; + normalize_kind (); + if (flag_checking) + verify_range (); + } } // Like above, but set the sign of the NAN. @@ -1124,11 +1127,14 @@ inline void frange::update_nan (bool sign) { gcc_checking_assert (!undefined_p ()); - m_pos_nan = !sign; - m_neg_nan = sign; - normalize_kind (); - if (flag_checking) - verify_range (); + if (HONOR_NANS (m_type)) + { + m_pos_nan = !sign; + m_neg_nan = sign; + normalize_kind (); + if (flag_checking) + verify_range (); + } } // Clear the NAN bit and adjust the range. @@ -1213,12 +1219,17 @@ frange_val_is_max (const REAL_VALUE_TYPE &r, const_tree type) inline void frange::set_nan (tree type) { - m_kind = VR_NAN; - m_type = type; - m_pos_nan = true; - m_neg_nan = true; - if (flag_checking) - verify_range (); + if (HONOR_NANS (type)) + { + m_kind = VR_NAN; + m_type = type; + m_pos_nan = true; + m_neg_nan = true; + if (flag_checking) + verify_range (); + } + else + set_undefined (); } // Build a NAN of type TYPE with SIGN. @@ -1226,12 +1237,17 @@ frange::set_nan (tree type) inline void frange::set_nan (tree type, bool sign) { - m_kind = VR_NAN; - m_type = type; - m_neg_nan = sign; - m_pos_nan = !sign; - if (flag_checking) - verify_range (); + if (HONOR_NANS (type)) + { + m_kind = VR_NAN; + m_type = type; + m_neg_nan = sign; + m_pos_nan = !sign; + if (flag_checking) + verify_range (); + } + else + set_undefined (); } // Return TRUE if range is known to be finite. -- 2.37.1