From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id 711BB3885C2B for ; Thu, 6 Oct 2022 09:29:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 711BB3885C2B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x432.google.com with SMTP id a3so1817908wrt.0 for ; Thu, 06 Oct 2022 02:29:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=R5DVyfEAB+GGqg/boZhRJfOgzojKgR9UtK26A5+bEwk=; b=YMhN16sSgna8tW0LtxjWv1ASpJdjLVNvzx8LCEvTQO9fi6M7yR2eaa6sy8cE1caNX4 bYGhkfGrvSoLwrIWie6uz9vdmEb6Vkzq494J4LdavzB4jmp3/1v9ArXBpZYY9YSjjk75 JFNARfN3zNvv2ljilha4rBd+ouYlsaupbne8VDMt9I/SNYYMmvLHUvhmS+zNKm20TMOc sdtk4fai7RnL43ito+inG2DzYcluxKyp1NAWGkFh/Mu4W1o0NXDaMhOrrSVqCCZPeDa3 O2VkiFRF4B8nNqIewSj1P4b9FuL4P5TZClXSD8NhGWHSrQmPKk9iYy55hY267OYasZ7K ItEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R5DVyfEAB+GGqg/boZhRJfOgzojKgR9UtK26A5+bEwk=; b=xzjjAQNqLx68LzuVwLB/CshJql8k5nc3IIAitjHM2vb2MBt4E1NSDFIyCMv9uzd87p NBcwnlWy9IigJ1x3/NR+Lyv0IcHkzB4KucMf5U5mafcT8Eg+BFsBYiq/QtZRdpHFrvFX +8EKzg5cBkMEicF7Zn4bfJbwzjO5xdCuwAXfCkkTeX2v9X/dEg8eobN/M5Y3R84rFpAq aTk4HYyKpRYJfxlh0zYzq6wV49qQ3xJrjEdti72YpHoyU14q/YoR1weCg0WcSTc9RiGA Qu2QBMGGHlVgZyxARTRTWC9fNRvXte7mC8VJCersNaYLcqDSVtx3bwx2groHtCDNuhsM jmIw== X-Gm-Message-State: ACrzQf1R/pPKi3y7u5csVrzmFYaiZN+g+u795cwdq2HRa5V1S61RAt0N Aze2Z8i7mPjRGH9wCWbc0uYX9FotVSmlCpMQ X-Google-Smtp-Source: AMsMyM7N2cFFqRPloOjElipnxkXv3li3HcGwIaBh2uX6zb6wCmSbm1HDC+b9gUyKAWwgD2udXmUlnw== X-Received: by 2002:a05:6000:178c:b0:22b:7f5:c724 with SMTP id e12-20020a056000178c00b0022b07f5c724mr2404125wrg.384.1665048595351; Thu, 06 Oct 2022 02:29:55 -0700 (PDT) Received: from poulhies-Precision-5550.lan (static-176-191-105-132.ftth.abo.bbox.fr. [176.191.105.132]) by smtp.gmail.com with ESMTPSA id f7-20020adfdb47000000b00228cbac7a25sm17255307wrj.64.2022.10.06.02.29.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 02:29:54 -0700 (PDT) From: =?UTF-8?q?Marc=20Poulhi=C3=A8s?= To: gcc-patches@gcc.gnu.org Cc: Piotr Trojanek Subject: [COMMITED] ada: Fix inserting of validity checks in lock-free protected subprograms Date: Thu, 6 Oct 2022 11:29:51 +0200 Message-Id: <20221006092951.261362-1-poulhies@adacore.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Piotr Trojanek Validity checks for statements in a lock-free implementation of protected subprogram were wrongly inserted in front of the original statements. This happened because the lock-free implementation was created as a shallow copy, where only the protected body statements were copied while its children still had the Parent pointing to the original statements. gcc/ada/ * exp_ch9.adb (Build_Lock_Free_Protected_Subprogram_Body): Replace shallow copy of protected statements with a deep copy. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/exp_ch9.adb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/ada/exp_ch9.adb b/gcc/ada/exp_ch9.adb index 8abff55110d..decf61782af 100644 --- a/gcc/ada/exp_ch9.adb +++ b/gcc/ada/exp_ch9.adb @@ -2797,7 +2797,7 @@ package body Exp_Ch9 is Expected_Comp : Entity_Id; Stmt : Node_Id; Stmts : List_Id := - New_Copy_List (Statements (Hand_Stmt_Seq)); + New_Copy_List_Tree (Statements (Hand_Stmt_Seq)); Typ_Size : Int; Unsigned : Entity_Id; -- 2.34.1