From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 2242638A908F for ; Thu, 6 Oct 2022 09:31:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2242638A908F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x429.google.com with SMTP id b4so1799334wrs.1 for ; Thu, 06 Oct 2022 02:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wYkJPcZW4al2pfLb/DPiS7mZZzSzZ9itP6GNb2myVyY=; b=JA+mHt90lGT8vhvzZhkReJtr7g8fJUKfY1YAQXIHAAx7PUTPL33AyclIl/3eHuk3wt WH510Sje2jlljchkk+0XVpiJfv8nzlzKpo3RxQVHgAnU8KepQRVQg+DiaFC4kyWMQe3t wrq3q6t/V3IIfm9JESvuW283zs7c9Tifeu5uHeMdhdfwsuQfcrPmBxRWxWYMq/+yByJV 8vjqk+HTxFLDf8iNx7FPGGYH0O4w9CV7qq62qxc0q9hCTAnYvLj1V6jWGL0sRdYX5DEf JhIgOAv64z1uP95z/7D2uVU288YKZk5ikAdIRDMr0H9nNlRnG5GXxg0e5gJHx0gjSQwK adIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wYkJPcZW4al2pfLb/DPiS7mZZzSzZ9itP6GNb2myVyY=; b=q6yg3Dx+apz3BHOzFWbhP0UHpWxCOie5br3rmG3fyq1+Jj8lVBcEnAc/t+oXGR0Vp/ TaULwoPBE/EdCOUNb8MiyAEvt7UsiGBW+uaYXcG/CHkoUhs/u3A3q16Tsso4pPwbNUfK 2pgFmerZOFd2Bqv00OpkCO70n/orTtoqMO93OMgHGhMQ1q6QiDJ3SjqXfR/j/z4Cbp/e BQqY3wmHp4VQ2ROghkCJAO8+/1dzdwrh/Rhv68ICATLlyizNlTHhk7zLdDcQC6z1VxlR mg5+QGGSVzO2GqDhUqzFaX/8XWUfW8PMp0aqzoGqL6F8gfPAVE6KtREUPIvYUrDDy4CO a2Ww== X-Gm-Message-State: ACrzQf3C/0kOuxmfK+zOJIqD21/WqSeE3oo+h3uMj+K5CH4LFuIWd2Cv ktYummOflKCLmwEIwdHqsb0cYm1zPnimf26Y X-Google-Smtp-Source: AMsMyM7mTO/9GWhERuvyjaifucihmc3Nk4Hf8rAolB7vGcpUh8jV/F96gp0dmj6vdbkXdlizbo8gRA== X-Received: by 2002:adf:f483:0:b0:22e:4acd:2163 with SMTP id l3-20020adff483000000b0022e4acd2163mr2343290wro.559.1665048698761; Thu, 06 Oct 2022 02:31:38 -0700 (PDT) Received: from poulhies-Precision-5550.lan (static-176-191-105-132.ftth.abo.bbox.fr. [176.191.105.132]) by smtp.gmail.com with ESMTPSA id h18-20020a05600c415200b003a541d893desm4356348wmm.38.2022.10.06.02.31.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 02:31:38 -0700 (PDT) From: =?UTF-8?q?Marc=20Poulhi=C3=A8s?= To: gcc-patches@gcc.gnu.org Cc: Piotr Trojanek Subject: [COMMITED] ada: Reject conditional goto in lock-free protected subprograms Date: Thu, 6 Oct 2022 11:31:27 +0200 Message-Id: <20221006093127.262068-1-poulhies@adacore.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Piotr Trojanek In lock-free protected subprograms we don't allow goto statements; likewise, we now reject conditional goto statements. This fix only affects semantic checking mode with switch -gnatc. In ordinary compilation we already rejected conditional goto after it was expanded into ordinary goto. gcc/ada/ * sem_ch9.adb (Allows_Lock_Free_Implementation): Reject conditional goto statements. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/sem_ch9.adb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/ada/sem_ch9.adb b/gcc/ada/sem_ch9.adb index 6506358a02b..f2a59017865 100644 --- a/gcc/ada/sem_ch9.adb +++ b/gcc/ada/sem_ch9.adb @@ -453,7 +453,7 @@ package body Sem_Ch9 is -- Goto statements restricted - elsif Kind = N_Goto_Statement then + elsif Kind in N_Goto_Statement | N_Goto_When_Statement then if Lock_Free_Given then Error_Msg_N ("goto statement not allowed", N); return Skip; -- 2.34.1