public inbox for
 help / color / mirror / Atom feed
From: Samuel Thibault <>
To: Jonathan Wakely <>
Subject: Re: [PATCH] libstdc++: Introduce GNU/Hurd-specific libstdc++ os-defines.h
Date: Fri, 7 Oct 2022 22:43:46 +0200	[thread overview]
Message-ID: <20221007204346.vc4w5zroxqd5zwkg@begin> (raw)
In-Reply-To: <Y0AKEvpETLp9vSg/>


Jonathan Wakely, le ven. 07 oct. 2022 12:14:26 +0100, a ecrit:
> As documented at all patches for
> libstdc++ need to be CC'd to the libstdc++ list. That's why your patch
> has not been reviewed, because I didn't see it.

Ah, sorry, I hadn't noticed that.

> On 29/08/22 02:30 +0200, Samuel Thibault wrote:
> > This is notably needed because in glibc 2.34, the move of pthread functions
> > into happened for Linux only, not GNU/Hurd.
> > 
> > The pthread_self() function can also always be used fine as it is.
> > 
> > libstdc++-v3/ChangeLog:
> > 
> >        * config/os/gnu/os_defines.h: New file.
> >        * config/os/gnu/ctype_base.h: New file.
> >        * config/os/gnu/ New file.
> >        * config/os/gnu/ctype_inline.h: New file.
> >        * On gnu* host, use os/gnu instead of os/gnu-linux.
> I think the commit message should note that these files are all copied
> from the existing gnu-linux ones, so that the git log records that and
> people don't need to compare them manually.
> But if these files are all identical to the existing gnu-linux ones,
> except for a couple of macros in os_defines.h being conditional on
> Linux, why not just test __linux__ in os_defines.h?

Ah, it's just that I hadn't seen that done for other OSes, even when
they are very similar (e.g. between gnu-linux and uclibc).

If #ifdef is fine there, then yes I'm all for it indeed. I'll send a v2.


  reply	other threads:[~2022-10-07 20:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-29  0:30 Samuel Thibault
2022-09-17 21:55 ` Samuel Thibault
2022-10-07 11:14 ` Jonathan Wakely
2022-10-07 20:43   ` Samuel Thibault [this message]
2022-10-23  9:34 ` [PATCH]: Fix static-pie on Hurd target Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221007204346.vc4w5zroxqd5zwkg@begin \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).