From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 14C0038515E4 for ; Wed, 12 Oct 2022 11:52:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 14C0038515E4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665575574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mMCjxVsV/Bk2+om0uwFwjSzMHTn+bn7mxGfOJnStLNU=; b=RKubiVLPEs1L+nhdI+6T3+GAsAQi5uPArpyD6cBi/yevt0YBUze/AJG5ngy38gGxAVkJUN Pua0X13PV5GoQBdcmFNyvDd986vBdgAaBobhd2KwQUxGYaDYdnXqOG0V4WPtnllblVIxN8 mnkpywYi0sklvE7NdZdpx/GaskL+l58= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-39-G9r9mfizPFiEt1thWurGYw-1; Wed, 12 Oct 2022 07:52:53 -0400 X-MC-Unique: G9r9mfizPFiEt1thWurGYw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2504329AB3EC for ; Wed, 12 Oct 2022 11:52:53 +0000 (UTC) Received: from localhost (unknown [10.33.36.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id E3919200A4E7 for ; Wed, 12 Oct 2022 11:52:52 +0000 (UTC) From: Jonathan Wakely To: gcc-patches@gcc.gnu.org Subject: [PATCH] libgcc: Quote variable in Makefile.in Date: Wed, 12 Oct 2022 12:52:52 +0100 Message-Id: <20221012115252.1881060-1-jwakely@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This isn't very important as the error is harmless, but it's easy to fix and so is one less thing that might confuse people when looking at build logs. OK for trunk? -- >8 -- If the xgcc executable has not been built (or has been removed by 'make clean') then the command to print the multilib dir fails, and so the MULTIOSDIR variable is empty. That then causes: /bin/sh: line 0: test: !=: unary operator expected We can avoid it by quoting the variable. libgcc/ChangeLog: * Makefile.in: Quote variable. --- libgcc/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libgcc/Makefile.in b/libgcc/Makefile.in index 1fe708a93f7..6e2a0470944 100644 --- a/libgcc/Makefile.in +++ b/libgcc/Makefile.in @@ -310,7 +310,7 @@ CRTSTUFF_T_CFLAGS = MULTIDIR := $(shell $(CC) $(CFLAGS) -print-multi-directory) MULTIOSDIR := $(shell $(CC) $(CFLAGS) -print-multi-os-directory) -MULTIOSSUBDIR := $(shell if test $(MULTIOSDIR) != .; then echo /$(MULTIOSDIR); fi) +MULTIOSSUBDIR := $(shell if test "$(MULTIOSDIR)" != .; then echo /$(MULTIOSDIR); fi) inst_libdir = $(libsubdir)$(MULTISUBDIR) inst_slibdir = $(slibdir)$(MULTIOSSUBDIR) -- 2.37.3