From: Liwei Xu <liwei.xu@intel.com>
To: gcc-patches@gcc.gnu.org
Cc: richard.guenther@gmail.com, wilson@tuliptree.org,
admin@levyhsu.com, hongtao.liu@intel.com
Subject: [PATCH] Optimize identical permutation in my last r13-3212-gb88adba751da63
Date: Thu, 13 Oct 2022 11:15:18 +0800 [thread overview]
Message-ID: <20221013031518.66289-1-liwei.xu@intel.com> (raw)
Add extra index check when merging VEC_CST, this handles the case when exactly op1 needs to be return.
This fixes:
FAIL: gcc.dg/tree-ssa/forwprop-19.c scan-tree-dump-not forwprop1 "VEC_PERM_EXPR"
gcc/ChangeLog:
PR target/107220
* match.pd: Check the index of VEC_CST and return the op1 if needed.
---
gcc/match.pd | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/gcc/match.pd b/gcc/match.pd
index 3550c16aaa6..1efdc3abb5d 100644
--- a/gcc/match.pd
+++ b/gcc/match.pd
@@ -8106,6 +8106,7 @@ and,
vec_perm_builder builder0;
vec_perm_builder builder1;
vec_perm_builder builder2 (nelts, nelts, 1);
+ bool ident_to_1 = true;
if (!tree_to_vec_perm_builder (&builder0, @3)
|| !tree_to_vec_perm_builder (&builder1, @4))
@@ -8115,7 +8116,15 @@ and,
vec_perm_indices sel1 (builder1, 1, nelts);
for (int i = 0; i < nelts; i++)
- builder2.quick_push (sel0[sel1[i].to_constant ()]);
+ {
+ int tmp_index = sel0[sel1[i].to_constant ()].to_constant ();
+ builder2.quick_push (sel0[sel1[i].to_constant ()]);
+ if ( i != tmp_index)
+ ident_to_1 = false;
+ }
+
+ if (ident_to_1)
+ return @1;
vec_perm_indices sel2 (builder2, 2, nelts);
--
2.18.2
next reply other threads:[~2022-10-13 3:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 3:15 Liwei Xu [this message]
2022-10-13 10:41 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221013031518.66289-1-liwei.xu@intel.com \
--to=liwei.xu@intel.com \
--cc=admin@levyhsu.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hongtao.liu@intel.com \
--cc=richard.guenther@gmail.com \
--cc=wilson@tuliptree.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).