From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 475A63858C56 for ; Thu, 13 Oct 2022 20:13:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 475A63858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665692027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=x0vuePBa72jdlo9kf6P6gW8aV+FWKoXXJ5+ZI2iTRT8=; b=DkBLAtzWXCd5xa4jUrrH/rlRtO2tEUXRNuCM+dH02D4YXjDVOP1nd5qM9dXlSXazmV95m9 OxUYn4JW9BZS02kdc9TZrxLz1FUvPwacc+jlbmcyv/fqkDV3fMwsn0ARR/kIT4pv3gPIyO UbeYj3YZmxWTG93hVuMqkrp3aNZTTSE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-297-76LnPYe-M6eo3RRiQlA7AA-1; Thu, 13 Oct 2022 16:13:46 -0400 X-MC-Unique: 76LnPYe-M6eo3RRiQlA7AA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9145E88B7A7 for ; Thu, 13 Oct 2022 20:13:40 +0000 (UTC) Received: from t14s.localdomain.com (unknown [10.2.17.92]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC472208DDB6; Thu, 13 Oct 2022 20:13:33 +0000 (UTC) From: David Malcolm To: gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [committed] analyzer: fix ICE introduced in r13-3168 [PR107210] Date: Thu, 13 Oct 2022 16:13:32 -0400 Message-Id: <20221013201332.1157829-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r13-3285-g99da523359e933. gcc/analyzer/ChangeLog: PR analyzer/107210 * svalue.cc (constant_svalue::maybe_fold_bits_within): Only attempt to extract individual bits when tree_fits_uhwi_p. gcc/testsuite/ChangeLog: PR analyzer/107210 * gfortran.dg/analyzer/pr107210.f90: New test. Signed-off-by: David Malcolm --- gcc/analyzer/svalue.cc | 3 ++- gcc/testsuite/gfortran.dg/analyzer/pr107210.f90 | 16 ++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gfortran.dg/analyzer/pr107210.f90 diff --git a/gcc/analyzer/svalue.cc b/gcc/analyzer/svalue.cc index a0838c0f588..4b00a81b31d 100644 --- a/gcc/analyzer/svalue.cc +++ b/gcc/analyzer/svalue.cc @@ -884,7 +884,8 @@ constant_svalue::maybe_fold_bits_within (tree type, if (bits.m_size_in_bits == 1 && TREE_CODE (m_cst_expr) == INTEGER_CST && type - && INTEGRAL_TYPE_P (type)) + && INTEGRAL_TYPE_P (type) + && tree_fits_uhwi_p (m_cst_expr)) { unsigned HOST_WIDE_INT bit = bits.m_start_bit_offset.to_uhwi (); unsigned HOST_WIDE_INT mask = (1 << bit); diff --git a/gcc/testsuite/gfortran.dg/analyzer/pr107210.f90 b/gcc/testsuite/gfortran.dg/analyzer/pr107210.f90 new file mode 100644 index 00000000000..6132db48817 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/analyzer/pr107210.f90 @@ -0,0 +1,16 @@ +! { dg-additional-options "-O1" } + +subroutine check_int (j) + INTEGER(4) :: i, ia(5), ib(5,4), ip, ipa(:) + target :: ib + POINTER :: ip, ipa + logical :: l(5) + + ipa=>ib(2:3,1) + + l = (/ sizeof(i) == 4, sizeof(ia) == 20, sizeof(ib) == 80, & + sizeof(ip) == 4, sizeof(ipa) == 8 /) + + if (any(.not.l)) STOP 4 + +end subroutine check_int -- 2.26.3