From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 8FB953858D32 for ; Mon, 17 Oct 2022 15:33:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8FB953858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 29HFWgJh029297; Mon, 17 Oct 2022 10:32:42 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 29HFWfkv029294; Mon, 17 Oct 2022 10:32:41 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Mon, 17 Oct 2022 10:32:41 -0500 From: Segher Boessenkool To: will schmidt Cc: GCC patches , David Edelsohn , "Kewen.Lin" , Michael Meissner Subject: Re: [PATCH, rs6000] Tests of ARCH_PWR8 and -mno-vsx option. (1/2) Message-ID: <20221017153241.GI25951@gate.crashing.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! Everything Ke Wen said. Some more commments / hints: On Mon, Sep 19, 2022 at 11:05:17AM -0500, will schmidt wrote: > --- /dev/null > +++ b/gcc/testsuite/gcc.target/powerpc/predefine_p7-novsx.c > @@ -0,0 +1,9 @@ > +/* { dg-do preprocess } */ > +/* Test whether the ARCH_PWR7 and ARCH_PWR8 defines gets set > + * when we specify power7, plus options. > +/* This is a variation of the test at issue in GCC PR 101865 */ Please don't start comment lines with stars. And don't start a comment inside of another comment :-) > +/* { dg-options "-dM -E -mdejagnu-cpu=power7 -mno-vsx" } */ > +/* { dg-final { scan-file predefine_p7-novsx.i "(^|\\n)#define _ARCH_PWR7 1($|\\n)" } } */ REs are easier to read and write if you write them inside {} instead of inside "". Whenever you see (^|\n) it should hint you to use newline-sensitive matching? Like {(?n)^#define _ARCH_PWR7 1$} (it makes ^ and $ match the begin/end of lines instead of of the string, and makes . and similar not match newlines). > --- /dev/null > +++ b/gcc/testsuite/gcc.target/powerpc/predefine_p9-novsx.c > @@ -0,0 +1,10 @@ > +/* { dg-do preprocess } */ > +/* Test whether the ARCH_PWR8 define remains set after disabling vsx. > + This also confirms __ALTIVEC__ remains set when VSX is disabled. */ > +/* This is the primary test at issue in GCC PR 101865 */ > +/* { dg-options "-dM -E -mdejagnu-cpu=power9 -mno-vsx" } */ > +/* {xfail *-*-*} */ An xfail always needs a comment :-) Segher