From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8088A384D1AF for ; Thu, 20 Oct 2022 16:46:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8088A384D1AF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666284415; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=26OuE8u4JBKlxHWbIAuRtWXpZedzXhoI8/SkupO/XoM=; b=dOKm09HR2MSCaVskMYQPjoBvUmxJstQcgATHB8Yzl+jCNiKuvzCW+wCV2g1mylx/6Yyny+ b9FGk5ue3Uh/3pSBdWc74lyJtZmVhR9m20k/e0khMnElgTAfW8adY2PgPDZgeKerJfo08a phUI5DzUecDnfBdRKwAHi17imsKZXPI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-328-u8fPASf7M_iWb3O2mb1MuA-1; Thu, 20 Oct 2022 12:46:53 -0400 X-MC-Unique: u8fPASf7M_iWb3O2mb1MuA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 513A4823F74 for ; Thu, 20 Oct 2022 16:46:48 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.192.87]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 348A24047AD; Thu, 20 Oct 2022 16:46:44 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 29KGkav8256451 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 20 Oct 2022 18:46:37 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 29KGkasg256450; Thu, 20 Oct 2022 18:46:36 +0200 From: Aldy Hernandez To: GCC patches Cc: Andrew MacLeod , Aldy Hernandez Subject: [COMMITTED] A false UNORDERED_ means neither operand can be a NAN. Date: Thu, 20 Oct 2022 18:46:33 +0200 Message-Id: <20221020164633.256422-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The false side of UNORDERED_ means neither operand can be a NAN. Adjust all the op[12]_range entries for the UNORDERED operators such that a known NAN on one operands means the other operands is undefined. gcc/ChangeLog: * range-op-float.cc (foperator_unordered_le::op1_range): Adjust false side with a NAN operand. (foperator_unordered_le::op2_range): Same. (foperator_unordered_gt::op1_range): Same. (foperator_unordered_gt::op2_range): Same. (foperator_unordered_ge::op1_range): Same. (foperator_unordered_ge::op2_range): Same. (foperator_unordered_equal::op1_range): Same. --- gcc/range-op-float.cc | 51 ++++++++++++++++++++++++++++++++++--------- 1 file changed, 41 insertions(+), 10 deletions(-) diff --git a/gcc/range-op-float.cc b/gcc/range-op-float.cc index a9e74c86877..0cb07c2ec29 100644 --- a/gcc/range-op-float.cc +++ b/gcc/range-op-float.cc @@ -1351,7 +1351,11 @@ foperator_unordered_le::op1_range (frange &r, tree type, break; case BRS_FALSE: - if (build_gt (r, type, op2)) + // A false UNORDERED_LE means both operands are !NAN, so it's + // impossible for op2 to be a NAN. + if (op2.known_isnan ()) + r.set_undefined (); + else if (build_gt (r, type, op2)) r.clear_nan (); break; @@ -1375,7 +1379,11 @@ foperator_unordered_le::op2_range (frange &r, break; case BRS_FALSE: - if (build_lt (r, type, op1)) + // A false UNORDERED_LE means both operands are !NAN, so it's + // impossible for op1 to be a NAN. + if (op1.known_isnan ()) + r.set_undefined (); + else if (build_lt (r, type, op1)) r.clear_nan (); break; @@ -1434,7 +1442,11 @@ foperator_unordered_gt::op1_range (frange &r, break; case BRS_FALSE: - if (build_le (r, type, op2)) + // A false UNORDERED_GT means both operands are !NAN, so it's + // impossible for op2 to be a NAN. + if (op2.known_isnan ()) + r.set_undefined (); + else if (build_le (r, type, op2)) r.clear_nan (); break; @@ -1458,7 +1470,11 @@ foperator_unordered_gt::op2_range (frange &r, break; case BRS_FALSE: - if (build_ge (r, type, op1)) + // A false UNORDERED_GT means both operands are !NAN, so it's + // impossible for op1 to be a NAN. + if (op1.known_isnan ()) + r.set_undefined (); + else if (build_ge (r, type, op1)) r.clear_nan (); break; @@ -1517,7 +1533,11 @@ foperator_unordered_ge::op1_range (frange &r, break; case BRS_FALSE: - if (build_lt (r, type, op2)) + // A false UNORDERED_GE means both operands are !NAN, so it's + // impossible for op2 to be a NAN. + if (op2.known_isnan ()) + r.set_undefined (); + else if (build_lt (r, type, op2)) r.clear_nan (); break; @@ -1540,7 +1560,11 @@ foperator_unordered_ge::op2_range (frange &r, tree type, break; case BRS_FALSE: - if (build_gt (r, type, op1)) + // A false UNORDERED_GE means both operands are !NAN, so it's + // impossible for op1 to be a NAN. + if (op1.known_isnan ()) + r.set_undefined (); + else if (build_gt (r, type, op1)) r.clear_nan (); break; @@ -1606,10 +1630,17 @@ foperator_unordered_equal::op1_range (frange &r, tree type, break; case BRS_FALSE: - // The false side indictates !NAN and not equal. We can at least - // represent !NAN. - r.set_varying (type); - r.clear_nan (); + // A false UNORDERED_EQ means both operands are !NAN, so it's + // impossible for op2 to be a NAN. + if (op2.known_isnan ()) + r.set_undefined (); + else + { + // The false side indictates !NAN and not equal. We can at least + // represent !NAN. + r.set_varying (type); + r.clear_nan (); + } break; default: -- 2.37.3