From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 087E7384D17B for ; Thu, 20 Oct 2022 19:42:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 087E7384D17B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666294961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zBK56ajLvLMhvlg+MFOL738ZL9V3AsgImEdSlIL7KlY=; b=YhLfCmT6Hi9QXEqRZICMfhCctBKdjvTXkV2vJ9cBFfbMx1B4kUC1aFbJ7LQ8QstMD6wOsx 2LN+tPDwkAzBhv1dy/IiOg0NBnKSCLG6x5prc5caYZ/F+n/EkYID7RoFFLFem1XHt9dnv0 D1OyttjNpKoCxlSVxvq4W2SWjj3HVBU= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-213-Qc00lszZObq6p0DWzCzfWQ-1; Thu, 20 Oct 2022 15:42:35 -0400 X-MC-Unique: Qc00lszZObq6p0DWzCzfWQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1B6E31C05ACD for ; Thu, 20 Oct 2022 19:42:31 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.192.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B86DE49BB63; Thu, 20 Oct 2022 19:42:30 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 29KJgPTc259910 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 20 Oct 2022 21:42:25 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 29KJgPYk259909; Thu, 20 Oct 2022 21:42:25 +0200 From: Aldy Hernandez To: GCC patches Cc: Andrew MacLeod , Aldy Hernandez Subject: [COMMITTED] Add op[12]_range for UNORDERED_LT entries in range-op. Date: Thu, 20 Oct 2022 21:42:22 +0200 Message-Id: <20221020194222.259811-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: In auditing the UNORDERED range-op code I noticed the UNLT_EXPR entry was missing op1_range and op2_range operators. That is, we were missing the ability to unwind back through an UNLT_EXPR. gcc/ChangeLog: * range-op-float.cc (foperator_unordered_lt::op1_range): New. (foperator_unordered_lt::op2_range): New. --- gcc/range-op-float.cc | 64 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 64 insertions(+) diff --git a/gcc/range-op-float.cc b/gcc/range-op-float.cc index 0cb07c2ec29..8777bc70d71 100644 --- a/gcc/range-op-float.cc +++ b/gcc/range-op-float.cc @@ -1280,6 +1280,8 @@ foperator_abs::op1_range (frange &r, tree type, class foperator_unordered_lt : public range_operator_float { using range_operator_float::fold_range; + using range_operator_float::op1_range; + using range_operator_float::op2_range; public: bool fold_range (irange &r, tree type, const frange &op1, const frange &op2, @@ -1302,8 +1304,70 @@ public: return true; } } + bool op1_range (frange &r, tree type, + const irange &lhs, + const frange &op2, + relation_trio trio) const final override; + bool op2_range (frange &r, tree type, + const irange &lhs, + const frange &op1, + relation_trio trio) const final override; } fop_unordered_lt; +bool +foperator_unordered_lt::op1_range (frange &r, tree type, + const irange &lhs, + const frange &op2, + relation_trio) const +{ + switch (get_bool_state (r, lhs, type)) + { + case BRS_TRUE: + build_lt (r, type, op2); + break; + + case BRS_FALSE: + // A false UNORDERED_LT means both operands are !NAN, so it's + // impossible for op2 to be a NAN. + if (op2.known_isnan ()) + r.set_undefined (); + else if (build_ge (r, type, op2)) + r.clear_nan (); + break; + + default: + break; + } + return true; +} + +bool +foperator_unordered_lt::op2_range (frange &r, tree type, + const irange &lhs, + const frange &op1, + relation_trio) const +{ + switch (get_bool_state (r, lhs, type)) + { + case BRS_TRUE: + build_gt (r, type, op1); + break; + + case BRS_FALSE: + // A false UNORDERED_LT means both operands are !NAN, so it's + // impossible for op1 to be a NAN. + if (op1.known_isnan ()) + r.set_undefined (); + else if (build_le (r, type, op1)) + r.clear_nan (); + break; + + default: + break; + } + return true; +} + class foperator_unordered_le : public range_operator_float { using range_operator_float::fold_range; -- 2.37.3