From: Segher Boessenkool <segher@kernel.crashing.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Aldy Hernandez <aldyh@redhat.com>, GCC patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Rename nonzero_bits to known_zero_bits.
Date: Fri, 21 Oct 2022 12:44:27 -0500 [thread overview]
Message-ID: <20221021174427.GX25951@gate.crashing.org> (raw)
In-Reply-To: <Y1LOBd5mLy+7CQ4+@tucnak>
On Fri, Oct 21, 2022 at 06:51:17PM +0200, Jakub Jelinek wrote:
> On Fri, Oct 21, 2022 at 11:45:33AM -0500, Segher Boessenkool wrote:
> > On Fri, Oct 21, 2022 at 03:14:26PM +0200, Aldy Hernandez via Gcc-patches wrote:
> > > * asan.cc (handle_builtin_alloca): Rename *nonzero* to *known_zero*.
> >
> > Our "nonzero" means "not known to be zero", not "known to be zero", so
> > this renaming makes it worse than it was. Rename it to
>
> Agreed.
>
> I think maybe_nonzero_bits would be fine.
Yes, but the shorter nam known_zero is much better. Converting to that
is a bit more work, cannot really be mechanic: code simplifications are
needed to make things better instead of adding another layer of double
negations, and variable names and comments should be changes as well.
> Anyway, the reason it is called this way is that we have similar APIs
> on the RTL side, nonzero_bits* in rtlanal.cc.
I am well aware ;-)
> So if we rename, it should be renamed consistently.
Yes.
Segher
next prev parent reply other threads:[~2022-10-21 17:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 13:14 Aldy Hernandez
2022-10-21 16:45 ` Segher Boessenkool
2022-10-21 16:51 ` Jakub Jelinek
2022-10-21 16:54 ` Jakub Jelinek
2022-10-21 18:00 ` Segher Boessenkool
2022-11-01 16:33 ` Aldy Hernandez
2022-10-21 17:44 ` Segher Boessenkool [this message]
2022-10-24 7:21 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221021174427.GX25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).