From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lug-owl.de (lug-owl.de [IPv6:2a03:4000:10:469::]) by sourceware.org (Postfix) with ESMTPS id 47BC03857803 for ; Tue, 25 Oct 2022 20:09:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 47BC03857803 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lug-owl.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lug-owl.de Received: by lug-owl.de (Postfix, from userid 1001) id C9AE742032; Tue, 25 Oct 2022 22:09:57 +0200 (CEST) Date: Tue, 25 Oct 2022 22:09:57 +0200 From: Jan-Benedict Glaw To: Takayuki 'January June' Suwa Cc: GCC Patches Subject: Re: [PATCH v3] xtensa: Prepare the transition from Reload to LRA Message-ID: <20221025200957.v5yjre2fsbxqby43@lug-owl.de> References: <7e3fe210-6dbc-fc29-dbb8-b951e89cf7e9@yahoo.co.jp> <87f124f0-8a10-6c3b-6b12-cabf855e2e4b@yahoo.co.jp> <3296b387-083a-40cf-1bb5-40269e804f52@yahoo.co.jp> <3054719f-6688-211c-da07-93c0fbf7c038@yahoo.co.jp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="r5ed5mjdauqt6pcd" Content-Disposition: inline In-Reply-To: <3054719f-6688-211c-da07-93c0fbf7c038@yahoo.co.jp> X-Operating-System: Linux chamaeleon 5.14.0-0.bpo.2-amd64 X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444 A961 1DBD 5E75 8399 E1BB X-gpg-key: wwwkeys.de.pgp.net X-Echelon-Enable: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-TKUeV: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-message-flag: Please send plain text messages only. Do not send HTML emails. Thank you. User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --r5ed5mjdauqt6pcd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! On Wed, 2022-10-19 17:16:24 +0900, Takayuki 'January June' Suwa via Gcc-pat= ches wrote: > * gcc/config/xtensa/xtensa.md: Add two new split patterns: > - splits DImode immediate load into two SImode ones > - puts out-of-constraint SImode constants into the constant pool > --- a/gcc/config/xtensa/xtensa.md > +++ b/gcc/config/xtensa/xtensa.md > @@ -940,14 +940,9 @@ > because of offering further optimization opportunities. */ > if (register_operand (operands[0], DImode)) > { > - rtx lowpart, highpart; > - > - if (TARGET_BIG_ENDIAN) > - split_double (operands[1], &highpart, &lowpart); > - else > - split_double (operands[1], &lowpart, &highpart); > - emit_insn (gen_movsi (gen_lowpart (SImode, operands[0]), lowpart)); > - emit_insn (gen_movsi (gen_highpart (SImode, operands[0]), highpart)); > + xtensa_split_DI_reg_imm (operands); > + emit_move_insn (operands[0], operands[1]); > + emit_move_insn (operands[2], operands[3]); This results in a new warning for me: [all 2022-10-25 16:04:19] g++ -fno-PIE -c -g -O2 -DIN_GCC -DCROSS_DIR= ECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -= W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribu= te -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-= overlength-strings -Werror -fno-common -DHAVE_CONFIG_H -I. -I. -I../../gcc= /gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp= /include -I../../gcc/gcc/../libcody -I../../gcc/gcc/../libdecnumber -I../.= =2E/gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc/gcc/../libbac= ktrace -o insn-emit.o -MT insn-emit.o -MMD -MP -MF ./.deps/insn-emit.TPo = insn-emit.cc [all 2022-10-25 16:04:22] ../../gcc/gcc/config/xtensa/xtensa.md: In functio= n 'rtx_def* gen_movdi(rtx, rtx)': [all 2022-10-25 16:04:22] ../../gcc/gcc/config/xtensa/xtensa.md:945:26: err= or: array subscript 3 is above array bounds of 'rtx_def* [2]' [-Werror=3Dar= ray-bounds] [all 2022-10-25 16:04:22] 945 | emit_move_insn (operands[2], op= erands[3]); [all 2022-10-25 16:04:22] | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~= ~~~~~~~~~~ [all 2022-10-25 16:04:22] ../../gcc/gcc/config/xtensa/xtensa.md:897:9: note= : while referencing 'operands' [all 2022-10-25 16:04:22] 897 | (set_attr "mode" "SF") [all 2022-10-25 16:04:22] | ^~~~~~~~ [all 2022-10-25 16:04:22] ../../gcc/gcc/config/xtensa/xtensa.md:945:26: err= or: array subscript 2 is above array bounds of 'rtx_def* [2]' [-Werror=3Dar= ray-bounds] [all 2022-10-25 16:04:22] 945 | emit_move_insn (operands[2], op= erands[3]); [all 2022-10-25 16:04:22] | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~= ~~~~~~~~~~ [all 2022-10-25 16:04:22] ../../gcc/gcc/config/xtensa/xtensa.md:897:9: note= : while referencing 'operands' [all 2022-10-25 16:04:22] 897 | (set_attr "mode" "SF") [all 2022-10-25 16:04:22] | ^~~~~~~~ I didn't yet actually check the warning, it may be bogus. Thanks, Jan-Benedict --=20 --r5ed5mjdauqt6pcd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQQlDTvPcScNjKREqWEdvV51g5nhuwUCY1hCkwAKCRAdvV51g5nh uyebAJ98DNgStzdkHWXa0UBcOKQ4Senq1QCfaLEBYRYM6JAXKZn7CXnqt7ZUvAU= =WyAO -----END PGP SIGNATURE----- --r5ed5mjdauqt6pcd--