From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4B98F3858C55 for ; Tue, 1 Nov 2022 17:02:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4B98F3858C55 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667322134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K4F/ciBVzxshAqKLTDVZeLq+4fkH4R68ZAPYnFv302g=; b=PlpNFvBoeXvCXIlljtLw5TshIVxcyLFO9mnhOMEVOZyAUjjAJqiL0opbxoWz1YfQZWM348 Qmq9JSPIDAsIfOi7jgzKiPCIuALFZOeZlhdp08EougwhHdWtm7K+WddhMy/YEK1Eh9lQOq tgEaarU8uGEMGmjfesi9c5evh3Mtbqs= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-327-WLYPnnoBO4WNE10pFAN0TA-1; Tue, 01 Nov 2022 13:02:13 -0400 X-MC-Unique: WLYPnnoBO4WNE10pFAN0TA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A71633C021B1 for ; Tue, 1 Nov 2022 17:02:07 +0000 (UTC) Received: from pdp-11.redhat.com (unknown [10.22.16.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2E0A863A56; Tue, 1 Nov 2022 17:02:06 +0000 (UTC) From: Marek Polacek To: Jason Merrill , GCC Patches Subject: [PATCH] c++: Disable -Wignored-qualifiers for template args [PR107492] Date: Tue, 1 Nov 2022 13:01:56 -0400 Message-Id: <20221101170156.52672-1-polacek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: It seems wrong to issue a -Wignored-qualifiers warning for code like: static_assert(!is_same_v); because there the qualifier matters. Likewise in template specialization: template struct S { }; template<> struct S { }; template<> struct S { }; // OK, not a redefinition I'm of the mind that we should disable the warning for template arguments, as in the patch below. Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? PR c++/107492 gcc/cp/ChangeLog: * parser.cc (cp_parser_template_type_arg): Suppress -Wignored-qualifiers warning. gcc/testsuite/ChangeLog: * g++.dg/warn/Wignored-qualifiers3.C: New test. --- gcc/cp/parser.cc | 4 ++++ gcc/testsuite/g++.dg/warn/Wignored-qualifiers3.C | 12 ++++++++++++ 2 files changed, 16 insertions(+) create mode 100644 gcc/testsuite/g++.dg/warn/Wignored-qualifiers3.C diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc index e0e3cf3eaf6..54ad4b98ed3 100644 --- a/gcc/cp/parser.cc +++ b/gcc/cp/parser.cc @@ -24334,6 +24334,10 @@ cp_parser_template_type_arg (cp_parser *parser) const char *saved_message = parser->type_definition_forbidden_message; parser->type_definition_forbidden_message = G_("types may not be defined in template arguments"); + /* It's wrong to issue a -Wignored-qualifiers warning for + static_assert(!is_same_v); + because there the qualifier matters. */ + warning_sentinel w (warn_ignored_qualifiers); r = cp_parser_type_id_1 (parser, CP_PARSER_FLAGS_NONE, true, false, NULL); parser->type_definition_forbidden_message = saved_message; if (cxx_dialect >= cxx14 && !flag_concepts && type_uses_auto (r)) diff --git a/gcc/testsuite/g++.dg/warn/Wignored-qualifiers3.C b/gcc/testsuite/g++.dg/warn/Wignored-qualifiers3.C new file mode 100644 index 00000000000..5696feaaefe --- /dev/null +++ b/gcc/testsuite/g++.dg/warn/Wignored-qualifiers3.C @@ -0,0 +1,12 @@ +// PR c++/107492 +// { dg-do compile { target c++14 } } +// { dg-additional-options "-Wignored-qualifiers" } + +template struct S { }; +template<> struct S { }; +template<> struct S { }; // { dg-bogus "ignored" } + +template constexpr bool is_same_v = false; +template constexpr bool is_same_v = true; + +static_assert( ! is_same_v< void(*)(), const void(*)() >, ""); // { dg-bogus "ignored" } base-commit: e7310e24b1c0ca67b1bb507c1330b2bf39e59e32 -- 2.38.1