public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Eric Botcazou <botcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] x86: Replace ne:CCC/ne:CCO with UNSPEC_CC_NE in neg patterns
Date: Tue, 1 Nov 2022 15:34:31 -0500	[thread overview]
Message-ID: <20221101203431.GM25951@gate.crashing.org> (raw)
In-Reply-To: <2132915.irdbgypaU6@fomalhaut>

On Fri, Oct 28, 2022 at 11:55:35PM +0200, Eric Botcazou wrote:
> > You mean in CCV?  That works yes, but only because (or if) the setter
> > and getter of the CC reg both use CCV (so never use any other flag at
> > the same time; CCV has an empty intersection with all other CC modes).
> 
> We're talking about CCC here AFAIK, i.e. the carry, not CCV.

Yes.  But it is all the same: neither signed overflow nor unsigned
overflow (of an addition, say) can be described as the result of an
RTL comparison.

The point is that all of this is put completely outside of all other
MODE_CC handling, and only works because of that.  And a small
modification to the backend, completely elsewhere, can make that house
of cards collapse.  It is much more robust to use a different relation,
not EQ, to decribe this.  Something with an unspec is fine.

But what the sparc backend does does work.


Segher

  reply	other threads:[~2022-11-01 20:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 18:58 H.J. Lu
2022-10-27  6:06 ` Uros Bizjak
2022-10-28  5:56 ` Hongtao Liu
2022-10-28  6:08   ` Hongtao Liu
2022-10-28  8:35 ` Eric Botcazou
2022-10-28 15:51   ` H.J. Lu
2022-10-28 17:58     ` Eric Botcazou
2022-10-28 21:43   ` Segher Boessenkool
2022-10-28 21:55     ` Eric Botcazou
2022-11-01 20:34       ` Segher Boessenkool [this message]
2022-11-01 21:28         ` Eric Botcazou
2022-10-28 21:32 ` Segher Boessenkool
2022-10-28 22:28   ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221101203431.GM25951@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=botcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).