public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: gcc-patches@gcc.gnu.org
Cc: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>,
	Bernhard Reutner-Fischer <aldot@gcc.gnu.org>,
	Martin Liska <mliska@suse.cz>, Jan Hubicka <hubicka@ucw.cz>,
	Martin Jambor <mjambor@suse.cz>
Subject: [PATCH] cgraph_node: Remove redundant section clearing
Date: Thu,  3 Nov 2022 21:47:41 +0100	[thread overview]
Message-ID: <20221103204741.516199-1-aldot@gcc.gnu.org> (raw)

Ok for trunk if testing passes?

gcc/ChangeLog:

	* cgraph.cc (cgraph_node::make_local): Remove redundant set_section.
	* multiple_target.cc (create_dispatcher_calls): Likewise.

Signed-off-by: Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
---
 gcc/cgraph.cc          | 1 -
 gcc/multiple_target.cc | 1 -
 2 files changed, 2 deletions(-)

diff --git a/gcc/cgraph.cc b/gcc/cgraph.cc
index 8d6ed38efa2..36afa6f33f6 100644
--- a/gcc/cgraph.cc
+++ b/gcc/cgraph.cc
@@ -2488,15 +2488,14 @@ cgraph_node::make_local (cgraph_node *node, void *)
     {
       node->make_decl_local ();
       node->set_section (NULL);
       node->set_comdat_group (NULL);
       node->externally_visible = false;
       node->forced_by_abi = false;
       node->local = true;
-      node->set_section (NULL);
       node->unique_name = ((node->resolution == LDPR_PREVAILING_DEF_IRONLY
 			   || node->resolution == LDPR_PREVAILING_DEF_IRONLY_EXP)
 			   && !flag_incremental_link);
       node->resolution = LDPR_PREVAILING_DEF_IRONLY;
       gcc_assert (node->get_availability () == AVAIL_LOCAL);
     }
   return false;
diff --git a/gcc/multiple_target.cc b/gcc/multiple_target.cc
index 3e2d26882c8..67866a7c963 100644
--- a/gcc/multiple_target.cc
+++ b/gcc/multiple_target.cc
@@ -174,15 +174,14 @@ create_dispatcher_calls (struct cgraph_node *node)
       /* FIXME: copy of cgraph_node::make_local that should be cleaned up
 		in next stage1.  */
       node->make_decl_local ();
       node->set_section (NULL);
       node->set_comdat_group (NULL);
       node->externally_visible = false;
       node->forced_by_abi = false;
-      node->set_section (NULL);
 
       DECL_ARTIFICIAL (node->decl) = 1;
       node->force_output = true;
     }
 }
 
 /* Create string with attributes separated by comma.
-- 
2.38.1


             reply	other threads:[~2022-11-03 20:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 20:47 Bernhard Reutner-Fischer [this message]
2022-11-03 22:47 ` Jeff Law
2022-11-04 11:55 ` Jan Hubicka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221103204741.516199-1-aldot@gcc.gnu.org \
    --to=rep.dot.nop@gmail.com \
    --cc=aldot@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    --cc=mjambor@suse.cz \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).