From: "Marc Poulhiès" <poulhies@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Piotr Trojanek <trojanek@adacore.com>
Subject: [COMMITTED] ada: Reject expanded global names in lock-free protected objects
Date: Fri, 4 Nov 2022 14:53:47 +0100 [thread overview]
Message-ID: <20221104135347.85341-1-poulhies@adacore.com> (raw)
From: Piotr Trojanek <trojanek@adacore.com>
Lock-free expansion of protected subprograms is only possible when there
are no references to global assignable objects. We only detected such
references when they appeared as direct names, but we must similarly
detect expanded names.
gcc/ada/
* sem_ch9.adb (Satisfies_Lock_Free_Requirements): Detect
references via expanded names.
Tested on x86_64-pc-linux-gnu, committed on master.
---
gcc/ada/sem_ch9.adb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/ada/sem_ch9.adb b/gcc/ada/sem_ch9.adb
index f2a59017865..5dee216256c 100644
--- a/gcc/ada/sem_ch9.adb
+++ b/gcc/ada/sem_ch9.adb
@@ -463,7 +463,7 @@ package body Sem_Ch9 is
-- References
- elsif Kind = N_Identifier
+ elsif Kind in N_Identifier | N_Expanded_Name
and then Present (Entity (N))
then
declare
@@ -564,7 +564,7 @@ package body Sem_Ch9 is
-- reference only one component of the protected type, plus
-- the type of the component must support atomic operation.
- if Kind = N_Identifier
+ if Kind in N_Identifier | N_Expanded_Name
and then Present (Entity (N))
then
declare
--
2.34.1
reply other threads:[~2022-11-04 13:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104135347.85341-1-poulhies@adacore.com \
--to=poulhies@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=trojanek@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).