From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id D196E3855592 for ; Fri, 4 Nov 2022 13:58:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D196E3855592 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wm1-x335.google.com with SMTP id l39-20020a05600c1d2700b003cf93c8156dso1710805wms.4 for ; Fri, 04 Nov 2022 06:58:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TqEC2ET0xCt0+vXF5pqJZIpJCaZgIxmjGb6e6PNZz8g=; b=NLVii7Dt/ThBssoJEZ0A4aQ14lAX+3Q37ph0ok8Ns/AkGLjPGGKWH50SlJlsyR5djK XHpPoracn0+4+JVzlh5Xi9tJt6WhQKJuGME4ckmusFiXbyFNPXKlsuIEuBdYFRwn5sdv MJ0Fv/7q0UrcjgjNwBEj7zgj6WjIp1mF0zeoLMjehiAbG8ppu3cxrPfMfSeecD4gDjg+ 6++UUQJB4xIMTOhJZYk6M8e6SYsLYrk7SphTuEOgNg6r3GC2zTg497jJ6mJFYInXDGOw 2dK7wB1GhmtRzKHY1XB1WTUZBVNhwI1lEFj4zwrdM376xZhl/7i3AkEaB280PR3avO4Y xJZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TqEC2ET0xCt0+vXF5pqJZIpJCaZgIxmjGb6e6PNZz8g=; b=3HIPnAorgxoPOecwFUbBuYv1oaH0DTPAVlHZtR1XxIHnV/Pf2hXIa6cxTtuKkhQ83/ GHuhM7ZFXLpkmROuWorFcKJ4KxSpz3q54WWcEKmY6HmwwQ4GYb/OA2UakBlm5sCQLVpr Gm2BKFFDEETHMKygHwtmBkIVoONQauZoJ4tgtspr+D5Yjuy4I64Gy5XQQnMJnO8MydM8 MChQbd0ILoz9MP6DYCUo9DJSx3Bhp7g6WB+5Q5rLBnK+p6X7AhesoX/uJ76lldwhPD8h deC+VGrjwtx6Yk5n7GCHDVxcYIFxNfh6xL4uROaMJegQ4746mQSltacH1enKVKYN0IQd mLBA== X-Gm-Message-State: ACrzQf3osELTADWNz+SA7iP+3QQiiksXcYZrJrYuzb5FaZCPPmxXsFvQ JJnwn8yxohC4zVJXgQ/suEDZ2v5c2uRcQQ== X-Google-Smtp-Source: AMsMyM4asqfj01dL1Tc3J0NTSZESlVd+oPzxDvWpUb9XWqiNl9E9O2lNVDV+PrUsadqm8o1GdbQRdw== X-Received: by 2002:a05:600c:26d1:b0:3cf:7b67:f490 with SMTP id 17-20020a05600c26d100b003cf7b67f490mr15706701wmv.164.1667570328673; Fri, 04 Nov 2022 06:58:48 -0700 (PDT) Received: from localhost.localdomain (static-176-191-105-132.ftth.abo.bbox.fr. [176.191.105.132]) by smtp.gmail.com with ESMTPSA id o13-20020a05600c510d00b003cf54b77bfesm3200507wms.28.2022.11.04.06.58.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Nov 2022 06:58:48 -0700 (PDT) From: =?UTF-8?q?Marc=20Poulhi=C3=A8s?= To: gcc-patches@gcc.gnu.org Cc: Piotr Trojanek Subject: [COMMITTED] ada: Cleanup code for warnings about unreferenced formal parameters Date: Fri, 4 Nov 2022 14:58:44 +0100 Message-Id: <20221104135844.87117-1-poulhies@adacore.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Piotr Trojanek Cleanup related to new checks for unset references. gcc/ada/ * sem_warn.adb (Check_References): Remove redundant guard, as it is implied by a preceding call to Referenced_Check_Spec. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/sem_warn.adb | 9 --------- 1 file changed, 9 deletions(-) diff --git a/gcc/ada/sem_warn.adb b/gcc/ada/sem_warn.adb index a7f220bfbc7..77d58211b50 100644 --- a/gcc/ada/sem_warn.adb +++ b/gcc/ada/sem_warn.adb @@ -1639,15 +1639,6 @@ package body Sem_Warn is not Is_Package_Or_Generic_Package (Cunit_Entity (Current_Sem_Unit)))) - -- Exclude formal parameters from bodies if the corresponding - -- spec entity has been referenced in the case where there is - -- a separate spec. - - and then not (Is_Formal (E1) - and then Ekind (Scope (E1)) = E_Subprogram_Body - and then Present (Spec_Entity (E1)) - and then Referenced (Spec_Entity (E1))) - -- Consider private type referenced if full view is referenced. -- If there is not full view, this is a generic type on which -- warnings are also useful. -- 2.34.1