From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by sourceware.org (Postfix) with ESMTPS id B5BD53858409 for ; Tue, 8 Nov 2022 01:17:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B5BD53858409 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667870275; x=1699406275; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=JxHSQhWSQg9C9X+uXWXZCuJN3B8lM5t27ymnTTzA5yg=; b=lLX5Ot9rfVFYgftsoGJMELpQJFFItRazG3Qv67RzKaZWAfYW7c28iN4m Fo3BLrFMhXQA056oCAe890TUD3um/G+Ond6LifwyI2cnsl74iGQhkya1A UZciq17gd000ZZU33zLMq0DniPv6XfYqZYh010SWnKGrTO0LRDJhOfStg DHcIlAw8lDH5r46NhwTcG9mdfbsWRTg2PA5C/LoDSTL79E6k5ZUMbUIyw vo63m4d3APAREHuQyszOZktTklmzA/ldErdiuSgKS1cKZAsgdx4ocHuvZ ecn2Rph956F5r4ips7PNjZ5VpaMjKslf6D7w9xpDJYPePhprT8YvlcoXW w==; X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="308191792" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="308191792" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2022 17:17:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="587184909" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="587184909" Received: from shvmail03.sh.intel.com ([10.239.245.20]) by orsmga003.jf.intel.com with ESMTP; 07 Nov 2022 17:17:52 -0800 Received: from shliclel4051.sh.intel.com (shliclel4051.sh.intel.com [10.239.240.51]) by shvmail03.sh.intel.com (Postfix) with ESMTP id B659B10056BA; Tue, 8 Nov 2022 09:17:51 +0800 (CST) From: liuhongt To: gcc-patches@gcc.gnu.org Cc: crazylht@gmail.com, hjl.tools@gmail.com, ubizjak@gmail.com Subject: [PATCH] Fix incorrect insn type to avoid ICE in memory attr auto-detection. Date: Tue, 8 Nov 2022 09:17:51 +0800 Message-Id: <20221108011751.286433-1-hongtao.liu@intel.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Memory attribute auto detection will check operand 2 for type sselog, and check operand 1 for type sselog1. For below 2 insns, there's no operand 2. Change type to sselog1. Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. Ok for trunk? gcc/ChangeLog: PR target/107540 * config/i386/sse.md (avx512f_movddup512): Change type from sselog to sselog1. (avx_movddup256): Ditto. gcc/testsuite/ChangeLog: * gcc.target/i386/pr107540.c: New test. --- gcc/config/i386/sse.md | 4 ++-- gcc/testsuite/gcc.target/i386/pr107540.c | 12 ++++++++++++ 2 files changed, 14 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.target/i386/pr107540.c diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md index fa93ae7bf21..4e8463addc3 100644 --- a/gcc/config/i386/sse.md +++ b/gcc/config/i386/sse.md @@ -12203,7 +12203,7 @@ (define_insn "avx512f_movddup512" (const_int 6) (const_int 14)])))] "TARGET_AVX512F" "vmovddup\t{%1, %0|%0, %1}" - [(set_attr "type" "sselog") + [(set_attr "type" "sselog1") (set_attr "prefix" "evex") (set_attr "mode" "V8DF")]) @@ -12234,7 +12234,7 @@ (define_insn "avx_movddup256" (const_int 2) (const_int 6)])))] "TARGET_AVX && " "vmovddup\t{%1, %0|%0, %1}" - [(set_attr "type" "sselog") + [(set_attr "type" "sselog1") (set_attr "prefix" "") (set_attr "mode" "V4DF")]) diff --git a/gcc/testsuite/gcc.target/i386/pr107540.c b/gcc/testsuite/gcc.target/i386/pr107540.c new file mode 100644 index 00000000000..a0351ff9cb5 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr107540.c @@ -0,0 +1,12 @@ +/* { dg-do compile } */ +/* { dg-options "-flive-range-shrinkage -mavx" } */ + +typedef double __attribute__((__vector_size__ (32))) V; + +V v; + +void +foo (void) +{ + v = __builtin_ia32_movddup256 (v); +} -- 2.27.0