From: "Marc Poulhiès" <poulhies@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Piotr Trojanek <trojanek@adacore.com>
Subject: [COMMITTED] ada: Reject limited objects in array and record delta aggregates
Date: Tue, 8 Nov 2022 09:41:55 +0100 [thread overview]
Message-ID: <20221108084155.300994-1-poulhies@adacore.com> (raw)
From: Piotr Trojanek <trojanek@adacore.com>
For array delta aggregates the base expression cannot be limited; for
record delta aggregates the base expression can only be limited if it is
a newly constructed object.
gcc/ada/
* sem_aggr.adb (Resolve_Delta_Aggregate): Implement rules related
to limited objects appearing as the base expression.
Tested on x86_64-pc-linux-gnu, committed on master.
---
gcc/ada/sem_aggr.adb | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/gcc/ada/sem_aggr.adb b/gcc/ada/sem_aggr.adb
index 383f18f7301..4da05dd7317 100644
--- a/gcc/ada/sem_aggr.adb
+++ b/gcc/ada/sem_aggr.adb
@@ -3421,6 +3421,18 @@ package body Sem_Aggr is
Analyze_And_Resolve (Base, Typ);
if Is_Array_Type (Typ) then
+ -- For an array_delta_aggregate, the base_expression and each
+ -- expression in every array_component_association shall be of a
+ -- nonlimited type; RM 4.3.4(13/5). However, to prevent repeated
+ -- errors we only check the base expression and not array component
+ -- associations.
+
+ if Is_Limited_Type (Etype (Base)) then
+ Error_Msg_N
+ ("array delta aggregate shall be of a nonlimited type", Base);
+ Explain_Limited_Type (Etype (Base), Base);
+ end if;
+
Resolve_Delta_Array_Aggregate (N, Typ);
else
@@ -3432,6 +3444,11 @@ package body Sem_Aggr is
("delta aggregates for record types must use (), not '[']", N);
end if;
+ -- The base_expression of a record_delta_aggregate can be of a
+ -- limited type only if it is newly constructed; RM 7.5(2.1/5).
+
+ Check_Expr_OK_In_Limited_Aggregate (Base);
+
Resolve_Delta_Record_Aggregate (N, Typ);
end if;
--
2.34.1
reply other threads:[~2022-11-08 8:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221108084155.300994-1-poulhies@adacore.com \
--to=poulhies@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=trojanek@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).