public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Andrew MacLeod <amacleod@redhat.com>
Cc: rep.dot.nop@gmail.com,
	Andrew MacLeod via Gcc-patches <gcc-patches@gcc.gnu.org>,
	"hernandez, aldy" <aldyh@redhat.com>
Subject: Re: [COMMITTED] process transitive inferred ranges in pre_fold_stmt.
Date: Sat, 12 Nov 2022 08:12:08 +0100	[thread overview]
Message-ID: <20221112081208.3688c792@nbbrfq> (raw)
In-Reply-To: <3f2de5e6-027f-5669-b656-e4377d9cd2a8@redhat.com>

On Fri, 11 Nov 2022 18:17:46 -0500
Andrew MacLeod <amacleod@redhat.com> wrote:

> On 11/11/22 16:56, Bernhard Reutner-Fischer wrote:
> > So of course it doesn't really matter what that stmt was, a non_debug
> > is as good as a debug one AFAIU, it's just a marker, as good as any SSA
> > version or id, i suppose. So gsi_last_nondebug_bb(bb) is not strictly
> > needed, fine.  
> It is important. It needs to be the last non-debug statement so that we 

Ah of course, debug stmts are skipped. What was i thinking :)

> can properly feed values into the final stmt of the block.. be it a 
> conditional, switch or a return.

Right, i see. Thanks!
In my use-case, looking at blocks at the end of functions, i've seen
asm, nop, label, phi and resx, in addition, i believe.

> > But since it's last_stmt(), do you have an opinion on 1) in
> > https://gcc.gnu.org/pipermail/gcc-help/2021-November/140908.html
> > by chance, as you seem to use it..  
> 
> Not really.  It possible that there is a slightly more efficient way to 
> do it, not sure how measurable it would be.  Patches always welcome :-)

I don't think i measured it. But i think the output looked a tiny bit
better than the current one.

Well, thanks again for the explanation!

      reply	other threads:[~2022-11-12  7:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-11 16:17 Andrew MacLeod
2022-11-11 21:56 ` Bernhard Reutner-Fischer
2022-11-11 23:17   ` Andrew MacLeod
2022-11-12  7:12     ` Bernhard Reutner-Fischer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221112081208.3688c792@nbbrfq \
    --to=rep.dot.nop@gmail.com \
    --cc=aldyh@redhat.com \
    --cc=amacleod@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).