From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id CE16E3858425 for ; Sat, 12 Nov 2022 07:13:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CE16E3858425 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x433.google.com with SMTP id l14so9042582wrw.2 for ; Fri, 11 Nov 2022 23:13:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=jbkR7V5f47Lh0CaUhAr24E1XufA9ffIBnPslrjd7k5k=; b=Jf9xMP/KdbOUwak1vuKAybjti/sLDLiAjqr3axZxgsBDAvAdRtaOYPC6PuUTsNxPiI hsoujDlni76CJrLW7YTdLEHt1MgFEh+CTJ7oV1iKFZqoAUWdeyAkuvRsg9s9tGAEiJJf YZhWvU/KOCeIA19XfV9DsjXvADB4oOClbGlRR+/K6paGe2SmdghMbIUQQu1cn/CU32Ow QqKTKBe3PnlfHR3tfExWxjOFxL8aA0CHZwgOy+fQkIw9cs8XIKq+TD4RcX7NyKRxgIA/ xw3R/0VvbONcXmBRiQexb0MbOiqy55ic1jyKeo1WseTvurS5aBMyhBtABwWmHP6QwDgu R/Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jbkR7V5f47Lh0CaUhAr24E1XufA9ffIBnPslrjd7k5k=; b=TYPI0/NfPAKtA9jcCCyJM6wQiTnt0UjIIeSjoXirS5tEBj+WkpGS5U0EeJnB7fjDln TkKOFhUJX8ULkPxKfYQQuq5oWyyF0hpa6TKlcVgP5cp4qbQWOrOhNiRxcEdjxs7zyMU3 AywJzj/DsxXzl3SbZuX20kdF0XuImdO2GANM59qK6Mv1/0uTysDq2LXXWpqkF7b6Llvu PUgYe8bq9VJz3fadlvi4gXK/S1j8LQPAbRbMd6s6eVkyrvWsqU4YE6+rcwv6YGtFWm6V /chS1b6f5qa+1lnPd+NaBbRXUD8OrJclwMfDD6tRODvVEn+1N/Pe7ouVqatKeqBiHvDp zwIQ== X-Gm-Message-State: ANoB5pl7jTHlbjYZgJQmgwoAGAUD8P1SFIpabPlepn+of3V6QF6+q5Jg Zl2iZtLUQAb0n7Cpei1lJ/Y= X-Google-Smtp-Source: AA0mqf6LS+zVcSXVDUxHSeV/enFV+Q/ynmGA6JCavDaMgCUzwAjIOXl9VftFbNsGDgqxY/qAWJs33g== X-Received: by 2002:a5d:4346:0:b0:22e:2e3b:7ecf with SMTP id u6-20020a5d4346000000b0022e2e3b7ecfmr2893069wrr.304.1668237188222; Fri, 11 Nov 2022 23:13:08 -0800 (PST) Received: from nbbrfq ([2001:871:227:81c4:d7ff:3a0e:48da:5fe3]) by smtp.gmail.com with ESMTPSA id o7-20020a05600c4fc700b003a6125562e1sm5870075wmq.46.2022.11.11.23.13.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 23:13:07 -0800 (PST) Date: Sat, 12 Nov 2022 08:12:08 +0100 From: Bernhard Reutner-Fischer To: Andrew MacLeod Cc: rep.dot.nop@gmail.com, Andrew MacLeod via Gcc-patches , "hernandez, aldy" Subject: Re: [COMMITTED] process transitive inferred ranges in pre_fold_stmt. Message-ID: <20221112081208.3688c792@nbbrfq> In-Reply-To: <3f2de5e6-027f-5669-b656-e4377d9cd2a8@redhat.com> References: <3c68cb87-a088-85a0-0379-6aa893e36796@redhat.com> <20221111225641.66bfbad2@nbbrfq> <3f2de5e6-027f-5669-b656-e4377d9cd2a8@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 11 Nov 2022 18:17:46 -0500 Andrew MacLeod wrote: > On 11/11/22 16:56, Bernhard Reutner-Fischer wrote: > > So of course it doesn't really matter what that stmt was, a non_debug > > is as good as a debug one AFAIU, it's just a marker, as good as any SSA > > version or id, i suppose. So gsi_last_nondebug_bb(bb) is not strictly > > needed, fine. =20 > It is important. It needs to be the last non-debug statement so that we=20 Ah of course, debug stmts are skipped. What was i thinking :) > can properly feed values into the final stmt of the block.. be it a=20 > conditional, switch or a return. Right, i see. Thanks! In my use-case, looking at blocks at the end of functions, i've seen asm, nop, label, phi and resx, in addition, i believe. > > But since it's last_stmt(), do you have an opinion on 1) in > > https://gcc.gnu.org/pipermail/gcc-help/2021-November/140908.html > > by chance, as you seem to use it.. =20 >=20 > Not really.=C2=A0 It possible that there is a slightly more efficient way= to=20 > do it, not sure how measurable it would be.=C2=A0 Patches always welcome = :-) I don't think i measured it. But i think the output looked a tiny bit better than the current one. Well, thanks again for the explanation!