From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B4FBB3858412 for ; Sat, 12 Nov 2022 10:29:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B4FBB3858412 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668248948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xYW/z4zRyc4LlmZ5keISNrmQ2viNw/IiMxJj6pGFIKY=; b=CWEOmhejjo66vNorijnPpDG4c8mf0pHm/eIaIQWtT1l67Zw3449dPr2UZWtYiK//S0HTQO YymUkzrT4ZkQ3jFnV4LhHtDK3P+eqeE+O0mxgQzcaVau713fZo9jY94HyHRLo/dor4iZxF D/lSJnQ612d9ML5Cuvuxs8dhmkGBWko= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-653-WteTb3zXNC6Zr1KKFy4xVQ-1; Sat, 12 Nov 2022 05:29:07 -0500 X-MC-Unique: WteTb3zXNC6Zr1KKFy4xVQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CA77F3C021AF for ; Sat, 12 Nov 2022 10:29:06 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.192.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 68D142166B26; Sat, 12 Nov 2022 10:29:06 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 2ACAT1M6302772 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sat, 12 Nov 2022 11:29:01 +0100 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 2ACAT1mf302771; Sat, 12 Nov 2022 11:29:01 +0100 From: Aldy Hernandez To: GCC patches Cc: Andrew MacLeod , Aldy Hernandez Subject: [COMMITTED] [frange] Avoid testing signed zero test for -fno-signed-zeros. Date: Sat, 12 Nov 2022 11:28:59 +0100 Message-Id: <20221112102859.302600-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This patch moves a test that is meant to only work for signed zeros into range_tests_signed_zeros. I am not aware of any architectures where this is failing, but it is annoying to see selftests failing when -fno-signed-zeros is used. gcc/ChangeLog: * value-range.cc (range_tests_signbit): Move to set from here... (range_tests_signed_zeros): ...to here. --- gcc/value-range.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/gcc/value-range.cc b/gcc/value-range.cc index d55d85846c1..34fac636cad 100644 --- a/gcc/value-range.cc +++ b/gcc/value-range.cc @@ -3928,6 +3928,11 @@ range_tests_signed_zeros () r0.set_nonnegative (float_type_node); if (HONOR_NANS (float_type_node)) ASSERT_TRUE (r0.maybe_isnan ()); + + // Numbers containing zero should have an unknown SIGNBIT. + r0 = frange_float ("0", "10"); + r0.clear_nan (); + ASSERT_TRUE (r0.signbit_p (signbit) && !signbit); } static void @@ -3944,10 +3949,6 @@ range_tests_signbit () r0 = frange_float ("1", "10"); r0.clear_nan (); ASSERT_TRUE (r0.signbit_p (signbit) && !signbit); - // Numbers containing zero should have an unknown SIGNBIT. - r0 = frange_float ("0", "10"); - r0.clear_nan (); - ASSERT_TRUE (r0.signbit_p (signbit) && !signbit); // Numbers spanning both positive and negative should have an // unknown SIGNBIT. r0 = frange_float ("-10", "10"); -- 2.38.1