From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id 15824385843A; Sun, 13 Nov 2022 10:39:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 15824385843A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x435.google.com with SMTP id g12so12264948wrs.10; Sun, 13 Nov 2022 02:39:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=9TOIS3PLC2FqAq4NH6lISgYJvSmWrxreR8BXZedJ60o=; b=mCty16etCCpA39cvPvXGrhdjXOTFvuErqc6sgwNgnxfba4/e+DNmLvODAnUcm4zaBE UQXRDXf9x83jT2kjkbKJh6JwLMqcH/9++hionRCpxv8WSZeg5i9WW5gpzFD2niM4VJRj 7/UROnsiwsLnGIFY0x42QzDeAUj1K0XAfDbsRqcPpaExqUbnyhwNuHCFRDmGC92a2q+j 9mzLJOTzFtIwFq7C5JEKvapM60sxJ4L+FUfjByU4vL2QU4RNS3ZtWc+oF1aFXuP5hJkD E1TE3R4Utjlb722nT9aWvGxrA5MraZQIVDhWQUfiYMm0uY6IdWvaTZVlSAUJKT8e+6Tu A/QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9TOIS3PLC2FqAq4NH6lISgYJvSmWrxreR8BXZedJ60o=; b=ga1KXQlf+3AzajXnSEBSUrokxiV/B0F/aWHOf2mwsakDh7rXkYMuz3GZFshb7B4iNp aa0lxF74E+KZ1p358RKE7LRmXY9UmZrN4zhOjjVtwKuKondWdkkxQyggEwkeo8AuZXYs bMIGsyD1XtHwPKmytPWuomv9A8OEWDJBJkqodBlkUWpyCUuFMi13XyGEc26EpmzWUFKS azc6xWH6MEwvUD5VwbX+ERQ++qEiDqnw96g9l+KJROIxXfQgny/0z7byHMLZoNEoIv5/ mR3bJyBeZl2bVX0vup1c1ONFqVNhI8bkNGQhsKi7PchpiYo0ieEqipcnnV+Nsg7GD6u6 yR6A== X-Gm-Message-State: ANoB5pkiYUWx76IOK7GIrceQoKsPeDCl2XlpMT64KxI10voBtfK7RIcH CO5bi1JpweOA/5H6BvOsjaU= X-Google-Smtp-Source: AA0mqf7ti8JuR8U4UKAvjmNX6yb7tL5NrMylFefuON3Pg8rxlQju9qLP9bjyGO/0RFQ0HCZx8j6xdg== X-Received: by 2002:adf:f489:0:b0:236:5102:bd4c with SMTP id l9-20020adff489000000b002365102bd4cmr4966000wro.415.1668335982483; Sun, 13 Nov 2022 02:39:42 -0800 (PST) Received: from nbbrfq ([2001:871:227:81c4:d7ff:3a0e:48da:5fe3]) by smtp.gmail.com with ESMTPSA id u12-20020adfdb8c000000b002417ed67bfdsm3446600wri.5.2022.11.13.02.39.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Nov 2022 02:39:42 -0800 (PST) Date: Sun, 13 Nov 2022 11:39:38 +0100 From: Bernhard Reutner-Fischer To: Janne Blomqvist Cc: rep.dot.nop@gmail.com, gcc-patches@gcc.gnu.org, Bernhard Reutner-Fischer , fortran@gcc.gnu.org Subject: Re: [PATCH 3/5] Fortran: Narrow return types [PR78798] Message-ID: <20221113113938.555d4a06@nbbrfq> In-Reply-To: References: <20221112234543.95441-1-aldot@gcc.gnu.org> <20221112234543.95441-4-aldot@gcc.gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 13 Nov 2022 12:13:26 +0200 Janne Blomqvist wrote: > On Sun, Nov 13, 2022 at 1:47 AM Bernhard Reutner-Fischer via Fortran > wrote: > > --- a/gcc/fortran/arith.cc > > +++ b/gcc/fortran/arith.cc > > @@ -1135,7 +1135,7 @@ compare_complex (gfc_expr *op1, gfc_expr *op2) > > strings. We return -1 for a < b, 0 for a == b and 1 for a > b. > > We use the processor's default collating sequence. */ > > > > -int > > +signed char > > gfc_compare_string (gfc_expr *a, gfc_expr *b) > > { > > size_t len, alen, blen, i; > > @@ -1162,7 +1162,7 @@ gfc_compare_string (gfc_expr *a, gfc_expr *b) > > } > > Hmm, really? PR 78798 mentions changing int to bool, where > appropriate, which I think is uncontroversial, but this? Well we could leave this or all spots alone where a bool is insufficient, if you prefer. In the case of gfc_compare_string, the only user is simplify which only looks at ge/gt/le/lt 0