From: Richard Biener <rguenther@suse.de>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH] tree-optimization/107485 - fix non-call exception ICE with inlining
Date: Mon, 14 Nov 2022 19:08:31 +0100 (CET) [thread overview]
Message-ID: <20221114180832.49DD013A8C@imap2.suse-dmz.suse.de> (raw)
Inlining performs a wrong non-call exception fixup for VEC_COND_EXPRs
which on the branch fail to properly have the condition split out in
the first place.
Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed to
the GCC 10 branch which is the only one this code snippet prevails.
PR tree-optimization/107485
* tree-inline.c (remap_gimple_stmt): Use correct type for
split out condition of [VEC_]COND_EXPRs.
---
gcc/tree-inline.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/gcc/tree-inline.c b/gcc/tree-inline.c
index c20c25ceb50..658b09c07d2 100644
--- a/gcc/tree-inline.c
+++ b/gcc/tree-inline.c
@@ -1979,11 +1979,10 @@ remap_gimple_stmt (gimple *stmt, copy_body_data *id)
|| gimple_assign_rhs_code (ass) == VEC_COND_EXPR)
&& gimple_could_trap_p (ass))
{
- gassign *cmp
- = gimple_build_assign (make_ssa_name (boolean_type_node),
- gimple_assign_rhs1 (ass));
+ tree def = make_ssa_name (TREE_TYPE (gimple_assign_rhs1 (ass)));
+ gassign *cmp = gimple_build_assign (def, gimple_assign_rhs1 (ass));
gimple_seq_add_stmt (&stmts, cmp);
- gimple_assign_set_rhs1 (ass, gimple_assign_lhs (cmp));
+ gimple_assign_set_rhs1 (ass, def);
}
}
--
2.35.3
reply other threads:[~2022-11-14 18:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221114180832.49DD013A8C@imap2.suse-dmz.suse.de \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).