public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Malcolm <dmalcolm@redhat.com>
To: gcc-patches@gcc.gnu.org
Cc: David Malcolm <dmalcolm@redhat.com>
Subject: [committed] analyzer: more test coverage for named constants
Date: Wed, 16 Nov 2022 17:51:37 -0500	[thread overview]
Message-ID: <20221116225137.2985245-1-dmalcolm@redhat.com> (raw)

Successfully tested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-4115-gff199a859b2a95.

gcc/testsuite/ChangeLog:
	* gcc.dg/analyzer/named-constants-via-command-line.c: New test.
	* gcc.dg/analyzer/named-constants-via-macros-3.c: New test.
	* gcc.dg/analyzer/named-constants-via-macros-4.c: New test.
	* gcc.dg/analyzer/named-constants-via-macros-empty.c: New test.
	* gcc.dg/analyzer/named-constants-via-macros-gc.c: New test.
	* gcc.dg/analyzer/named-constants-via-macros-traditional.c: New test.
	* gcc.dg/analyzer/named-constants-via-macros-undef.c: New test.

Signed-off-by: David Malcolm <dmalcolm@redhat.com>
---
 .../named-constants-via-command-line.c        | 10 +++++++++
 .../analyzer/named-constants-via-macros-3.c   | 15 +++++++++++++
 .../analyzer/named-constants-via-macros-4.c   | 15 +++++++++++++
 .../named-constants-via-macros-empty.c        | 14 +++++++++++++
 .../analyzer/named-constants-via-macros-gc.c  | 21 +++++++++++++++++++
 .../named-constants-via-macros-traditional.c  | 16 ++++++++++++++
 .../named-constants-via-macros-undef.c        | 18 ++++++++++++++++
 7 files changed, 109 insertions(+)
 create mode 100644 gcc/testsuite/gcc.dg/analyzer/named-constants-via-command-line.c
 create mode 100644 gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-3.c
 create mode 100644 gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-4.c
 create mode 100644 gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-empty.c
 create mode 100644 gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-gc.c
 create mode 100644 gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-traditional.c
 create mode 100644 gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-undef.c

diff --git a/gcc/testsuite/gcc.dg/analyzer/named-constants-via-command-line.c b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-command-line.c
new file mode 100644
index 00000000000..4a3dd16752e
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-command-line.c
@@ -0,0 +1,10 @@
+/* { dg-additional-options "-DO_ACCMODE=42 -DO_RDONLY=0x1 -DO_WRONLY=010" } */
+
+#include "analyzer-decls.h"
+
+void test_sm_fd_constants (void)
+{
+  __analyzer_dump_named_constant ("O_ACCMODE"); /* { dg-warning "named constant 'O_ACCMODE' has value '42'" } */
+  __analyzer_dump_named_constant ("O_RDONLY"); /* { dg-warning "named constant 'O_RDONLY' has value '1'" } */
+  __analyzer_dump_named_constant ("O_WRONLY"); /* { dg-warning "named constant 'O_WRONLY' has value '8'" } */
+}
diff --git a/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-3.c b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-3.c
new file mode 100644
index 00000000000..2a3f2b0070a
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-3.c
@@ -0,0 +1,15 @@
+#include "analyzer-decls.h"
+
+/* Various constants used by the fd state machine, as macros
+   that can't be handled.  */
+
+#define O_RDONLY  (1 << 0)
+#define O_WRONLY  (1 << 1)
+#define O_ACCMODE (O_RDONLY | O_WRONLY)
+
+void test_sm_fd_constants (void)
+{
+  __analyzer_dump_named_constant ("O_ACCMODE"); /* { dg-warning "named constant 'O_ACCMODE' has unknown value" } */
+  __analyzer_dump_named_constant ("O_RDONLY"); /* { dg-warning "named constant 'O_RDONLY' has unknown value" } */
+  __analyzer_dump_named_constant ("O_WRONLY"); /* { dg-warning "named constant 'O_WRONLY' has unknown value" } */
+}
diff --git a/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-4.c b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-4.c
new file mode 100644
index 00000000000..16eef964051
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-4.c
@@ -0,0 +1,15 @@
+#include "analyzer-decls.h"
+
+/* Various constants used by the fd state machine, as macros
+   that can't be handled.  */
+
+#define O_ACCMODE(X) 42
+#define O_RDONLY(X)  0x1
+#define O_WRONLY(X)  010
+
+void test_sm_fd_constants (void)
+{
+  __analyzer_dump_named_constant ("O_ACCMODE"); /* { dg-warning "named constant 'O_ACCMODE' has unknown value" } */
+  __analyzer_dump_named_constant ("O_RDONLY"); /* { dg-warning "named constant 'O_RDONLY' has unknown value" } */
+  __analyzer_dump_named_constant ("O_WRONLY"); /* { dg-warning "named constant 'O_WRONLY' has unknown value" } */
+}
diff --git a/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-empty.c b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-empty.c
new file mode 100644
index 00000000000..3d347e2caf5
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-empty.c
@@ -0,0 +1,14 @@
+#include "analyzer-decls.h"
+
+/* Various constants used by the fd state machine.  */
+
+#define O_ACCMODE
+#define O_RDONLY
+#define O_WRONLY
+
+void test_sm_fd_constants (void)
+{
+  __analyzer_dump_named_constant ("O_ACCMODE"); /* { dg-warning "named constant 'O_ACCMODE' has unknown value" } */
+  __analyzer_dump_named_constant ("O_RDONLY"); /* { dg-warning "named constant 'O_RDONLY' has unknown value" } */
+  __analyzer_dump_named_constant ("O_WRONLY"); /* { dg-warning "named constant 'O_WRONLY' has unknown value" } */
+}
diff --git a/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-gc.c b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-gc.c
new file mode 100644
index 00000000000..e7b12f325a5
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-gc.c
@@ -0,0 +1,21 @@
+/* { dg-additional-options "--param ggc-min-expand=0 --param ggc-min-heapsize=0" } */
+
+#include "analyzer-decls.h"
+
+/* Various constants used by the fd state machine.  */
+
+#define O_ACCMODE 42
+#define O_RDONLY  0x1
+#define O_WRONLY  010
+
+void test_sm_fd_constants (void)
+{
+  __analyzer_dump_named_constant ("O_ACCMODE"); /* { dg-warning "named constant 'O_ACCMODE' has value '42'" } */
+  __analyzer_dump_named_constant ("O_RDONLY"); /* { dg-warning "named constant 'O_RDONLY' has value '1'" } */
+  __analyzer_dump_named_constant ("O_WRONLY"); /* { dg-warning "named constant 'O_WRONLY' has value '8'" } */
+}
+
+void test_unknown (void)
+{
+  __analyzer_dump_named_constant ("UNKNOWN"); /* { dg-warning "named constant 'UNKNOWN' has unknown value" } */
+}
diff --git a/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-traditional.c b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-traditional.c
new file mode 100644
index 00000000000..64acaad6aa0
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-traditional.c
@@ -0,0 +1,16 @@
+/* { dg-additional-options "-traditional-cpp" } */
+
+#include "analyzer-decls.h"
+
+/* Various constants used by the fd state machine.  */
+
+#define O_ACCMODE 42
+#define O_RDONLY  0x1
+#define O_WRONLY  010
+
+void test_sm_fd_constants (void)
+{
+  __analyzer_dump_named_constant ("O_ACCMODE"); /* { dg-warning "named constant 'O_ACCMODE' has unknown value" } */
+  __analyzer_dump_named_constant ("O_RDONLY"); /* { dg-warning "named constant 'O_RDONLY' has unknown value" } */
+  __analyzer_dump_named_constant ("O_WRONLY"); /* { dg-warning "named constant 'O_WRONLY' has unknown value" } */
+}
diff --git a/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-undef.c b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-undef.c
new file mode 100644
index 00000000000..46c03223190
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/analyzer/named-constants-via-macros-undef.c
@@ -0,0 +1,18 @@
+#include "analyzer-decls.h"
+
+/* Various constants used by the fd state machine.  */
+
+#define O_ACCMODE 42
+#define O_RDONLY  0x1
+#define O_WRONLY  010
+
+#undef O_ACCMODE
+#undef O_RDONLY
+#undef O_WRONLY
+
+void test_sm_fd_constants (void)
+{
+  __analyzer_dump_named_constant ("O_ACCMODE"); /* { dg-warning "named constant 'O_ACCMODE' has unknown value" } */
+  __analyzer_dump_named_constant ("O_RDONLY"); /* { dg-warning "named constant 'O_RDONLY' has unknown value" } */
+  __analyzer_dump_named_constant ("O_WRONLY"); /* { dg-warning "named constant 'O_WRONLY' has unknown value" } */
+}
-- 
2.26.3


                 reply	other threads:[~2022-11-16 22:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221116225137.2985245-1-dmalcolm@redhat.com \
    --to=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).