From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 0DEAC3853D6E for ; Fri, 18 Nov 2022 14:47:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0DEAC3853D6E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 2AIEk1Rn014925; Fri, 18 Nov 2022 08:46:01 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 2AIEk1E6014924; Fri, 18 Nov 2022 08:46:01 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Fri, 18 Nov 2022 08:46:00 -0600 From: Segher Boessenkool To: Hongyu Wang Cc: gcc-patches@gcc.gnu.org, dje.gcc@gmail.com Subject: Re: [PATCH] rs6000: Adjust loop_unroll_adjust to match middle-end change [PR 107692] Message-ID: <20221118144600.GZ25951@gate.crashing.org> References: <20221116235429.25268-1-hongyu.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221116235429.25268-1-hongyu.wang@intel.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: [ Please cc: me and Ke Wen on rs6000 patches ] On Thu, Nov 17, 2022 at 07:54:29AM +0800, Hongyu Wang wrote: > r13-3950-g071e428c24ee8c enables O2 small loop unrolling, but it breaks > -fno-unroll-loops for rs6000 with loop_unroll_adjust hook. Adjust the > option handling and target hook accordingly. NAK. This is wrong. -munroll-only-small-loops does not enable loop unrolling; doing that with a machine flag is completely unmaintainable, also for people using different targets. Something in your patch was wrong, please fix that (or revert the patch). You should not have to touch config/rs6000/ at all. Segher