From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from server28.superhosting.bg (server28.superhosting.bg [217.174.156.11]) by sourceware.org (Postfix) with ESMTPS id 2D6793959C85 for ; Sun, 20 Nov 2022 10:03:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2D6793959C85 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dinux.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dinux.eu DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dinux.eu; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OI74qRtzG09jRG2HO7T7Yx7x8CJQKKZPntIjY0L13Aw=; b=NwE8XoEO5kej1OGeGWBd6eEbkr NEW4b8OxZq48MrsEzum5GAFhZS3K9YYM041WEM1YZT9rdEj1X+FB+X3IU0RKXIfmKcOVbeXz6BKcc 62Y0OU/IDpA5llCC1mZC1uj9UmwY2x1q6GsCnido6jq9zfx5cNM2g9+ettI7rq/lXtyNTNXlwoA2q CoPax2O9+oewG+YpPDPE586lhi0pRVodKEJcMvuagWCGJhKooPJnER+ADhIkMtTurmIz37PMFKyWj lD6GeXqBJTplY6TD2dcS/Noalau7nWw1rhfpxJwtOmMl+O/18k1Vr42S/O7AQZyJBGSYG0LBaOxFY X72cfCxg==; Received: from [95.87.234.74] (port=60442 helo=kendros.lan) by server28.superhosting.bg with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1owhAG-0008ZP-6j; Sun, 20 Nov 2022 12:03:06 +0200 From: Dimitar Dimitrov To: gcc-patches@gcc.gnu.org Cc: Dimitar Dimitrov Subject: [PATCH] testsuite: Add filter for target socket support Date: Sun, 20 Nov 2022 12:02:57 +0200 Message-Id: <20221120100257.281467-1-dimitar@dinux.eu> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server28.superhosting.bg X-AntiAbuse: Original Domain - gcc.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - dinux.eu X-Get-Message-Sender-Via: server28.superhosting.bg: authenticated_id: dimitar@dinux.eu X-Authenticated-Sender: server28.superhosting.bg: dimitar@dinux.eu X-Source: X-Source-Args: X-Source-Dir: X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The new analyzer tests for sockets are failing on embedded targets. The newlib and avr-libc C libraries do not support sockets. At first I considered a coarse filtering on the existing effective_target_freestanding check. But seeing how lib/target-supports.exp is slowly turning into a copy of autotools, I kept the tradition and added a new fine grained "socket" filter. I also considered adding effective_target_posix, but could not figure out a reliable C code to perform the check. Testing done: - No changes in gcc.sum for x86_64-pc-linux-gnu, with or without this patch. - Filtered cases are now UNSUPPORTED instead of failing on AVR and PRU backends. Ok for trunk? gcc/ChangeLog: * doc/sourcebuild.texi (sockets): Document new check. gcc/testsuite/ChangeLog: * gcc.dg/analyzer/fd-accept.c: Require sockets. * gcc.dg/analyzer/fd-bind.c: Ditto. * gcc.dg/analyzer/fd-connect.c: Ditto. * gcc.dg/analyzer/fd-datagram-socket.c: Ditto. * gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c: Ditto. * gcc.dg/analyzer/fd-glibc-byte-stream-socket.c: Ditto. * gcc.dg/analyzer/fd-glibc-datagram-client.c: Ditto. * gcc.dg/analyzer/fd-glibc-datagram-socket.c: Ditto. * gcc.dg/analyzer/fd-listen.c: Ditto. * gcc.dg/analyzer/fd-manpage-getaddrinfo-client.c: Ditto. * gcc.dg/analyzer/fd-mappage-getaddrinfo-server.c: Ditto. * gcc.dg/analyzer/fd-meaning.c: Ditto. * gcc.dg/analyzer/fd-socket-meaning.c: Ditto. * gcc.dg/analyzer/fd-socket-misuse.c: Ditto. * gcc.dg/analyzer/fd-stream-socket-active-open.c: Ditto. * gcc.dg/analyzer/fd-stream-socket-passive-open.c: Ditto. * gcc.dg/analyzer/fd-stream-socket.c: Ditto. * gcc.dg/analyzer/fd-symbolic-socket.c: Ditto. * lib/target-supports.exp (check_effective_target_sockets): New check. Signed-off-by: Dimitar Dimitrov --- gcc/doc/sourcebuild.texi | 3 +++ gcc/testsuite/gcc.dg/analyzer/fd-accept.c | 2 ++ gcc/testsuite/gcc.dg/analyzer/fd-bind.c | 2 ++ gcc/testsuite/gcc.dg/analyzer/fd-connect.c | 2 ++ gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c | 2 ++ .../fd-glibc-byte-stream-connection-server.c | 1 + .../gcc.dg/analyzer/fd-glibc-byte-stream-socket.c | 1 + .../gcc.dg/analyzer/fd-glibc-datagram-client.c | 1 + .../gcc.dg/analyzer/fd-glibc-datagram-socket.c | 1 + gcc/testsuite/gcc.dg/analyzer/fd-listen.c | 2 ++ .../analyzer/fd-manpage-getaddrinfo-client.c | 1 + .../analyzer/fd-mappage-getaddrinfo-server.c | 2 ++ gcc/testsuite/gcc.dg/analyzer/fd-meaning.c | 2 +- gcc/testsuite/gcc.dg/analyzer/fd-socket-meaning.c | 1 + gcc/testsuite/gcc.dg/analyzer/fd-socket-misuse.c | 2 ++ .../gcc.dg/analyzer/fd-stream-socket-active-open.c | 2 ++ .../analyzer/fd-stream-socket-passive-open.c | 2 ++ gcc/testsuite/gcc.dg/analyzer/fd-stream-socket.c | 2 ++ gcc/testsuite/gcc.dg/analyzer/fd-symbolic-socket.c | 2 ++ gcc/testsuite/lib/target-supports.exp | 14 ++++++++++++++ 20 files changed, 46 insertions(+), 1 deletion(-) diff --git a/gcc/doc/sourcebuild.texi b/gcc/doc/sourcebuild.texi index 766266942f9..ffe69d6fcb9 100644 --- a/gcc/doc/sourcebuild.texi +++ b/gcc/doc/sourcebuild.texi @@ -2666,6 +2666,9 @@ Target can compile using @code{pthread.h} with no errors or warnings. @item pthread_h Target has @code{pthread.h}. +@item sockets +Target can compile using @code{sys/socket.h} with no errors or warnings. + @item run_expensive_tests Expensive testcases (usually those that consume excessive amounts of CPU time) should be run on this target. This can be enabled by setting the diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-accept.c b/gcc/testsuite/gcc.dg/analyzer/fd-accept.c index 36cc7af7184..5426063f31d 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-accept.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-accept.c @@ -1,3 +1,5 @@ +/* { dg-require-effective-target sockets } */ + #include #include #include diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-bind.c b/gcc/testsuite/gcc.dg/analyzer/fd-bind.c index 6f91bc4b794..c34803f1380 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-bind.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-bind.c @@ -1,3 +1,5 @@ +/* { dg-require-effective-target sockets } */ + #include #include #include diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-connect.c b/gcc/testsuite/gcc.dg/analyzer/fd-connect.c index 1ab54d01f36..7bf687e2570 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-connect.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-connect.c @@ -1,3 +1,5 @@ +/* { dg-require-effective-target sockets } */ + #include #include #include diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c b/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c index 045bdfa32d3..58508570a25 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c @@ -1,3 +1,5 @@ +/* { dg-require-effective-target sockets } */ + #include #include #include diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c b/gcc/testsuite/gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c index 1ff902894af..5a1a6f5f14f 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c @@ -1,4 +1,5 @@ /* Example from glibc manual (16.9.7). */ +/* { dg-require-effective-target sockets } */ /* { dg-additional-options "-Wno-analyzer-too-complex" } */ #include diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-glibc-byte-stream-socket.c b/gcc/testsuite/gcc.dg/analyzer/fd-glibc-byte-stream-socket.c index f96da8101cc..806bb24d9eb 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-glibc-byte-stream-socket.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-glibc-byte-stream-socket.c @@ -1,4 +1,5 @@ /* Example from glibc manual (16.9.6). */ +/* { dg-require-effective-target sockets } */ #include #include diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-glibc-datagram-client.c b/gcc/testsuite/gcc.dg/analyzer/fd-glibc-datagram-client.c index 888c751e88d..072ac4cd0d3 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-glibc-datagram-client.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-glibc-datagram-client.c @@ -1,4 +1,5 @@ /* Example from the glibc manual (16.10.4). */ +/* { dg-require-effective-target sockets } */ #include #include diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-glibc-datagram-socket.c b/gcc/testsuite/gcc.dg/analyzer/fd-glibc-datagram-socket.c index b8b68768c34..d417828f6ee 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-glibc-datagram-socket.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-glibc-datagram-socket.c @@ -1,4 +1,5 @@ /* Example from glibc manual (16.10.3). */ +/* { dg-require-effective-target sockets } */ #include #include diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-listen.c b/gcc/testsuite/gcc.dg/analyzer/fd-listen.c index 1f54a8f2953..becf4690293 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-listen.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-listen.c @@ -1,3 +1,5 @@ +/* { dg-require-effective-target sockets } */ + #include #include #include diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-manpage-getaddrinfo-client.c b/gcc/testsuite/gcc.dg/analyzer/fd-manpage-getaddrinfo-client.c index d9c3ff05de8..ee627de9643 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-manpage-getaddrinfo-client.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-manpage-getaddrinfo-client.c @@ -26,6 +26,7 @@ Formatted or processed versions of this manual, if unaccompanied by the source, must acknowledge the copyright and authors of this work. */ +/* { dg-require-effective-target sockets } */ /* { dg-additional-options "-Wno-analyzer-too-complex" } */ #include diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-mappage-getaddrinfo-server.c b/gcc/testsuite/gcc.dg/analyzer/fd-mappage-getaddrinfo-server.c index 66398e834cc..d2e39eb6976 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-mappage-getaddrinfo-server.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-mappage-getaddrinfo-server.c @@ -26,6 +26,8 @@ Formatted or processed versions of this manual, if unaccompanied by the source, must acknowledge the copyright and authors of this work. */ +/* { dg-require-effective-target sockets } */ + #include #include #include diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-meaning.c b/gcc/testsuite/gcc.dg/analyzer/fd-meaning.c index 6a9ec921fd3..384dbd08158 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-meaning.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-meaning.c @@ -34,4 +34,4 @@ void test_3 (const char* path) close(fd); /* { dg-message "meaning: \\{verb: 'release', noun: 'resource'\\}" } */ close(fd); /* { dg-warning "double 'close' of file descriptor 'fd' \\\[CWE-1341\\\]" } */ } -} \ No newline at end of file +} diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-socket-meaning.c b/gcc/testsuite/gcc.dg/analyzer/fd-socket-meaning.c index 5bfb57f68fb..82a199f83b0 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-socket-meaning.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-socket-meaning.c @@ -1,3 +1,4 @@ +/* { dg-require-effective-target sockets } */ /* { dg-additional-options "-fanalyzer-verbose-state-changes" } */ #include diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-socket-misuse.c b/gcc/testsuite/gcc.dg/analyzer/fd-socket-misuse.c index 4ff08d5ec19..628f5e4a65c 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-socket-misuse.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-socket-misuse.c @@ -1,5 +1,7 @@ /* Various operations done on sockets in the wrong phase. */ +/* { dg-require-effective-target sockets } */ + #include #include #include diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-active-open.c b/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-active-open.c index 7fde0ef6285..841894cc1bd 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-active-open.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-active-open.c @@ -1,3 +1,5 @@ +/* { dg-require-effective-target sockets } */ + #include #include #include diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-passive-open.c b/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-passive-open.c index c31e5b5eefb..a61091101ed 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-passive-open.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-passive-open.c @@ -2,6 +2,8 @@ either from scratch, or when various phases are assumed to already be done. */ +/* { dg-require-effective-target sockets } */ + #include #include #include diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket.c b/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket.c index 3a292d0e2d2..e51f0f08c34 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket.c @@ -1,3 +1,5 @@ +/* { dg-require-effective-target sockets } */ + #include #include #include diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-symbolic-socket.c b/gcc/testsuite/gcc.dg/analyzer/fd-symbolic-socket.c index 83400c18f50..ad1f989cf09 100644 --- a/gcc/testsuite/gcc.dg/analyzer/fd-symbolic-socket.c +++ b/gcc/testsuite/gcc.dg/analyzer/fd-symbolic-socket.c @@ -1,3 +1,5 @@ +/* { dg-require-effective-target sockets } */ + #include #include #include diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index 01cf17ea44a..65ba33b9d94 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -1176,6 +1176,20 @@ proc check_effective_target_pthread {} { } "-pthread"] } +# Return 1 if the target supports both Unix and internet sockets, 0 otherwise. +proc check_effective_target_sockets {} { + return [check_no_compiler_messages socket executable { +#include +#include +#include +int main (void) { + socket(AF_UNIX, SOCK_STREAM, 0); + socket(AF_INET, SOCK_DGRAM, 0); + return 0; +} + } ""] +} + # Return 1 if compilation with -mpe-aligned-commons is error-free # for trivial code, 0 otherwise. -- 2.38.1