From: "Marc Poulhiès" <poulhies@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Ghjuvan Lacambre <lacambre@adacore.com>
Subject: [COMMITTED] ada: Disable checking of Elab_Spec procedures in CodePeer_Mode
Date: Tue, 22 Nov 2022 13:36:54 +0100 [thread overview]
Message-ID: <20221122123654.336392-1-poulhies@adacore.com> (raw)
From: Ghjuvan Lacambre <lacambre@adacore.com>
This commit re-enables the Validate_Subprogram_Calls check that had been
disabled in a previous commit and has said check skip over Elab_Spec
procedures in CodePeer_Mode.
gcc/ada/
* frontend.adb (Frontend): Re-enable Validate_Subprogram_Calls.
* exp_ch6.adb (Check_BIP_Actuals): When in CodePeer mode, do not
attempt to validate procedures coming from an
Elab_Spec/Elab_Body/Elab_Subp_Body procedure.
Tested on x86_64-pc-linux-gnu, committed on master.
---
gcc/ada/exp_ch6.adb | 17 +++++++++++++++++
gcc/ada/frontend.adb | 2 +-
2 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/gcc/ada/exp_ch6.adb b/gcc/ada/exp_ch6.adb
index a5dee38c55f..237a19d1327 100644
--- a/gcc/ada/exp_ch6.adb
+++ b/gcc/ada/exp_ch6.adb
@@ -1115,6 +1115,23 @@ package body Exp_Ch6 is
| N_Function_Call
| N_Procedure_Call_Statement);
+ -- In CodePeer_Mode, the tree for `'Elab_Spec` procedures will be
+ -- malformed because GNAT does not perform the usual expansion that
+ -- results in the importation of external elaboration procedure symbols.
+ -- This is expected: the CodePeer backend has special handling for this
+ -- malformed tree.
+ -- Thus, we do not need to check the tree (and in fact can't, because
+ -- it's malformed).
+
+ if CodePeer_Mode
+ and then Nkind (Name (Subp_Call)) = N_Attribute_Reference
+ and then Attribute_Name (Name (Subp_Call)) in Name_Elab_Spec
+ | Name_Elab_Body
+ | Name_Elab_Subp_Body
+ then
+ return True;
+ end if;
+
Formal := First_Formal_With_Extras (Subp_Id);
Actual := First_Actual (Subp_Call);
diff --git a/gcc/ada/frontend.adb b/gcc/ada/frontend.adb
index bc3da30b0cf..033ecf3b7be 100644
--- a/gcc/ada/frontend.adb
+++ b/gcc/ada/frontend.adb
@@ -531,7 +531,7 @@ begin
-- formals). It is invoked using pragma Debug to avoid adding any cost
-- when the compiler is built with assertions disabled.
- if not Debug_Flag_Underscore_XX and then not CodePeer_Mode then
+ if not Debug_Flag_Underscore_XX then
pragma Debug (Exp_Ch6.Validate_Subprogram_Calls (Cunit (Main_Unit)));
end if;
--
2.34.1
reply other threads:[~2022-11-22 12:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122123654.336392-1-poulhies@adacore.com \
--to=poulhies@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=lacambre@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).