From: Kees Cook <keescook@chromium.org>
To: Qing Zhao <qing.zhao@oracle.com>
Cc: rguenther@suse.de, joseph@codesourcery.com,
gcc-patches@gcc.gnu.org, siddhesh@gcc.gnu.org
Subject: Re: [V2][PATCH 1/1] Add a new warning option -Wstrict-flex-arrays.
Date: Thu, 1 Dec 2022 08:42:38 -0800 [thread overview]
Message-ID: <202212010840.C963E72661@keescook> (raw)
In-Reply-To: <20221130142556.3079865-2-qing.zhao@oracle.com>
On Wed, Nov 30, 2022 at 02:25:56PM +0000, Qing Zhao wrote:
> '-Wstrict-flex-arrays'
> Warn about inproper usages of flexible array members according to
> the LEVEL of the 'strict_flex_array (LEVEL)' attribute attached to
> the trailing array field of a structure if it's available,
> otherwise according to the LEVEL of the option
> '-fstrict-flex-arrays=LEVEL'.
>
> This option is effective only when LEVEL is bigger than 0.
> Otherwise, it will be ignored with a warning.
>
> when LEVEL=1, warnings will be issued for a trailing array
> reference of a structure that have 2 or more elements if the
> trailing array is referenced as a flexible array member.
>
> when LEVEL=2, in addition to LEVEL=1, additional warnings will be
> issued for a trailing one-element array reference of a structure if
> the array is referenced as a flexible array member.
>
> when LEVEL=3, in addition to LEVEL=2, additional warnings will be
> issued for a trailing zero-length array reference of a structure if
> the array is referenced as a flexible array member.
>
> At the same time, -Warray-bounds is updated:
Why is there both -Wstrict-flex-arrays and -Warray-bounds? I thought
only the latter was going to exist?
Are you trying to split code gen (-fstrict-flex-arrays) from warnings?
Is that needed?
--
Kees Cook
next prev parent reply other threads:[~2022-12-01 16:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 14:25 [V2][PATCH 0/1]Add " Qing Zhao
2022-11-30 14:25 ` [V2][PATCH 1/1] Add " Qing Zhao
2022-12-01 16:42 ` Kees Cook [this message]
2022-12-01 17:04 ` Qing Zhao
2022-12-01 17:18 ` Kees Cook
2022-12-01 17:48 ` Qing Zhao
2022-12-01 19:45 ` Siddhesh Poyarekar
2022-12-01 22:27 ` Qing Zhao
2022-12-01 23:19 ` Kees Cook
2022-12-01 23:53 ` Siddhesh Poyarekar
2022-12-02 7:16 ` Richard Biener
2022-12-02 7:20 ` Richard Biener
2022-12-02 14:43 ` Qing Zhao
2022-12-05 15:16 ` Richard Biener
2022-12-05 15:20 ` Qing Zhao
2022-12-02 14:40 ` Qing Zhao
2022-12-06 16:14 [V3][PATCH 0/2]Update -Warray-bounds with -fstrict-flex-arrays Qing Zhao
2022-12-06 16:14 ` [V2][PATCH 1/1] Add a new warning option -Wstrict-flex-arrays Qing Zhao
2022-12-06 16:16 ` Qing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202212010840.C963E72661@keescook \
--to=keescook@chromium.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=qing.zhao@oracle.com \
--cc=rguenther@suse.de \
--cc=siddhesh@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).