From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id 309D038432EF for ; Sun, 4 Dec 2022 20:05:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 309D038432EF Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1p1vEU-000A0M-U8 for gcc-patches@gcc.gnu.org; Sun, 04 Dec 2022 21:05:02 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: gcc-patches@gcc.gnu.org From: Harald Anlauf Subject: Re: [PATCH] Fortran: error recovery simplifying UNPACK for insufficient FIELD [PR107922] Date: Sun, 4 Dec 2022 21:04:58 +0100 Message-ID: <7968b07a-6453-d592-c5a0-bb28699dab01@gmx.de> References: <428cdc11-84c7-3837-e96f-9ec00c640643@orange.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US In-Reply-To: <428cdc11-84c7-3837-e96f-9ec00c640643@orange.fr> Cc: fortran@gcc.gnu.org X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20221204200458.2rWYUoADYzvaT0PU9aap14IS2_6oBoSjz6c7I_EA68c@z> Hi Mikael, Am 04.12.22 um 14:11 schrieb Mikael Morin: > Le 01/12/2022 à 21:25, Harald Anlauf via Fortran a écrit : >> Dear all, >> >> we did not properly handle the case of insufficient array-valued >> FIELD when trying to simplify UNPACK and could run into a NULL >> pointer dereference.  The fix is obvious. >> >> Regtested on x86_64-pc-linux-gnu.  OK for mainline? >> > The change looks good, but please add braces around the new if-else > structure. > OK with that change. thanks for the hint. It indeed looks more readable with this small change. Pushed: r13-4486-g24b9337d1f1b5197b6498dceb9074319be003449 > Thanks. > Thanks, Harald