From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 87195383B695; Mon, 12 Dec 2022 01:38:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 87195383B695 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BC1QImu009909; Mon, 12 Dec 2022 01:38:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version; s=pp1; bh=G+OJlydX3Kq8yaLY7TR6PGew9+PtJSHEt8Y+9MJ5gK4=; b=eUUGXwCV5IlwTfU6aCQIyjCGh402ZARv2FnmOS+ACVVotxS8IPXtDXMoo+5aYRPxCCJY Z0FPpqljyIB2YuP7XlQuu98D6erCXExZKMiIMVNpZxSjwTTB2VYZaMK1FfD5Egavek03 EaGzqIMIUiCsTx8eHuO/BHjv4u1MFs/vvTDfZ5v+x1QQ+Ze6X1cthEsImK5Im2waMdC8 SuYKMHc35Ue6WLcTTd0VF4OOyBARG4R4YRIj6ZekpyO8uc128R2RXz12LZ+xdwsIQtWZ BQxiY9/n+A6a5LLKz6150FmojZQO3XwWsZZSIS8SGw8cEdol4+HVR9BnVAcMxuzX5mrS ew== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3md3y73n6r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Dec 2022 01:38:35 +0000 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2BC1cMae014228; Mon, 12 Dec 2022 01:38:35 GMT Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3md3y73n67-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Dec 2022 01:38:35 +0000 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 2BBIViXH000725; Mon, 12 Dec 2022 01:38:33 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma02fra.de.ibm.com (PPS) with ESMTPS id 3mchr61cxk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Dec 2022 01:38:33 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2BC1cVTj37421372 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Dec 2022 01:38:31 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1A5A120043; Mon, 12 Dec 2022 01:38:31 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 07D4120040; Mon, 12 Dec 2022 01:38:30 +0000 (GMT) Received: from pike.rch.stglabs.ibm.com (unknown [9.5.12.127]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 12 Dec 2022 01:38:29 +0000 (GMT) From: Jiufu Guo To: gcc-patches@gcc.gnu.org Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, guojiufu@linux.ibm.com Subject: [PATCH V4 1/2] rs6000: use li;x?oris to build constant Date: Mon, 12 Dec 2022 09:38:28 +0800 Message-Id: <20221212013829.111739-1-guojiufu@linux.ibm.com> X-Mailer: git-send-email 2.17.1 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: -L_bpyrIYJStd93oyH6xkWX0PTuC2YUL X-Proofpoint-ORIG-GUID: UE6UkGS3cDzJZWWqnM4snMJADY0Tt2tM X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-10_10,2022-12-08_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 mlxscore=0 malwarescore=0 spamscore=0 impostorscore=0 phishscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212120013 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, For constant C: If '(c & 0xFFFFFFFF00008000ULL) == 0xFFFFFFFF00008000ULL' or say: 32(1) || 16(x) || 1(1) || 15(x), using "li; xoris" would be ok. If '(c & 0xFFFFFFFF80008000ULL) == 0x80000000ULL' or say: 32(0) || 1(1) || 15(x) || 1(0) || 15(x), we could use "li; oris" to build constant 'C'. Here N(M) means N continuous bit M, x for M means it is ok for either 1 or 0; '||' means concatenation. This patch update rs6000_emit_set_long_const to support those constants. Compare with previous version, this patch fixes conflicts with trunk. and put li;x?oris as the first patch (lis;xoris as the second patch). Previous version: https://gcc.gnu.org/pipermail/gcc-patches/2022-December/607618.html Bootstrap and regtest pass on ppc64{,le}. Is this ok for trunk? BR, Jeff (Jiufu) PR target/106708 gcc/ChangeLog: * config/rs6000/rs6000.cc (rs6000_emit_set_long_const): Add using "li; x?oris" to build constant. gcc/testsuite/ChangeLog: * gcc.target/powerpc/pr106708.c: New test. --- gcc/config/rs6000/rs6000.cc | 36 +++++++++++++++--- gcc/testsuite/gcc.target/powerpc/pr106708.c | 41 +++++++++++++++++++++ 2 files changed, 71 insertions(+), 6 deletions(-) create mode 100644 gcc/testsuite/gcc.target/powerpc/pr106708.c diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc index b3a609f3aa3..8c1192a10c8 100644 --- a/gcc/config/rs6000/rs6000.cc +++ b/gcc/config/rs6000/rs6000.cc @@ -10251,17 +10251,41 @@ rs6000_emit_set_long_const (rtx dest, HOST_WIDE_INT c) if (ud1 != 0) emit_move_insn (dest, gen_rtx_IOR (DImode, temp, GEN_INT (ud1))); } + else if (ud4 == 0xffff && ud3 == 0xffff && (ud1 & 0x8000)) + { + /* li; xoris */ + temp = !can_create_pseudo_p () ? dest : gen_reg_rtx (DImode); + emit_move_insn (temp, GEN_INT (sext_hwi (ud1, 16))); + emit_move_insn (dest, gen_rtx_XOR (DImode, temp, + GEN_INT ((ud2 ^ 0xffff) << 16))); + } else if (ud3 == 0 && ud4 == 0) { temp = !can_create_pseudo_p () ? dest : gen_reg_rtx (DImode); gcc_assert (ud2 & 0x8000); - emit_move_insn (temp, GEN_INT (sext_hwi (ud2 << 16, 32))); - if (ud1 != 0) - emit_move_insn (temp, gen_rtx_IOR (DImode, temp, GEN_INT (ud1))); - emit_move_insn (dest, - gen_rtx_ZERO_EXTEND (DImode, - gen_lowpart (SImode,temp))); + + if (ud1 == 0) + { + /* lis; rldicl */ + emit_move_insn (temp, GEN_INT (sext_hwi (ud2 << 16, 32))); + emit_move_insn (dest, + gen_rtx_AND (DImode, temp, GEN_INT (0xffffffff))); + } + else if (!(ud1 & 0x8000)) + { + /* li; oris */ + emit_move_insn (temp, GEN_INT (ud1)); + emit_move_insn (dest, + gen_rtx_IOR (DImode, temp, GEN_INT (ud2 << 16))); + } + else + { + emit_move_insn (temp, GEN_INT (sext_hwi (ud2 << 16, 32))); + emit_move_insn (temp, gen_rtx_IOR (DImode, temp, GEN_INT (ud1))); + emit_move_insn (dest, + gen_rtx_AND (DImode, temp, GEN_INT (0xffffffff))); + } } else if (ud1 == ud3 && ud2 == ud4) { diff --git a/gcc/testsuite/gcc.target/powerpc/pr106708.c b/gcc/testsuite/gcc.target/powerpc/pr106708.c new file mode 100644 index 00000000000..dc9ceda8367 --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/pr106708.c @@ -0,0 +1,41 @@ +/* PR target/106708 */ +/* { dg-do run } */ +/* { dg-options "-O2 -mno-prefixed -save-temps" } */ +/* { dg-require-effective-target has_arch_ppc64 } */ + +long long arr[] + = {0xffffffff7cdeab55LL, 0x98765432LL, 0xabcd0000LL}; + +void __attribute__ ((__noipa__)) lixoris (long long *arg) +{ + *arg = 0xffffffff7cdeab55LL; +} +/* { dg-final { scan-assembler-times {\mli .*,-21675\M} 1 } } */ +/* { dg-final { scan-assembler-times {\mxoris .*0x8321\M} 1 } } */ + +void __attribute__ ((__noipa__)) lioris (long long *arg) +{ + *arg = 0x98765432LL; +} +/* { dg-final { scan-assembler-times {\mli .*,21554\M} 1 } } */ +/* { dg-final { scan-assembler-times {\moris .*0x9876\M} 1 } } */ + +void __attribute__ ((__noipa__)) lisrldicl (long long *arg) +{ + *arg = 0xabcd0000LL; +} +/* { dg-final { scan-assembler-times {\mlis .*,0xabcd\M} 1 } } */ +/* { dg-final { scan-assembler-times {\mrldicl .*,0,32\M} 1 } } */ + +int +main () +{ + long long a[sizeof (arr) / sizeof (arr[0])]; + + lixoris (a); + lioris (a + 1); + lisrldicl (a + 2); + if (__builtin_memcmp (a, arr, sizeof (arr)) != 0) + __builtin_abort (); + return 0; +} -- 2.17.1