From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=dRgv=4L=kernel.crashing.org=segher@sourceware.org>
Received: from gate.crashing.org (gate.crashing.org [63.228.1.57])
	by sourceware.org (Postfix) with ESMTP id DA881383D5C0;
	Tue, 13 Dec 2022 13:52:03 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DA881383D5C0
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org
Received: from gate.crashing.org (localhost.localdomain [127.0.0.1])
	by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 2BDDp342014833;
	Tue, 13 Dec 2022 07:51:03 -0600
Received: (from segher@localhost)
	by gate.crashing.org (8.14.1/8.14.1/Submit) id 2BDDp2dD014832;
	Tue, 13 Dec 2022 07:51:02 -0600
X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f
Date: Tue, 13 Dec 2022 07:51:02 -0600
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Meissner <meissner@linux.ibm.com>,
        "Kewen.Lin" <linkw@linux.ibm.com>, gcc-patches@gcc.gnu.org,
        David Edelsohn <dje.gcc@gmail.com>,
        William Seurer <seurer@gcc.gnu.org>,
        Will Schmidt <will_schmidt@vnet.ibm.com>,
        Peter Bergner <bergner@linux.ibm.com>
Subject: Re: [PATCH 1/3] Rework 128-bit complex multiply and divide, PR target/107299
Message-ID: <20221213135102.GJ25951@gate.crashing.org>
References: <Y2HYSM7z8b5jDCZG@toto.the-meissners.org> <Y2HYqx4zLCNCT0Zy@toto.the-meissners.org> <997752a6-8cd4-abc5-d6e3-2e75eaa37d57@linux.ibm.com> <Y5A2YRAn8RvT0C5r@toto.the-meissners.org> <e415a48d-8e86-ff94-0066-8b7bbb7647dd@linux.ibm.com> <Y5JfVyZVdLL6NP9z@toto.the-meissners.org> <c24d634d-5969-a103-3482-ba546312863f@linux.ibm.com> <Y5gYTxjXv5z0fszk@toto.the-meissners.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y5gYTxjXv5z0fszk@toto.the-meissners.org>
User-Agent: Mutt/1.4.2.3i
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_MANYTO,KAM_NUMSUBJECT,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Tue, Dec 13, 2022 at 01:14:39AM -0500, Michael Meissner wrote:
> On Mon, Dec 12, 2022 at 06:20:14PM +0800, Kewen.Lin wrote:
> > Without or with patch #1, the below ICE in libgcc exists, the ICE should have
> > nothing to do with the special handling for building_libgcc in patch #1.  I
> > think patch #2 which makes _Float128 and __float128 use the same internal
> > type fixes that ICE.
> > 
> > I still don't get the point why we need the special handling for building_libgcc,
> > I also tested on top of patch #1 and #2 w/ and w/o the special handling for
> > building_libgcc, both bootstrapped and regress-tested.
> > 
> > Could you have a double check?
> 
> As long as patch #2 and #3 are installed, we don't need the special handling
> for building_libgcc.  Good catch.
> 
> I will send out a replacement patch for it.

Please send a complete new series replacing this one.  Thanks.


Segher