From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id C359F38493D1; Fri, 16 Dec 2022 21:13:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C359F38493D1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 2BGLCIc6030529; Fri, 16 Dec 2022 15:12:18 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 2BGLCHgK030528; Fri, 16 Dec 2022 15:12:17 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Fri, 16 Dec 2022 15:12:17 -0600 From: Segher Boessenkool To: "Kewen.Lin" Cc: Jiufu Guo , dje.gcc@gmail.com, linkw@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH V4 1/2] rs6000: use li;x?oris to build constant Message-ID: <20221216211217.GH25951@gate.crashing.org> References: <20221212013829.111739-1-guojiufu@linux.ibm.com> <7fe25875-8301-2ebd-cbd2-4eb496b6c4ae@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7fe25875-8301-2ebd-cbd2-4eb496b6c4ae@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Dec 14, 2022 at 06:27:57PM +0800, Kewen.Lin wrote: > > +void __attribute__ ((__noipa__)) lixoris (long long *arg) > > Nit: Adding separator "_" to make the name like "li_xoris" or even > "test_li_xoris" seems better to read. Also applied for the other > function names "lioris" and "lisrldicl". Ha yes, that last one is a bit impregnable like this. It is testsuite so everything goes of course, but :-) Segher