From: juzhe.zhong@rivai.ai
To: gcc-patches@gcc.gnu.org
Cc: kito.cheng@gmail.com, palmer@dabbelt.com, jeffreyalaw@gmail.com,
Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
Subject: [PATCH] RISC-V: Fix incorrect annotation
Date: Tue, 20 Dec 2022 07:13:54 +0800 [thread overview]
Message-ID: <20221219231354.135626-1-juzhe.zhong@rivai.ai> (raw)
From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
gcc/ChangeLog:
* config/riscv/riscv-vsetvl.cc (anticipatable_occurrence_p): Fix incorrect annotations.
(available_occurrence_p): Ditto.
(backward_propagate_worthwhile_p): Ditto.
(can_backward_propagate_p): Ditto.
---
gcc/config/riscv/riscv-vsetvl.cc | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/gcc/config/riscv/riscv-vsetvl.cc b/gcc/config/riscv/riscv-vsetvl.cc
index 0c2ff630e96..72f1e4059ab 100644
--- a/gcc/config/riscv/riscv-vsetvl.cc
+++ b/gcc/config/riscv/riscv-vsetvl.cc
@@ -186,7 +186,7 @@ anticipatable_occurrence_p (const insn_info *insn, const vector_insn_info dem)
/* The only possible operand we care of VSETVL is AVL. */
if (dem.has_avl_reg ())
{
- /* The operands shoule not be modified in the basic block prior
+ /* The operands should not be modified in the basic block prior
to the occurrence. */
if (!vlmax_avl_p (dem.get_avl ()))
{
@@ -223,7 +223,7 @@ available_occurrence_p (const insn_info *insn, const vector_insn_info dem)
/* The only possible operand we care of VSETVL is AVL. */
if (dem.has_avl_reg ())
{
- /* The operands shoule not be modified in the basic block prior
+ /* The operands should not be modified in the basic block prior
to the occurrence.
e.g.
bb:
@@ -284,7 +284,7 @@ backward_propagate_worthwhile_p (const basic_block cfg_bb,
|_________|
reaching_out
Header is incompatible with reaching_out and the block is loop itself,
- we don't backward propagete the local_dem since we can't avoid emit
+ we don't backward propagate the local_dem since we can't avoid emit
vsetvl for the local_dem. */
edge e;
edge_iterator ei;
@@ -334,10 +334,10 @@ can_backward_propagate_p (const function_info *ssa, const basic_block cfg_bb,
insn_info *insn = prop.get_insn ();
/* TODO: We don't backward propagate the explict VSETVL here
- since we will change vsetvl and vsetvlmax intrinsiscs into
- no side effects which can be optimized into optimzal location
- by GCC internal PASSes. We only need to support these backward
- propagation if vsetvl instrinsics have side effects. */
+ since we will change vsetvl and vsetvlmax intrinsics into
+ no side effects which can be optimized into optimal location
+ by GCC internal passes. We only need to support these backward
+ propagation if vsetvl intrinsics have side effects. */
if (vsetvl_insn_p (insn->rtl ()))
return false;
@@ -369,7 +369,7 @@ can_backward_propagate_p (const function_info *ssa, const basic_block cfg_bb,
def_info *def = find_access (insn->uses (), REGNO (reg))->def ();
/* If the definition is in the current block, we can't propagate it
- acrocss blocks. */
+ across blocks. */
if (def->bb ()->cfg_bb ()->index == insn->bb ()->cfg_bb ()->index)
{
set_info *set = safe_dyn_cast<set_info *> (def);
@@ -406,7 +406,7 @@ can_backward_propagate_p (const function_info *ssa, const basic_block cfg_bb,
if (def->bb ()->cfg_bb ()->index == cfg_bb->index)
return true;
- /* Make sure we don't backward propagete the VL/VTYPE info over the
+ /* Make sure we don't backward propagate the VL/VTYPE info over the
definition blocks. */
bool visited_p = false;
for (const bb_info *bb : ssa->reverse_bbs ())
--
2.36.1
next reply other threads:[~2022-12-19 23:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 23:13 juzhe.zhong [this message]
2022-12-20 0:28 ` Jeff Law
[not found] ` <36D1C05330B9612D+065D340F-26F5-4844-8ACE-EA8091A41E6A@rivai.ai>
2022-12-20 16:02 ` Jeff Law
2022-12-20 16:06 ` Palmer Dabbelt
2022-12-20 16:15 ` Jeff Law
2022-12-20 23:33 ` 钟居哲
2022-12-20 23:38 ` Palmer Dabbelt
2022-12-23 5:47 ` Kito Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221219231354.135626-1-juzhe.zhong@rivai.ai \
--to=juzhe.zhong@rivai.ai \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=kito.cheng@gmail.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).