Re: [PATCH v6, rs6000] Change mode and insn condition for VSX scalar extract/insert instructions

[Segher Boessenkool <segher@kernel.crashing.org>]

Hi!

On Mon, Dec 19, 2022 at 02:27:57PM +0800, HAO CHEN GUI wrote:
>     This patch fixes several problems:
>     1. The exponent of double-precision can be put into a SImode register.
>     So "xsxexpdp" doesn't require 64-bit environment. Also "xsxsigdp",
>     "xsiexpdp" and "xsiexpdpf" can put exponent into a GPR register.
> 
>     2. "TARGET_64BIT" check in insn conditions should be replaced with
>     "TARGET_POWERPC64" check.
> 
>     3. "lp64" check in test cases should be replaced with "has_arch_ppc64"
>     check. "ilp32" check should be replaced with "dg-skip-if has_arch_ppc64".

These things are independent.  Please do independent patches (a series
is fine and even preferred, of course).  Not only is this much harder to
review the way it is, it was harder to write as well, write changelog
for, etc.  Often when you prepare patches it becomes apparent that you
should have structured things a bit differently.  That is a good time to
do exactly so :-)

>     This patch keeps outer interfaces of these builtins unchanged.

Of course.  This patch doesn't edit any builtins, it changes only the
machine description.  "Of the corresponding builtins" :-)


Segher