From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2109.outbound.protection.outlook.com [40.107.20.109]) by sourceware.org (Postfix) with ESMTPS id 5BB123858023 for ; Wed, 21 Dec 2022 13:12:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5BB123858023 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=syrmia.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Syrmia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SdBdw3gBJVT6BPvyo/8slGYtEw4qy6RXYlDTprZbYD7ulY8Q/aaJbie9ywiLPxEZgSFe2a2gW1khKYqPkqAOGzxwiKI7TmnHbz5HJaX/lijiYpy2/WH42oIj9UPhYUc8VzpvDFc+WcGX8imcjEGu1tu8/r75cAVLo2sX51LLDoedqfZAUIGLLDbedHIODOpsUB1eoJXyNB9Cah+Z2h8vt8QFFzWmwKhEyJbwFJruhPq+fYkJDcXZAHtPNsuxae75Cto3RhoffZNLl0A0WYD0Duosu+eV4t0IJPGVYToJZbFjdpvELtp03i1SF4HvBJPg3fCNsXw5xuNaWtgk2XZhtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dAx1c6qUlxr/5s1+ekYV/vv3cdWGc6DmHOhSIj/6sns=; b=Ctl+eDLSzvUWjlOjzX0l1o6HKwr9AN/sqIXU6KfGZhok+oVTp0WJ4+ES6RMbmeNZ9ih6df8LpuKYsXKIphSaMjvF4CPIJfj6WEWsQex7u0f0YY4ApjFDqyBeVDFMRSYetwz4n9/hY8FbF9ES2dEFvKZUX0oZT5kOFZjsYk2916MHq2dZy1cpTpnP/BCJ/nOdcswPwNWG+U28ea8EPVR02TCavvokjbEZwtbdpi06TgJm3XeBYvtd7unKFDdrW9mhYwFvS6APqufFLkOxVT38jRFvvTtnp49vV4OSSyCUkirvrj5zm9o75hBkty3x1i7xmQRu6/gUwjfLIvN/4nlUiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=syrmia.com; dmarc=pass action=none header.from=syrmia.com; dkim=pass header.d=syrmia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syrmia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dAx1c6qUlxr/5s1+ekYV/vv3cdWGc6DmHOhSIj/6sns=; b=GXwHfugatyN6uEmNrKZdDrrJy4Gt6Aaw5oNxSWw4eUBlPVFT5W9atrTA7BFHTq2BoddIMSaS13l92hECodXv86cWK/3xRLTL3uPytofrnH0Ksipa04hdvayoujHdrHAx9nO3m5klWWC+IPfUjsAKBjyeT3R6UVuZnTu2DRy2Vco= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=syrmia.com; Received: from AM0PR03MB4882.eurprd03.prod.outlook.com (2603:10a6:208:fb::17) by PAXPR03MB8225.eurprd03.prod.outlook.com (2603:10a6:102:24c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 13:12:40 +0000 Received: from AM0PR03MB4882.eurprd03.prod.outlook.com ([fe80::6d55:c3be:1328:429b]) by AM0PR03MB4882.eurprd03.prod.outlook.com ([fe80::6d55:c3be:1328:429b%7]) with mapi id 15.20.5924.016; Wed, 21 Dec 2022 13:12:40 +0000 From: =?UTF-8?q?Dimitrije=20Milo=C5=A1evi=C4=87?= To: gcc-patches@gcc.gnu.org Cc: djordje.todorovic@syrmia.com, richard.guenther@gmail.com, jeffreyalaw@gmail.com, =?UTF-8?q?Dimitrije=20Milo=C5=A1evi=C4=87?= Subject: [PATCH 1/2] ivopts: Compute complexity for unsupported addressing modes. Date: Wed, 21 Dec 2022 14:12:13 +0100 Message-Id: <20221221131214.190579-2-dimitrije.milosevic@syrmia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221221131214.190579-1-dimitrije.milosevic@syrmia.com> References: <20221221131214.190579-1-dimitrije.milosevic@syrmia.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: VI1PR0102CA0022.eurprd01.prod.exchangelabs.com (2603:10a6:802::35) To AM0PR03MB4882.eurprd03.prod.outlook.com (2603:10a6:208:fb::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR03MB4882:EE_|PAXPR03MB8225:EE_ X-MS-Office365-Filtering-Correlation-Id: e0595547-c33e-463b-d9bd-08dae35509a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +/aBNWoHQHO5SyQhVW0IU3Z7LlRAIIRDJxpKC0yeS/2J7C1muWXBcZNOc838ZAwC7gYxJ1/mw9KROCegqxwlsck3FGBhK/kBZ/0qGo7Rx4Kefk1M70/bnt9HKjtJtPwEGRAXvsrh/9gZ+VhBr6NrX9KR4cWL1HYh2f+gU0mCgZ3L0ubcx4XZipTr2T5Ns69z7lN4IIVP5b5ClEd1YlVVT4IDy4lVn8bsC0b4a5qhYtci+3JeHmH8DZgqQBlUJoUV5PbZv2vryw4OphB2BdZeWj4Qiu0sdI/4++pYaoTbjMb0mZahzcd6+m4WCw1nlPGSU7/L/mVeYFiuz9kZy7+1O9jSddJGCAuawFtVnIraiCwlVG7z1fGAsN3l+Nqt+qlmeA/SEeL+q3Q8rOprGU0Fx1PdcZIDC1mIWZLDg4VVOmuOgjbkIaUz3B0cIlnoGP9jigVU5esw/5ItZnNQ7NW0dlgBT4UM40d/lTOycjxEZBQUxLX+d7wKP/bvlWWp6zKndw11kpN4B3WOgDdRwox5C8TkV6gEjv4Jiftglz6K2ZhSseAYen72HEFrzz+n7Y+IuU8A7TaDssyInKDjUb5elazIajKcirroEsE2UAD9y2i6dFOOt/xQ0i1busEbGIcJI0jiFMbASiOEPBQuGfosMgG7C7o4IUQFQ9MtbxDGFmw1ANch0aKTV4O0k0B7LtIH44XUZUEkI1dNMLN1HFtJXw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB4882.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39840400004)(366004)(136003)(376002)(346002)(451199015)(2906002)(38350700002)(36756003)(38100700002)(86362001)(478600001)(107886003)(6666004)(6916009)(316002)(83380400001)(5660300002)(2616005)(6486002)(1076003)(6512007)(26005)(8676002)(52116002)(66476007)(66946007)(4326008)(66556008)(186003)(41300700001)(8936002)(6506007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CmWVZbFCWuIvG4xsJVMcVf8NTR25MObU8oHR7ScSUrL63UWEpses0/P54JXH?= =?us-ascii?Q?BmMj+BvPu3gN7Yb57vkExKc+fWvKB5JsZwYHHQOVEcS27SX0xCaaBDACUhFu?= =?us-ascii?Q?9satNjD3uoDcL0tu5j9VtSC1YehKkfYgiWtmpt0NlU7aZvI/0W4+BIJvJ3s6?= =?us-ascii?Q?Q0OLLF5ZQu4tZDRXVHvdos+s8KPFkubyIoaqLYr56MwlVcAKNrSDhlqERxfX?= =?us-ascii?Q?AiE8QpEbOF/LfDl8aJRSCTT4ks7CJogjnfVotj96BNvSr5jqfufyD84yS7ee?= =?us-ascii?Q?H7dI7pDMctUL8y9aeetuysho/8spcvnf2pOfOqRAM16SugUnK61YsVHEgXsw?= =?us-ascii?Q?G2FSzz/mQp9zYJezWtmBQ3jZs1Sf0wDRtydO6eDpMLMoKK8T72K88VcKxc0D?= =?us-ascii?Q?U6Et0lPvbeMDX6YEDdC0BfDNYAiB6EiOcvmWq0VHDSirCcx3RB2Dt1iqiJVw?= =?us-ascii?Q?X/EgTViOchbgM93iHfy6xjoNsgsfZs3DuqdL441Ax5M5vejgqlTdvvIoJ3az?= =?us-ascii?Q?A0SIwNyPZVAM8nJuGJYwUrJEk91WpnQNn/m1aD4ksQnDyBL3TJf/rwrcWTVY?= =?us-ascii?Q?fDwWrnZz80ad06vEb5qIICeQZw//mEF9siNTDc/pU/RjYvFRj9vYtcysLasU?= =?us-ascii?Q?FsghP/1LJPGPaQwpnrb4NCqwItjSJ59bVpNwEE5mO5ovahUdzpbuYD8qxcxe?= =?us-ascii?Q?j+C9jX4XY4b2ZLzRvZ3B6u+aSRhXDMky+ohjq/Tt/OczWriwTLZqZ/RyfDaR?= =?us-ascii?Q?7POow/WH3l9BP3Wp8VWIDDbx2AoSSEYkyurAvIfvZ5nWMwlJ11OV6OdxEIt5?= =?us-ascii?Q?edDZ9nIbm3geBuviCmmuO4ivGvUP7kJR4u44QWEWIKB1CgwAEB0b4xyZBH3S?= =?us-ascii?Q?n3AQqmX+vGumPQKSOka5ElDglusne5Co+XrXrUa27L1Ss4ejN+iqnzPQdaCS?= =?us-ascii?Q?EgstydoYeejJdrL91EF81k1ninKPUH7VtU1pbqfFwPpJnRH/j17IcjyCjbUz?= =?us-ascii?Q?SWEdDUoTHBTxuQBjUSoAr2K9SJffDAiDmR5V1SmRbueA58RNFJaqmOt2XIU+?= =?us-ascii?Q?pr2nCnmS2Yl3VLCe0ofaWNBZmOY4D+SOuDFocfH7TKn4wSUaG+CdNIw9nHO+?= =?us-ascii?Q?Uf0taK6bjJ/0AF/lE97aUSLxD+7FkrXWo6O9dRvymBosgoPANbgbCjADlCJy?= =?us-ascii?Q?hndK2K13xPY/l4C7yd/L1Ao54hFyenc9e2w6B0//mSBigJ3LkkxgdZLcliJw?= =?us-ascii?Q?J3iX8wuPNZ0f/MSfXOLPZl8XxBbe+FvWcwXCAsAhIvYnj9SQh+WyRtAdwx5p?= =?us-ascii?Q?4XALy9ytNRQbgkF8oVAFXyhnXROgqWwOCGDyxWzctNwFSDrj6DzZlRgv3Y86?= =?us-ascii?Q?btvIQ+WFlsxSKNxRD5+GtrBbF4WB/ep3ENGgvAofeQ29UqoGqUGFr9qodL5S?= =?us-ascii?Q?hWCUrxFQCKJdBqu22T2Y/F1f9AGbOe8SgvBYIt25GleNJeT/0umQaf7+KuhG?= =?us-ascii?Q?S9moQcxQYMa3AIfI7rzTeZzbW8O/qdsyOIApjV43uqX2XKhOTSQygnhdKZjY?= =?us-ascii?Q?vNnz9xwoWBgFG9sAeGDsj8+D6uyLxriL1/8bN25iTYoPWym20juuC0tmXpE+?= =?us-ascii?Q?8mIhdH9HeJw5OaoGzN7wH3Q=3D?= X-OriginatorOrg: syrmia.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0595547-c33e-463b-d9bd-08dae35509a0 X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB4882.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 13:12:40.0858 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 19214a73-c1ab-4e19-8f59-14bdcb09a66e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5eLbKYms5Z7kvaaX11NuETb5LLTdMSs3OP783y7qEsIGwmKPm8qJbbu2JVfggYG+o0RyDgtFJHskM1qOZMpeIZW48W1EZMi+pp2Tn5G54AU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB8225 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: After f9f69dd, complexity is calculated using the valid_mem_ref_p target hook. Architectures like Mips only allow BASE + OFFSET addressing modes, which in turn prevents the calculation of complexity for other addressing modes, resulting in non-optimal candidate selection. There still is code that adjusts the address cost for unsupported addressing modes, however, it only adjusts the cost part (the complexity part is left at 0). gcc/ChangeLog: * tree-ssa-loop-ivopts.cc (get_address_cost): Calculate complexity for unsupported addressing modes as well. Signed-off-by: Dimitrije Milosevic --- gcc/tree-ssa-loop-ivopts.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gcc/tree-ssa-loop-ivopts.cc b/gcc/tree-ssa-loop-ivopts.cc index ebd4aecce37..60c61dc9e49 100644 --- a/gcc/tree-ssa-loop-ivopts.cc +++ b/gcc/tree-ssa-loop-ivopts.cc @@ -4778,10 +4778,14 @@ get_address_cost (struct ivopts_data *data, struct iv_use *use, comp_inv = aff_combination_to_tree (aff_inv); if (comp_inv != NULL_TREE) cost = force_var_cost (data, comp_inv, inv_vars); - if (ratio != 1 && parts.step == NULL_TREE) + if (ratio != 1 && parts.step == NULL_TREE) { var_cost += mult_by_coeff_cost (ratio, addr_mode, speed); - if (comp_inv != NULL_TREE && parts.index == NULL_TREE) + var_cost.complexity += 1; + } + if (comp_inv != NULL_TREE && parts.index == NULL_TREE) { var_cost += add_cost (speed, addr_mode); + var_cost.complexity += 1; + } if (comp_inv && inv_expr && !simple_inv) { -- 2.25.1