From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id DE1E03858425 for ; Thu, 22 Dec 2022 17:28:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DE1E03858425 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BMFfOif004987 for ; Thu, 22 Dec 2022 17:28:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : content-type : mime-version; s=corp-2022-7-12; bh=Tz45n0Q6jZgM6SMBjkKuDALIoZ7wqIzJpFFRGZ1dTc8=; b=zQsGryFU7MKhiOC0Y9GrST5G/67yqJv+KY3ddQMdKBGmNYJRIa0lV3cDiLb5uP+pPiGk dL32Mo2EeWmA/COkCJTy28LFSMRhMMivwKi1ObWZxVif5lcRz5H+GGX94/0735lYpklC WDDHSxQFSWDi2lvNU02OXgxMONwE2fp164/kImmbdsKbrBlVqRryqRMdSAu3LdkR4fKX vigTloSIYSg+dF9Ks3FHIzqAFQKER4juAba2tukFWK390OXZ+lN87z4hwX09JIMbBrU6 zyU3HUDm0XhDYCkJRdtmvY6HAcaw1vKMce1fYdKObTg2NHZgklovvbDcHj/VCPl0u9NY mw== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3mh6tpv7bt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 22 Dec 2022 17:28:05 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2BMFdiQ2003115 for ; Thu, 22 Dec 2022 17:28:04 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2106.outbound.protection.outlook.com [104.47.58.106]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3mh47875v6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 22 Dec 2022 17:28:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TwtNhhGgAJYzfQWkohL3k7+z7e9r2CiVmrgRocW3jioWdzbdpAbzjMaOuskuSaxJaWo9VpQ++SCn1y5GTuYvpVcyUgEadp0i3y3EYz0RC5v575ASv+KGz+PO3oSg8c66PtbibLybICafnusdBVAEXeQv0lJABZoBsu0Iftbqsq+TRl5UkMU3MYjptOoVpHrzpOU3iIr57b1miOBtK0WXDZf9CspirsBY3/qbCsQOqqEbqztP7tw+NE0R9Q6eGp9aKs6PDbnkpq5mIcRl3ciYRrQjZhZRFhSdnCeE0xmk1zy5P3WoeGL5vAecHDDMRoRsxb0p1N1iIcloyRR0hgldcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tz45n0Q6jZgM6SMBjkKuDALIoZ7wqIzJpFFRGZ1dTc8=; b=fg66/9DWURl0hI8KYJv04lCKo5JNod9WIVD3bXAsZfwNhmN5WkI1ntY7QetoNHsW/qMCsrAhpiv/07uTdCprv/L2sB/1htTyGRHOmtw1Sc0DdpkKdKZPdxkaHvv28xdlxyOxZx0XqfetL4LEskvlXgaCkcFckxK9LbR/V2PEBcrZ0QFgQzmdd/l+YZ0g/5ROqkcaWX8dN9zE6T0xvC4apZJ9Ip32T+tbaQOKIsfzXgmnrwf9p3AeOWTvRcpY5m5N0L3lzpB/803KIET5tBmBjliXgVGHXejMz+RweK9uQVKCKAVkpKCWwywQZzRUom0iz3gMr/yjfLWpERP9hMPsbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tz45n0Q6jZgM6SMBjkKuDALIoZ7wqIzJpFFRGZ1dTc8=; b=vI2AWwjVvhcGVky/77RJchmg5+Z1IuuqtlaBkj1OX1wDx4hSSHUFnEDaeCf/iDehX9dnxDx7olnmrgcZNPhU//sjl8g9w6InQs53Pn07uozO5aOxMDSkaXfa2uFxmz1ifXH0GggHHr1m1nhX25JUcGsoDGpcyC1w/Fu1v6rAZAY= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by SN7PR10MB6285.namprd10.prod.outlook.com (2603:10b6:806:26f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Thu, 22 Dec 2022 17:28:03 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::ebe9:b7c9:82ae:d256]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::ebe9:b7c9:82ae:d256%7]) with mapi id 15.20.5924.016; Thu, 22 Dec 2022 17:28:03 +0000 From: "Jose E. Marchesi" To: gcc-patches@gcc.gnu.org Cc: qing.zhao@oracle.com Subject: [PATCH V2] Disable sched1 in functions that call setjmp Date: Thu, 22 Dec 2022 18:32:08 +0100 Message-Id: <20221222173208.13317-1-jose.marchesi@oracle.com> X-Mailer: git-send-email 2.30.2 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: LO4P265CA0013.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::9) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|SN7PR10MB6285:EE_ X-MS-Office365-Filtering-Correlation-Id: 7434c99e-21cc-4409-9962-08dae441e11d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Wz7qgN9tDvSdrggAhxW1j/QCEVCe3bLG13agim4lFHQaFsHnD++1leFj4+cfL0wjRH+LuUr7NHr5yprvYckposOP22RXbSpxpUMm3ohhlakacK/0qwnFBmU3SMAhNC3gCgwMnE5LQ4D8GZS1h00ABOqcsgaQjxA6Uzc24KpT9FHJA6DRfpuaP7rIaSLRNpXKgI5u+APjnHwUr1B/MYo9rnNrq3+BvClERIonKooLjysqQCNitGPGCASqH7Dlm/SQCPQzIbO8Nj7/yIfdFj/r/FvtB9TOtcIuGFiurckTqaOG92BFiymCAA3BrrCrePMz83X0L0px7QRugy7L0LaTQ79Z/otY3MVKiz0g7lKJq8bFfArqTWjKMQoovYkp1NUqGptRG2vv0GheUM7o0f0rGtShcGZDiRZPX5QKnxttoD8AxV10vb0WHo7QEQzJI5H7Q/aQ+Uu0nZvbzSjea/DRAcePRukHMd7jetwZ5BvZHlCYzOGHlobeKCjAOOprMGL1TO7zpWbz5690Annuq5+IOf/kDb4ySaIi7OWIeSiyWV+vExzudVSVSuHZLkQBtdbvlNKEQ3rI5lA2VnsSZBD4XY2MgtUEJff8r96Rvo7tNxd+FmCuoH4YYtvTfZ8B6+WG0DVrMAPnAdnjn4MozaT0Uw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(39860400002)(136003)(366004)(346002)(451199015)(36756003)(2906002)(6916009)(316002)(6486002)(83380400001)(478600001)(6506007)(86362001)(107886003)(1076003)(2616005)(186003)(26005)(6512007)(8936002)(38100700002)(41300700001)(66476007)(66946007)(5660300002)(8676002)(66556008)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7hYB35tjzbsEW9rdnYf7XXkG5PTjNMKXFcoEbtrMzuEqY9ZS2kyB/kAT10yC?= =?us-ascii?Q?/gR5vYhvVh0eQSgiBiKNkf78WvbgArmJQpVNf9yB+sK6sVFeNxI0rjS0bafR?= =?us-ascii?Q?FX7u5sloSBzvP4nH0Y6vML9tsbSOtGTKkUVwfFrE6jteTWOEfeDzUsxUb8Gm?= =?us-ascii?Q?RDMDWLJLR0KJipyUcNeiCijvg2EKuPztfcpyVNZEyDK0dmC6YdRjK8tk3daU?= =?us-ascii?Q?lM0YNB4tlXb3iM9moPGw0/pdq9D9dsd60tZVrIRDyNOP9lg9K7IcEpZvrstw?= =?us-ascii?Q?IPwsNTgvrz5tCTd8iW4mhIA2tWN9OU0dIKNh5FWkMqg9kk2ZBISYXITj4UEg?= =?us-ascii?Q?IVnPhHSsDKH2i4ytmfGhOsWtbmSO0zN1OFlxZbjRgDdwnUStqYXD2HGY4nwM?= =?us-ascii?Q?7+57LwI9y3BzbOA5leX84ciK84Hd6Z9t7AWXvpYWV/9P4CE24DDGJhgdeLTV?= =?us-ascii?Q?tsOxaFreRAToag7ffsYB19JBAb10Wcgl85dJJJRPOMBFWX+evCGo30GCWy7u?= =?us-ascii?Q?3BLkUjDHQ0d2pLx/rKFxH8Muhcv7squwXXESorivksImPC4EHYf/RJWNce8/?= =?us-ascii?Q?y/BM0nHPRCoryBFj+KUb1ItIRzpu9CMElE4MxGC6XTOF+reyCA6D4Mwl3RQD?= =?us-ascii?Q?nMzEBxfeCZWIe7r25a4zfC0vDmcR4aXgpzm9O2nGzVYeXj8uw55XQkK8B2C6?= =?us-ascii?Q?DRSj61Tc+s5yFKleTDOID8sfC8qXgJJYel5oQSV1CFVe5PwwYvkSGEFFJEth?= =?us-ascii?Q?ikBZnAGT61ArBkQ9TKDHZJ+wCxXHFK9CJossNqS6XNmAJeQb3/omxBoGn4vL?= =?us-ascii?Q?kSx7UiBgwjO52BkYLnFNedjmvCz0nLnbEbDUdRbO1tXxlToAFGzV/XxUIE4T?= =?us-ascii?Q?d4rFp6R5azzvXMsS2ECtfR39Exkwwl7qrSw8dptucZTozzIolDQdAHj5IJ0u?= =?us-ascii?Q?HBcgJ2p1p2TII88kMsja03J3MLoeRVSbHQOm76zuwV13lswi1dT7Ve0MMrSM?= =?us-ascii?Q?H+DkRNChRne28H0KvxUmiaON2gSIkrKIDmgtmBMm5HKW/vFuv3gzz8wPUjAb?= =?us-ascii?Q?ucSRmS0CpATmjPh3viwrM0mnPV4XmkVslaDJNe6ENfADuzn4EYBIOtG0QQuj?= =?us-ascii?Q?CVWfMEQd8+YRIxuMY1w/xI6Jd+7+/qXFUi2nkmDRYPHqLUdKpEa5IBcR6ers?= =?us-ascii?Q?HQ+tddA8nbIO7Dpt5MFislDq8MXWSpZU8z+ilevNbByC1qIF8GvKgoGEPH8M?= =?us-ascii?Q?jVsrx+bJWRbfY5DTFjQnolxrtqHv81Gf1wl5TAs0QmsOMIoOQOlc8kpousFh?= =?us-ascii?Q?BSkD5vAJ9/PwYr0Nn/hnOkvnK43QnHgwJVDdtbG4JetozHldNCT9mH+0fGPY?= =?us-ascii?Q?01umE2d7RAcM3nFlPHVM6y1Mb3yxZ1bZrD9HUq3Z48+86I1MMfvLp40JPQcV?= =?us-ascii?Q?sqX5TExJ6H5iq39V2DMaClV79qRgMF7HMLlWmboWeH7TGJdEU8t6Lqmaiev9?= =?us-ascii?Q?BhMrwFRe56KAWungKa/Hj8Wgdh3JKpxtGvPhqoiPwK+IE5Z4dT8CQ2Vd1mA7?= =?us-ascii?Q?2gs625xHe2KJ/Ikd9MC+vhSoReadYZeImflY7M1Kzoq1pEqBW2abEoPVgVgI?= =?us-ascii?Q?YQ=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7434c99e-21cc-4409-9962-08dae441e11d X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2022 17:28:02.9510 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SOJf6YinRxyipxhAp08Uijg2Ofygtco5eZCtW1XT8q+mSXldvtQwV3dbUfutprVoeKGRJqKdiD/hVxaCkB+3ux89E6dlixOd7JsvYCfPVtQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6285 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-22_09,2022-12-22_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=733 spamscore=0 phishscore=0 adultscore=0 bulkscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212220149 X-Proofpoint-ORIG-GUID: gsSWF5aJ52ZMIOM6G41AFcqVbTwlx_mi X-Proofpoint-GUID: gsSWF5aJ52ZMIOM6G41AFcqVbTwlx_mi X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When the following testcase is built with -fschedule-insns in either x86_64 or aarch64: #include #include #include jmp_buf ex_buf__; #define TRY do{ if( !setjmp(ex_buf__) ){ #define CATCH } else { #define ETRY } }while(0) #define THROW longjmp(ex_buf__, 1) int f(int x) { int arr[] = {1,2,6,8,9,10}; int lo=0; int hi=5; while(lo<=hi) { int mid=(lo+hi)/2; if(arr[mid]==x) { THROW; } else if(arr[mid]x) { hi=mid-1; } } return -1; } int main(int argc, char** argv) { int a=2; bool b=false; TRY { a=f(a); b=true; } CATCH { printf("a : %d\n",a); printf("Got Exception!\n"); } ETRY; if(b) { printf("b is true!\n"); } return 0; } The first instruction scheduler pass reorders instructions in the TRY block in a way `b=true' gets executed before the call to the function `f'. This optimization is wrong, because `main' calls setjmp and `f' is known to call longjmp. As discussed in BZ 57067, the root cause for this is the fact that setjmp is not properly modeled in RTL, and therefore the backend passes have no normalized way to handle this situation. As Alexander Monakov noted in the BZ, many RTL passes refuse to touch functions that call setjmp. This includes for example gcse, store_motion and cprop. This patch adds the sched1 pass to that list. Note that the other instruction scheduling passes are still allowed to run on these functions, since they reorder instructions within basic blocks, and therefore they cannot cross function calls. This doesn't fix the fundamental issue, but at least assures that sched1 wont perform invalid transformation in correct C programs. regtested in aarch64-linux-gnu. gcc/ChangeLog: PR rtl-optimization/57067 * sched-rgn.cc (pass_sched::gate): Disable pass if current function calls setjmp. --- gcc/sched-rgn.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/sched-rgn.cc b/gcc/sched-rgn.cc index 420c45dffb4..c536d0b8dea 100644 --- a/gcc/sched-rgn.cc +++ b/gcc/sched-rgn.cc @@ -3847,7 +3847,8 @@ bool pass_sched::gate (function *) { #ifdef INSN_SCHEDULING - return optimize > 0 && flag_schedule_insns && dbg_cnt (sched_func); + return optimize > 0 && flag_schedule_insns + && !cfun->calls_setjmp && dbg_cnt (sched_func); #else return 0; #endif -- 2.30.2