public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Arnaud Charlet <charlet@adacore.com>
To: Iain Sandoe <iain@sandoe.co.uk>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
	Arnaud Charlet <charlet@adacore.com>
Subject: Re: [PATCH] Ada, Darwin: Do not link libgcc statically on Darwin [PR108202].
Date: Mon, 2 Jan 2023 08:42:26 +0000	[thread overview]
Message-ID: <20230102084226.GA14955@adacore.com> (raw)
In-Reply-To: <596AC0EB-D5B0-412F-9D10-CB2F370B3EB7@sandoe.co.uk>

> I would like to revise this patch to be more conservative (only applying to Darwin 8 and 9).

This is OK, thanks (and Happy New Year!)

> > On 24 Dec 2022, at 19:00, Iain Sandoe via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
> > 
> > Tested on i686, x86-64 darwin, x86_64-linux (with a 32b multilib).
> > OK for trunk?
> > Iain
> 
> revised:
> 
> [PATCH] Ada,Darwin: Do not link libgcc statically on Darwin 8 and 9  [PR108202].
> 
> Normally, GCC executables are built with -static-libstdc++ -static-libgcc
> on Darwin.  This is fine in most cases, because GCC executables typically
> do not use exceptions.   However gnat1 does use exceptions and also pulls
> in system libraries that are linked against the installed shared libgcc
> which contains the system unwinder.  This means that gnat1 effectively has
> two unwinder instances (which does not work reliably since the unwinders
> have global state).
> 
> A recent change in the initialization of FDEs has made this a hard error
> now on Darwin versions (8 and 9) with libgcc installed in /usr/lib (gnat1
> now hangs when an exception is thrown).
> 
> The solution is to link libgcc dynamically, picking up the installed
> system version.  To do this we strip -static-libgcc from the link flags.
> 
> 	PR ada/108202
> 
> gcc/ada/ChangeLog:
> 
> 	* gcc-interface/Make-lang.in (GCC_LINKERFLAGS, GCC_LDFLAGS):
> 	Versions of ALL_LINKERFLAGS, LDFLAGS with -Werror and
> 	-static-libgcc filtered out for Darwin8 and 9 (-Werror is filtered
> 	out for other hosts).

      reply	other threads:[~2023-01-02  8:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-24 19:00 [PATCH] Ada,Darwin: " Iain Sandoe
2022-12-30  8:55 ` [PATCH] Ada, Darwin: " Iain Sandoe
2023-01-02  8:42   ` Arnaud Charlet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230102084226.GA14955@adacore.com \
    --to=charlet@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iain@sandoe.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).