From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id D643F3858D1E for ; Mon, 9 Jan 2023 14:07:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D643F3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 96E9844E9 for ; Mon, 9 Jan 2023 14:07:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1673273247; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=I7U/BX1wOZ7lDdq3hBHo6ivUhHDdLicSTkYDU28Z/Hg=; b=Y7fRmjeYZvKkTVWQN5wOfRHXP+++uBHHi8Drm8sX81ZGcYGUra1hYLTliPGkSbF5gQ8yZQ O5Qk0jtPARlHnTqnIlXwlAgvbuibWtGO76o6Mxck8u26nCHNtSnNXKbRIK1Sj5WxHu5yq2 U5jptdkxcUDPvr2He3FPLT6KHGA/MAE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1673273247; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=I7U/BX1wOZ7lDdq3hBHo6ivUhHDdLicSTkYDU28Z/Hg=; b=J+HQJ4uLyWEsE3svy6lk9USrHF3jEdksgmCIDj8mMFXsZzr6jtm/BZemuAQXYNup80Jnkk VECjaZ8MziE7pXCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 78A9C13583 for ; Mon, 9 Jan 2023 14:07:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qYs1HJ8fvGMDIgAAMHmgww (envelope-from ) for ; Mon, 09 Jan 2023 14:07:27 +0000 Date: Mon, 9 Jan 2023 15:07:27 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] middle-end/108209 - typo in genmatch.cc:commutative_op MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Message-Id: <20230109140727.78A9C13583@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The early out for user-id handling indicated commutative rather than not commutative. Bootstrapped and tested on x86_64-unkown-linux-gnu, pushed. PR middle-end/108209 * genmatch.cc (commutative_op): Fix return value for user-id with non-commutative first replacement. --- gcc/genmatch.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/genmatch.cc b/gcc/genmatch.cc index fb9e37ae434..d4cb439a851 100644 --- a/gcc/genmatch.cc +++ b/gcc/genmatch.cc @@ -496,7 +496,7 @@ commutative_op (id_base *id) { int res = commutative_op (uid->substitutes[0]); if (res < 0) - return 0; + return -1; for (unsigned i = 1; i < uid->substitutes.length (); ++i) if (res != commutative_op (uid->substitutes[i])) return -1; -- 2.35.3